From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6720C63697 for ; Sun, 22 Nov 2020 03:31:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99D9E2078E for ; Sun, 22 Nov 2020 03:31:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZKKfKJfp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727096AbgKVDbg (ORCPT ); Sat, 21 Nov 2020 22:31:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727051AbgKVDbg (ORCPT ); Sat, 21 Nov 2020 22:31:36 -0500 Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6A0DC0613CF for ; Sat, 21 Nov 2020 19:31:35 -0800 (PST) Received: by mail-il1-x142.google.com with SMTP id u3so2547375iln.1 for ; Sat, 21 Nov 2020 19:31:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=DMI/wLOC6RBuB5VjNgBslovKlRyC0ZzSlxYxOIZ8Xog=; b=ZKKfKJfpa5EuWPtMs5r1Tf4+cwznpQXBa4SlY+W//0kfw8nwgQle0kti0UJNlsd65m W5Kw9+lpx5GBpCpTXwYz+7xAZNuTfmhxXmz6dJQXR6wsIqHYPbLmvI8op5F3E7WEJVBL qikYJwtPA/qvIzehRQkbDMWWm5YzRvTw+mm+nxE4Vug1rW4YeolKR3RExia+KHj7vPZV WKhFdrJiVHpLZ/JEWBy9dC15rBbFOYdGLjn0WqRu1M0oJkNTBGxJ5aN4KwKJSOkmA3QE KvrP76N/LE0fo8wzVfvvY1NRE28bZdqoV7ca9DfDQ9fh5QNhf+wOKUJh4HPtW2YtDMI4 joGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DMI/wLOC6RBuB5VjNgBslovKlRyC0ZzSlxYxOIZ8Xog=; b=fu75M24lwxDg/gjZE0g0e/97F/azPEpQ63ZhlkmgoERIwaxQNRLBzq6kEHklSTJxmr wLkBiAoeZvDmykMyZVjP+7G/ZYluqxqtF9bN0HHwsgAMSnpPkyNHunutZ2IA70uGkdT6 ZZ6RQpNQFMsFW2rGsW7r6YlOXI0UYCjTQtNTasGh5NtgUHzDkSX9pIbs4B6VFBNQeDlz aIQDpUisNpd1Agj705/Bf33Ko0rv9soAEx5CGS8yr5lcSZGaJ92CZjI/ui1URKUkQ/5L LAN+NrDTvWvD5blFHmfj8t1ZL/i0MAzzP8BeDWq52ByQYqimGW9YJWR9lm/ODTmLMdZr w1Sg== X-Gm-Message-State: AOAM533zD7QY2bZ/C/3HsGO4jXDLG4B0bcRVDJxT5pjz8IsHHOnwfpoj SQaexiiPgoMEY2Euaoq9pkmcvOqatD4IH6bK/Rg= X-Google-Smtp-Source: ABdhPJzMpylpjDJBdZg07evHu9qJ/64m3KtP1H6ZyYm8RE63o99PSZNSmK33hYsYK1CoWbmOhNaUmuoKt7Q7AYq565A= X-Received: by 2002:a92:85c5:: with SMTP id f188mr32207204ilh.173.1606015895279; Sat, 21 Nov 2020 19:31:35 -0800 (PST) MIME-Version: 1.0 References: <1602059975-10115-1-git-send-email-chenhc@lemote.com> <1602059975-10115-3-git-send-email-chenhc@lemote.com> <0dfbe14a-9ddb-0069-9d86-62861c059d12@amsat.org> <9fc6161e-cf27-b636-97c0-9aca77d0f9cd@amsat.org> In-Reply-To: <9fc6161e-cf27-b636-97c0-9aca77d0f9cd@amsat.org> From: Huacai Chen Date: Sun, 22 Nov 2020 11:31:23 +0800 Message-ID: Subject: Re: [PATCH V13 2/9] meson.build: Re-enable KVM support for MIPS To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Jiaxun Yang Cc: Paolo Bonzini , Peter Maydell , Thomas Huth , Huacai Chen , QEMU Developers , Aleksandar Rikalo , Aurelien Jarno , "kvm@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org +CC Jiaxun Hi, Jiaxun, What do you think about? Huacai On Fri, Nov 20, 2020 at 6:55 PM Philippe Mathieu-Daud=C3=A9 wrote: > > On 11/20/20 5:28 AM, Huacai Chen wrote: > > On Wed, Nov 18, 2020 at 1:17 AM Philippe Mathieu-Daud=C3=A9 wrote: > >> On 10/7/20 10:39 AM, Huacai Chen wrote: > >>> After converting from configure to meson, KVM support is lost for MIP= S, > >>> so re-enable it in meson.build. > >>> > >>> Fixes: fdb75aeff7c212e1afaaa3a43 ("configure: remove target configura= tion") > >>> Fixes: 8a19980e3fc42239aae054bc9 ("configure: move accelerator logic = to meson") > >>> Cc: aolo Bonzini > >>> Signed-off-by: Huacai Chen > >>> --- > >>> meson.build | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/meson.build b/meson.build > >>> index 17c89c8..b407ff4 100644 > >>> --- a/meson.build > >>> +++ b/meson.build > >>> @@ -59,6 +59,8 @@ elif cpu =3D=3D 's390x' > >>> kvm_targets =3D ['s390x-softmmu'] > >>> elif cpu in ['ppc', 'ppc64'] > >>> kvm_targets =3D ['ppc-softmmu', 'ppc64-softmmu'] > >>> +elif cpu in ['mips', 'mips64'] > >>> + kvm_targets =3D ['mips-softmmu', 'mipsel-softmmu', 'mips64-softmmu= ', 'mips64el-softmmu'] > >> > >> Are you sure both 32-bit hosts and targets are supported? > >> > >> I don't have hardware to test. If you are not working with > >> 32-bit hardware I'd remove them. > > When I add MIPS64 KVM support (Loongson-3 is MIPS64), MIPS32 KVM is > > already there. On the kernel side, MIPS32 KVM is supported, but I > > don't know whether it can work well. > > Well, from the history, you inherited from it: > > commit 1fa639e5618029e944ac68d27e32a99dcb85a349 > Author: James Hogan > Date: Sat Dec 21 15:53:06 2019 +0000 > > MAINTAINERS: Orphan MIPS KVM CPUs > > I haven't been active for 18 months, and don't have the hardware > set up to test KVM for MIPS, so mark it as orphaned and remove > myself as maintainer. Hopefully somebody from MIPS can pick this up. > > > commit 134f7f7da12aad99daafbeb2a7ba9dbc6bd40abc > Author: Aleksandar Markovic > Date: Mon Feb 24 12:50:58 2020 +0100 > > MAINTAINERS: Reactivate MIPS KVM CPUs > > Reactivate MIPS KVM maintainership with a modest goal of keeping > the support alive, checking common KVM code changes against MIPS > functionality, etc. (hence the status "Odd Fixes"), with hope that > this component will be fully maintained at some further, but not > distant point in future. > > > commit 15d983dee95edff1dc4c0bed71ce02fff877e766 > Author: Aleksandar Markovic > Date: Wed Jul 1 20:25:58 2020 +0200 > > MAINTAINERS: Adjust MIPS maintainership (Huacai Chen & Jiaxun Yang) > > Huacai Chen and Jiaxun Yang step in as new energy [1]. > > > commit ca263c0fb9f33cc746e6e3d968b7db80072ecf86 > Author: Aleksandar Markovic > Date: Wed Oct 7 22:37:21 2020 +0200 > > MAINTAINERS: Remove myself > > I have been working on project other than QEMU for some time, > and would like to devote myself to that project. It is impossible > for me to find enough time to perform maintainer's duties with > needed meticulousness and patience. > > > QEMU deprecation process is quite slow, if we release mips-softmmu > and mipsel-softmmu binaries with KVM support in 5.2, and you can not > test them, you will still have to maintain them during 2021... > > If you don't have neither the hardware nor the time, I suggest you > to only release it on 64-bit hosts. Personally I'd even only > announce KVM supported on the little-endian binary only, because > AFAIK you don't test big-endian KVM neither. > > Your call as a maintainer, but remember last RC tag is next > Tuesday (Nov 24) in *4* days, then we release 5.2: > https://wiki.qemu.org/Planning/5.2#Release_Schedule > > Regards, > > Phil.