From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83508C433E1 for ; Wed, 8 Jul 2020 08:05:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EEC620771 for ; Wed, 8 Jul 2020 08:05:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726408AbgGHIFD (ORCPT ); Wed, 8 Jul 2020 04:05:03 -0400 Received: from mail-il1-f196.google.com ([209.85.166.196]:34891 "EHLO mail-il1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725937AbgGHIFC (ORCPT ); Wed, 8 Jul 2020 04:05:02 -0400 Received: by mail-il1-f196.google.com with SMTP id t18so18384149ilh.2; Wed, 08 Jul 2020 01:05:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=teq7RG3NOrPAL3T2QqpzCt3GlBCAE6hS9MR0+SaSIe0=; b=A8Hpp1qZm11v+u/conzEa2iQ3+1QUy8wKigr+ar4DPLuyyJRaIIrjqIoi3rlFLltAK y3ZG3PNQAKIjYOw9HjwlqEfEZCeDKB2i12W4mUpN5d11sFUdFdwEvFbj1dDTPvWFr6uE Y/Bnqa66AmLKQ83x7BYR7rquhYgtjxiCmATgSWQtdyUwjzTEROfsjfvoLx/nwB8wOdiH SaymnKbLOWPbY0plnGF9kfBWeYdFshIb8ZEGaDTgZ1VTOcgnJP9PmuORQUocdzV//XIf E22VIs4VCFmbCgP+u+ncafhtctSuK6S1Wy4lRFAcT2Ef62UWQfl0sncqgMPBTP1prkLE M1Eg== X-Gm-Message-State: AOAM531WVrMb0nsUlO65EzwHDXbKxSkv33oZ4AGhzDJSIDBc1AqHjvHk +YYhhFnOjWG8b0TxrUM2iDHzvDoRU51/Db8R534= X-Google-Smtp-Source: ABdhPJyX+rvgLwsdzJMlMpE6da/7orHPbs6idGJ8KQ5jJQN/eXYhEdHVRMVcIIV1Xf4248xEOn8Ftw4wKjY0e+LriGc= X-Received: by 2002:a05:6e02:103:: with SMTP id t3mr6082091ilm.147.1594195501767; Wed, 08 Jul 2020 01:05:01 -0700 (PDT) MIME-Version: 1.0 References: <20200706014534.352509-1-jiaxun.yang@flygoat.com> In-Reply-To: <20200706014534.352509-1-jiaxun.yang@flygoat.com> From: Huacai Chen Date: Wed, 8 Jul 2020 16:04:49 +0800 Message-ID: Subject: Re: [PATCH] MIPS: KVM: Convert a fallthrough comment to fallthrough To: Jiaxun Yang Cc: kvm , Aleksandar Markovic , "open list:MIPS" , Thomas Bogendoerfer Content-Type: text/plain; charset="UTF-8" Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Reviewed-by: Huacai Chen On Mon, Jul 6, 2020 at 9:53 AM Jiaxun Yang wrote: > > There is a fallthrough comment being forgotten, > GCC complains about it: > > arch/mips/kvm/emulate.c: In function kvm_mips_emulate_load: > arch/mips/kvm/emulate.c:1936:21: error: this statement may fall through > 1936 | vcpu->mmio_needed = 1; /* unsigned */ > | ~~~~~~~~~~~~~~~~~~^~~ > arch/mips/kvm/emulate.c:1939:2: note: here > 1939 | case lw_op: > > Just fix it. > > Signed-off-by: Jiaxun Yang > --- > arch/mips/kvm/emulate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c > index 5ae82d925197..bb17d8274462 100644 > --- a/arch/mips/kvm/emulate.c > +++ b/arch/mips/kvm/emulate.c > @@ -1934,7 +1934,7 @@ enum emulation_result kvm_mips_emulate_load(union mips_instruction inst, > > case lwu_op: > vcpu->mmio_needed = 1; /* unsigned */ > - /* fall through */ > + fallthrough; > #endif > case lw_op: > run->mmio.len = 4; > -- > 2.27.0 >