From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF9F2C43141 for ; Fri, 15 Nov 2019 01:40:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2FC020727 for ; Fri, 15 Nov 2019 01:40:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bNsKgL/v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727323AbfKOBkP (ORCPT ); Thu, 14 Nov 2019 20:40:15 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:45182 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727022AbfKOBkO (ORCPT ); Thu, 14 Nov 2019 20:40:14 -0500 Received: by mail-lf1-f68.google.com with SMTP id v8so6655046lfa.12 for ; Thu, 14 Nov 2019 17:40:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rFskqtLP2N2VaZi1tFqSAtlpsDvGGv7YPwSPEpuMZEo=; b=bNsKgL/vFHp5Dmh3egwCsmkq3RAyW9y/VBXFH8UbShDrDwtrKHLz34Pn4zFWo7NY3z 5PTmOWxwXywEvoxu/SVKs/6hilrCcEjC1tkbXU0MpRa0Kjf7gd9thLWv7a4NNgMTEhjy R+PXiaXD6Fumb4JQVKY6gBby+WxozAtLDvBfgUxDFoXKVSVk/i0026CQAfFbbcVENqUv nXeDS56UsnuKqn3R+tKNQBxYvYuZ5LuP2VlicTTUdzTi6YuDc/FFH2zGkx6Wyd5uRiC9 rZ15dZyUHKKwXmGVMqaYnwBITAFeEPy2k0xgOebCWOX4T2HsIZT7P1/Hr8okT67PFkqB 09qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rFskqtLP2N2VaZi1tFqSAtlpsDvGGv7YPwSPEpuMZEo=; b=Y25Zy8PbbK06duXyOwf6rEa09p22bYoQJEhq0v+FfjOurs78NYLF6VsHxbJsA6xxo6 SZGFLUgJ4jN0GUMA4pvrgQpzPbmWOAECybpTPa/FNAwUSHGPOMxyeax5YZhxBJAQRV63 UVK5pgcFc9vUKmXsEQlO7h8hE29q+bGGjuAIIH/ztG+SaaX4kSf28sjrKWAO08YvZ7qH Mu/2Cq9nB49VMVThszn66or0a2Mwc29svcYT7ptQiZvc0xjaN2pr07sYN6NmCojBLRKv ZRQkAs8j+lF0h+eoeAo9EXblEHiGCyEHYgzpgkoq1L28ERJ5IcSHv2PLaK621RveH2g4 PyGw== X-Gm-Message-State: APjAAAUo0iSZAwu/GNOM+hDRzzT3ek8Deh5aYQMruLwapWCjiJgH3t/5 H/mk4LkdgAy7M+kZVcZS6RrgZ889NjudqQort7+q1w== X-Google-Smtp-Source: APXvYqz60nURqcP+ihfir96vZTjjr0ZAN8WS3qlm2R92Tk9C+zIRN/Bzmh5fMkWjRsuUPdRJxDb2bptiDaojJBCZVYY= X-Received: by 2002:a19:c790:: with SMTP id x138mr9439033lff.61.1573782011720; Thu, 14 Nov 2019 17:40:11 -0800 (PST) MIME-Version: 1.0 References: <20190710201244.25195-1-brijesh.singh@amd.com> <20190710201244.25195-12-brijesh.singh@amd.com> In-Reply-To: From: Steve Rutherford Date: Thu, 14 Nov 2019 17:39:35 -0800 Message-ID: Subject: Re: [PATCH v3 11/11] KVM: x86: Introduce KVM_SET_PAGE_ENC_BITMAP ioctl To: "Singh, Brijesh" Cc: "kvm@vger.kernel.org" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Joerg Roedel , Borislav Petkov , "Lendacky, Thomas" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Nov 14, 2019 at 5:22 PM Steve Rutherford wrote: > > On Wed, Jul 10, 2019 at 1:13 PM Singh, Brijesh wrote: > > > > struct kvm_arch_async_pf { > > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > > index e675fd89bb9a..31653e8d5927 100644 > > --- a/arch/x86/kvm/svm.c > > +++ b/arch/x86/kvm/svm.c > > @@ -7466,6 +7466,47 @@ static int svm_get_page_enc_bitmap(struct kvm *kvm, > > return ret; > > } > > > > +static int svm_set_page_enc_bitmap(struct kvm *kvm, > > + struct kvm_page_enc_bitmap *bmap) > > +{ > > + struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info; > > + unsigned long gfn_start, gfn_end; > > + unsigned long *bitmap; > > + unsigned long sz, i; > > + int ret; > > + > > + if (!sev_guest(kvm)) > > + return -ENOTTY; > > + > > + gfn_start = bmap->start_gfn; > > + gfn_end = gfn_start + bmap->num_pages; > > + > > + sz = ALIGN(bmap->num_pages, BITS_PER_LONG) / 8; > > + bitmap = kmalloc(sz, GFP_KERNEL); > > This kmalloc should probably be either a vmalloc or kvmalloc. The max > size, if I'm reading kmalloc correctly, is 2^10 pages. That's 4MB, > which should correspond to a bitmap for a 128GB VM, which is a > plausible VM size. > > --Steve Ignore this, you are clearly never going to copy that much in one call, and the backing bitmap correctly uses kvmalloc.