From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3E8022311 for ; Tue, 31 Oct 2023 22:18:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YnhyTsAV" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD69AF1 for ; Tue, 31 Oct 2023 15:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698790703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kfYGCdpNkdX5yz1jUhkJ/3qqRF866UiTHuuzMPk/uy0=; b=YnhyTsAV7CDJyn9CCtUrOaN80u2tDc2pVQu7YfuwgxX1FZbY4tPnYsAYiONumd6FiUJC5R FSXRx9OU1+g+FeXhX34uJL30T5E9Vv7vmOC1HdkVeaA/5sw9NwBaMoOq91ICW/985JiHI+ jg9Sreq+KjY7ZyYnDYVENQdJ0v02plg= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-gccAupiqN1WbtZ0VGHBsoA-1; Tue, 31 Oct 2023 18:18:17 -0400 X-MC-Unique: gccAupiqN1WbtZ0VGHBsoA-1 Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-457cbda3299so2031434137.1 for ; Tue, 31 Oct 2023 15:18:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698790697; x=1699395497; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kfYGCdpNkdX5yz1jUhkJ/3qqRF866UiTHuuzMPk/uy0=; b=SBUDwMHj7s5JAsUl/aLwoXT+BcojnqCgL9uBT98WIt2stojOdSrUr5D2gEq9BXYI1Y zTNfMY11oZD2eoimGcQ8MREUZ4SGFBHSYIhJqfAZ1qekiSuHGHklTjuGOZgyOTxJtVXB m/lpaSdHVciESas67R5LzSjfLr3kmS0tP4TINyB9rfVqgFRu6sOKcMgO3Gaxzcyu2k0b qM6BPmy5jPgBZmnN5Wl6j2Q/9PRxc98TZltBuliJ9iErIex8mgnhMLdYQqkI/l55q5JI Z1zRcRdt3Fsernu+0usCoCcZDMjiO1vniN0DakGkB9tW0wadK5Xp8BZNA/7pOQ5FU4kc BJgA== X-Gm-Message-State: AOJu0YwDkxvxOHExqsyNWaZ7MUwYW+5RZdl0Gx/mehQ6TAJs/pdzK+Xb 7fs7V94C9+MQ9bAwfByZKkDER4zStz08uwqaExzSX3UvNNH4IKDI4nOiSNkmKMo1FWbPnOoyA3M ixqTj1Zrj9k+4jMNp66OYBdpCle23 X-Received: by 2002:a67:c218:0:b0:44e:99a2:a42 with SMTP id i24-20020a67c218000000b0044e99a20a42mr9981756vsj.11.1698790697102; Tue, 31 Oct 2023 15:18:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQrBiQJHLqXrbYP+Ue59NphHDME9ef8CfXr1engDM3UMhS/wxqjXJBm4DCAAdJKCtZSXIUO7Qf2zwxIf8biNY= X-Received: by 2002:a67:c218:0:b0:44e:99a2:a42 with SMTP id i24-20020a67c218000000b0044e99a20a42mr9981736vsj.11.1698790696825; Tue, 31 Oct 2023 15:18:16 -0700 (PDT) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-17-seanjc@google.com> In-Reply-To: From: Paolo Bonzini Date: Tue, 31 Oct 2023 23:18:04 +0100 Message-ID: Subject: Re: [PATCH v13 16/35] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory To: Sean Christopherson Cc: Fuad Tabba , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Oct 31, 2023 at 11:13=E2=80=AFPM Sean Christopherson wrote: > On Tue, Oct 31, 2023, Fuad Tabba wrote: > > On Fri, Oct 27, 2023 at 7:23=E2=80=AFPM Sean Christopherson wrote: > Since we now know that at least pKVM will use guest_memfd for shared memo= ry, and > odds are quite good that "regular" VMs will also do the same, i.e. will w= ant > guest_memfd with the concept of private memory, I agree that we should av= oid > PRIVATE. > > Though I vote for KVM_MEM_GUEST_MEMFD (or KVM_MEM_GUEST_MEMFD_VALID or > KVM_MEM_USE_GUEST_MEMFD). I.e. do our best to avoid ambiguity between re= ferring > to "guest memory" at-large and guest_memfd. I was going to propose KVM_MEM_HAS_GUESTMEMFD. Any option is okay for me so, if no one complains, I'll go for KVM_MEM_GUESTMEMFD (no underscore because I found the repeated "_MEM" distracting). Paolo