From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DFAEC31E4A for ; Thu, 13 Jun 2019 15:25:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4731D2082C for ; Thu, 13 Jun 2019 15:25:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="V1kObx8W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731716AbfFMPY5 (ORCPT ); Thu, 13 Jun 2019 11:24:57 -0400 Received: from mail-io1-f54.google.com ([209.85.166.54]:36365 "EHLO mail-io1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731630AbfFMMMF (ORCPT ); Thu, 13 Jun 2019 08:12:05 -0400 Received: by mail-io1-f54.google.com with SMTP id h6so16324246ioh.3 for ; Thu, 13 Jun 2019 05:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6TnqYw+JH0yXL0cYBb0DT/5cCjybbJ0FkJFzKrPy/Ks=; b=V1kObx8WFKLXYMLDacaZYfPCx7cuX/IA1LFq0ZQgLWAhg1D+voGEfUagJ645qIod/k zGsXPiqk/Lqd34ObQupyesy1ZWwYRn4JJgZYrUNAhinntdvRuvv/WKGNUQ1CzGo77vZI HP27MV24tXmnPjITSM4yW0sUzQZ0bjDFAppf0fVDVLoyoOZEhMRz+m/JrdY2DmbhjqaB /fj1ntsBGZHDRJj9F2KyBisjtbnbm1G19+nfPG0p3m1qvVVNLMemEyuCeVdMA0IngggG vBjhGKmCmQKU4bEJ3/jtx+XCZqrxXvoxyG9f3sF4nQUxGgJ+AV93Oh/GUr/cB65beXrU IHag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6TnqYw+JH0yXL0cYBb0DT/5cCjybbJ0FkJFzKrPy/Ks=; b=UrAWtj2jXQ4oNGJBUsngQ/l8ZQg4oxuCYLo3fL1rjG9J0JH5kR6Msf++gMjeJBiFz3 F1s2FG14ONVbYmgGmpaMmCqWTS9EupJFZinsHGCnHU+eFrqNWlwPvg4STSi9hpw+Z3+k BmwsP6n6hbYEXPj9qC8tZSXTQhhjUmh9tH8bEmLlrTBou/ip2erYJLky8ctDkssNFEM4 e2AGBjBlGjpnjO5TOyTaXz8aszDXubfaehViexnMAUgMn38ib5F3TzMvmUvc9TM7bPfh Hsro+IlQj2D6aeFDhGhb/0MiDZEh5T4bSKqI/ZfPsu6gvSMUmkUSX7JF+NyXJRdBqwX4 0/oQ== X-Gm-Message-State: APjAAAVVIB+PSzBoJkdC0oyxmgg4BUWWxMw3Hph7RoCk6uZi8lAV/O4C MpmX3beQUvzuBk3r3KEExKuH58WD8VcwPQDlCtwwog== X-Google-Smtp-Source: APXvYqyCTIGH2L4bZDuCnup/5Krt+juZXVarS330yujDiKA6yKNS0mtgMz1H4aP3TlXSLRHvxmG6k/hJzd4683l6yRQ= X-Received: by 2002:a6b:fb0f:: with SMTP id h15mr3118490iog.266.1560427923857; Thu, 13 Jun 2019 05:12:03 -0700 (PDT) MIME-Version: 1.0 References: <20190613120659.10680-1-hdanton@sina.com> In-Reply-To: <20190613120659.10680-1-hdanton@sina.com> From: Dmitry Vyukov Date: Thu, 13 Jun 2019 14:11:52 +0200 Message-ID: Subject: Re: memory leak in vhost_net_ioctl To: Hillf Danton Cc: Jason Wang , syzbot , "ast@kernel.org" , "bpf@vger.kernel.org" , "daniel@iogearbox.net" , "davem@davemloft.net" , "hawk@kernel.org" , "jakub.kicinski@netronome.com" , "john.fastabend@gmail.com" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "mst@redhat.com" , "netdev@vger.kernel.org" , "syzkaller-bugs@googlegroups.com" , "virtualization@lists.linux-foundation.org" , "xdp-newbies@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Jun 13, 2019 at 2:07 PM Hillf Danton wrote: > > > Hello Jason > > On Thu, 13 Jun 2019 17:10:39 +0800 Jason Wang wrote: > > > > This is basically a kfree(ubuf) after the second vhost_net_flush() in > > vhost_net_release(). > > > Fairly good catch. > > > Could you please post a formal patch? > > > I'd like very much to do that; but I wont, I am afraid, until I collect a > Tested-by because of reproducer without a cutting edge. You can easily collect Tested-by from syzbot for any bug with a reproducer ;) https://github.com/google/syzkaller/blob/master/docs/syzbot.md#testing-patches