From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B37BC432BE for ; Wed, 25 Aug 2021 05:37:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D3A461100 for ; Wed, 25 Aug 2021 05:37:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232776AbhHYFiR (ORCPT ); Wed, 25 Aug 2021 01:38:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232571AbhHYFiJ (ORCPT ); Wed, 25 Aug 2021 01:38:09 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7303C0613D9 for ; Tue, 24 Aug 2021 22:37:22 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id d6so35227997edt.7 for ; Tue, 24 Aug 2021 22:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3yeuD/AKt6duI6f+LLwvmXj5/7qzqoMz+rmo5sVDYrk=; b=Vp7EsjbsKk4CbMZuzoUYLzrpydiTBr1zHF+HyG9J/wtoW8bsVHI746U+1hvWAKn7pY S2KGD1hdXhYpvRVmdQ6WR1fQxGII47CoeOMGBaYQ/Mi4TolUM5hV7u25ftgsXF0RWGh/ oyRF1xadCZb6aP6wOK20F7wxGFstAZ7BuyRbsRE+aDrQ7ch+4LllkUaJdROcaj8x+KAj ZOy85WB4jyz34slTJHHU6QuKku6j+KC19AfzueBsMNFAdKQmlECIKMC6wJ+DZ7prxUj4 ddL12p3dIBF+Z7rYjgciVlV8upMbYsRSCOxkj2pFlsJcMFqU9/31/TAQO6ln7+ZPJcon AYgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3yeuD/AKt6duI6f+LLwvmXj5/7qzqoMz+rmo5sVDYrk=; b=PzWlwC2MLKaGxI1wvgiF4Q3oE8CSzYGRTcNoJ0u1sRvjtqjoNkK+QyPel8Olmit9dY vXIeiR9dOoXQDdSv4FYuERf9dTVYdayjajJRtO/xQwAbPtFtrfsUjibI0JNhdJNZt/Ef tUy91MsxJakuaj4aCzDfmQ7lYF3TQXBr9FXWSqQtTrw75xz1q1Q9O1rTygUjQAJhMAk8 OgRO+Fis5ng2lDST83H0njjlvTXU3tofH7J1SxG2zR21KnQBqZy2m1xlSup8EuuhTxHk zDeQmrqx98Yz8MyOPKLI3mLLehueuUR4A0scZS72+bWEXxuj9OLrhkpi0SkgfkhlriAM PA5Q== X-Gm-Message-State: AOAM531UbYt/+qkJfyTQkfmA4UHDVFAuqOvtO7i68hpvskPiMG1MHEbJ Kl4LJ91kJfin1iCAIB3Yv9bA2kMCW4/7gS87kpwn X-Google-Smtp-Source: ABdhPJyZTxYAJpwJ1zytuFP4isC6BozsaW7fwdKwUj6HuqFf6QhFlF2KyJtLZvCBCv/uMpGPvMvKn/tLFmS1aI89w14= X-Received: by 2002:a50:fd86:: with SMTP id o6mr6104183edt.312.1629869841320; Tue, 24 Aug 2021 22:37:21 -0700 (PDT) MIME-Version: 1.0 References: <20210818120642.165-1-xieyongji@bytedance.com> <20210818120642.165-12-xieyongji@bytedance.com> <20210824140945-mutt-send-email-mst@kernel.org> In-Reply-To: <20210824140945-mutt-send-email-mst@kernel.org> From: Yongji Xie Date: Wed, 25 Aug 2021 13:37:10 +0800 Message-ID: Subject: Re: [PATCH v11 11/12] vduse: Introduce VDUSE - vDPA Device in Userspace To: "Michael S. Tsirkin" Cc: Jason Wang , Stefan Hajnoczi , Stefano Garzarella , Parav Pandit , Christoph Hellwig , Christian Brauner , Randy Dunlap , Matthew Wilcox , Al Viro , Jens Axboe , bcrl@kvack.org, Jonathan Corbet , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Dan Carpenter , joro@8bytes.org, Greg KH , He Zhe , Liu Xiaodong , Joe Perches , Robin Murphy , songmuchun@bytedance.com, virtualization , netdev@vger.kernel.org, kvm , linux-fsdevel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Aug 25, 2021 at 2:10 AM Michael S. Tsirkin wrote: > > On Wed, Aug 18, 2021 at 08:06:41PM +0800, Xie Yongji wrote: > > This VDUSE driver enables implementing software-emulated vDPA > > devices in userspace. The vDPA device is created by > > ioctl(VDUSE_CREATE_DEV) on /dev/vduse/control. Then a char device > > interface (/dev/vduse/$NAME) is exported to userspace for device > > emulation. > > > > In order to make the device emulation more secure, the device's > > control path is handled in kernel. A message mechnism is introduced > > to forward some dataplane related control messages to userspace. > > > > And in the data path, the DMA buffer will be mapped into userspace > > address space through different ways depending on the vDPA bus to > > which the vDPA device is attached. In virtio-vdpa case, the MMU-based > > software IOTLB is used to achieve that. And in vhost-vdpa case, the > > DMA buffer is reside in a userspace memory region which can be shared > > to the VDUSE userspace processs via transferring the shmfd. > > > > For more details on VDUSE design and usage, please see the follow-on > > Documentation commit. > > > > Signed-off-by: Xie Yongji > > Build bot seems unhappy with this patch. > Yes, this is because the series relies on the unmerged patch: https://lore.kernel.org/lkml/20210705071910.31965-1-jasowang@redhat.com/ Do I need to remove this dependency in the next version? Thanks, Yongji