From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD902C433DB for ; Wed, 27 Jan 2021 09:06:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C3B920758 for ; Wed, 27 Jan 2021 09:06:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231470AbhA0JEf (ORCPT ); Wed, 27 Jan 2021 04:04:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234692AbhA0JBu (ORCPT ); Wed, 27 Jan 2021 04:01:50 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D0D3C06178A for ; Wed, 27 Jan 2021 01:01:04 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id l9so1574844ejx.3 for ; Wed, 27 Jan 2021 01:01:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CvhPrcroD4ScESfvgvRctMUe8FBLv514keyLyHRZDbY=; b=jdd6IZ5rNNH7ay5CWnkO4rDIvKDpbbSemE10InrR25X1zlvICut5ZM0P9AbImglQiu xuwnsi4fd/5NATT4++iicCnxpDnXAYMZ3n4hortkfkhH8uaDRveeYhTgh0Dxh6ZXYyKp fpki+IDTkloZipAXjHXNiStWUny+GS/Jyy53A1+9mZtGouG4E/C5kTsbj126oyg4uK+7 9E47fzC+HywTrBk0RdBZU7zBS449AZPU546g1r7tqu8UDekk3hv9ZHnHREtHYjMSasGs GRs4IMz/ofdHv4Hy2BsDA1HDyTuQdpbMwqLi0aPiLazFjKvvEk7yH01Tx+WUcQJJ2nzS Pwiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CvhPrcroD4ScESfvgvRctMUe8FBLv514keyLyHRZDbY=; b=UwaJo4RYa78wZVWqzS7Q6J6Fl3fjytGug/xig4pHIX2CTbyB2DsLopHrz+FBWQXWSk DDYjumMysZeMr/AvxIvzdc+M8ahjXvZTXo7rIWZ/DHIL5EwpYD/LSXHEGiX/Vyxt+xx8 JVQDqE3zqvxCu8VoP0qDWZG2VQ8tzEZylomYtAgqDqPAtINatZh+vx9Gsg1RbLkqchke UpFhEpUI3SaF0QNU/vs/0kO7h+I8lOXNdZM37nWvrciQmxiRsXBi23Xy9xNE3LdlDzva 1OVFOAm9USbqj2I2NWYYDB7khJKzvt1zY+gEMYxjCAzjsyXgfiFDbTakER1bwsP0YTDR IF0w== X-Gm-Message-State: AOAM532oQoX30g6i4pM3XyeXKtP7yrmnKPiv+lcYyQYaZl3IBBWP9jrk qfzl03shBRgaFAnI8YkpOUBNuoHZQqIE5NZDPXte X-Google-Smtp-Source: ABdhPJxtxlsv/zG/t8Q8ZtEe1vLrLr5egbs6sFwRGutMTUs8mWfam54iv13Bg8Ina5lqMbBMMCqZUnnSbBmDjY8Tn1E= X-Received: by 2002:a17:906:128e:: with SMTP id k14mr5892133ejb.427.1611738063009; Wed, 27 Jan 2021 01:01:03 -0800 (PST) MIME-Version: 1.0 References: <20210119045920.447-1-xieyongji@bytedance.com> <20210119050756.600-1-xieyongji@bytedance.com> <20210119050756.600-5-xieyongji@bytedance.com> <9cacd59d-1063-7a1f-9831-8728eb1d1c15@redhat.com> In-Reply-To: <9cacd59d-1063-7a1f-9831-8728eb1d1c15@redhat.com> From: Yongji Xie Date: Wed, 27 Jan 2021 17:00:52 +0800 Message-ID: Subject: Re: Re: [RFC v3 11/11] vduse: Introduce a workqueue for irq injection To: Jason Wang Cc: "Michael S. Tsirkin" , Stefan Hajnoczi , sgarzare@redhat.com, Parav Pandit , Bob Liu , Christoph Hellwig , Randy Dunlap , Matthew Wilcox , viro@zeniv.linux.org.uk, axboe@kernel.dk, bcrl@kvack.org, Jonathan Corbet , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jan 26, 2021 at 4:17 PM Jason Wang wrote: > > > On 2021/1/19 =E4=B8=8B=E5=8D=881:07, Xie Yongji wrote: > > This patch introduces a dedicated workqueue for irq injection > > so that we are able to do some performance tuning for it. > > > > Signed-off-by: Xie Yongji > > > If we want the split like this. > > It might be better to: > > 1) implement a simple irq injection on the ioctl context in patch 8 > 2) add the dedicated workqueue injection in this patch > > Since my understanding is that > > 1) the function looks more isolated for readers > 2) the difference between sysctl vs workqueue should be more obvious > than system wq vs dedicated wq > 3) a chance to describe why workqueue is needed in the commit log in > this patch > OK, I will try to do it in v4. Thanks, Yongji