KVM Archive on lore.kernel.org
 help / color / Atom feed
From: Christoffer Dall <cdall@cs.columbia.edu>
To: Alexander Graf <agraf@suse.de>
Cc: linux-samsung-soc@vger.kernel.org,
	Kukjin Kim <kgene.kim@samsung.com>,
	linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [kvmarm] [PATCH 3/3] ARM: EXYNOS5250: Register architected timers
Date: Wed, 13 Mar 2013 20:26:24 -0700
Message-ID: <CAEDV+gLmwa__PQ3cNaqmycAekMGY3QwvEkL2AB6gMt7n9Sxujg@mail.gmail.com> (raw)
In-Reply-To: <1363222742-15220-4-git-send-email-agraf@suse.de>

On Wed, Mar 13, 2013 at 5:59 PM, Alexander Graf <agraf@suse.de> wrote:
> When running on an exynos 5250 SoC, we don't initialize the architected
> timers. The chip however supports architected timers.
>
> When we don't initialize them, KVM will try to access them and run into
> NULL pointer dereferences attempting to do so.
>
> This patch is really more of a hack than a real fix, but does get me
> working with KVM on Arndale.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  arch/arm/mach-exynos/mct.c |    4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mach-exynos/mct.c b/arch/arm/mach-exynos/mct.c
> index c9d6650..eefb8af 100644
> --- a/arch/arm/mach-exynos/mct.c
> +++ b/arch/arm/mach-exynos/mct.c
> @@ -482,4 +482,8 @@ void __init exynos4_timer_init(void)
>         exynos4_timer_resources();
>         exynos4_clocksource_init();
>         exynos4_clockevent_init();
> +
> +       if (soc_is_exynos5250()) {
> +               arch_timer_of_register();
> +       }
>  }

I did something similar a while back:
https://github.com/columbia/linux-kvm-arm/commit/2a368f711893e8fb5fe5cf9e237a7631277f3fd1

But I'm not sure how exactly is the right way for exynos. The other
patches look good to me (you can find some very similar work around
that very commit in my tree).

-Christoffer

  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14  0:58 [PATCH 0/3] ARM: EXYNOS5250: Enable KVM support Alexander Graf
2013-03-14  0:59 ` [PATCH 1/3] ARM: EXYNOS5250: dts: Declare the gic as a15 compatible Alexander Graf
2013-03-14  0:59 ` [PATCH 2/3] ARM: EXYNOS5250: dts: Add architected timer nodes Alexander Graf
2013-03-14  0:59 ` [PATCH 3/3] ARM: EXYNOS5250: Register architected timers Alexander Graf
2013-03-14  3:26   ` Christoffer Dall [this message]
2013-03-14 19:07   ` Sergei Shtylyov
2013-03-21 15:40     ` Alexander Graf
2013-04-02 10:44   ` Kukjin Kim
2013-04-02 11:45     ` Alexander Graf
2013-04-03  4:56       ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEDV+gLmwa__PQ3cNaqmycAekMGY3QwvEkL2AB6gMt7n9Sxujg@mail.gmail.com \
    --to=cdall@cs.columbia.edu \
    --cc=agraf@suse.de \
    --cc=kgene.kim@samsung.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

KVM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \
		kvm@vger.kernel.org
	public-inbox-index kvm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.kvm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git