From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18647C432C3 for ; Mon, 2 Dec 2019 18:22:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E04032073C for ; Mon, 2 Dec 2019 18:22:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gX4AoLyX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727979AbfLBSWU (ORCPT ); Mon, 2 Dec 2019 13:22:20 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:37146 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727969AbfLBSWT (ORCPT ); Mon, 2 Dec 2019 13:22:19 -0500 Received: by mail-oi1-f193.google.com with SMTP id x195so573064oix.4 for ; Mon, 02 Dec 2019 10:22:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mt0ebUCDlDgmkudTT+9hpvbvHuHkrX1tE7sw2iHLAt8=; b=gX4AoLyXiyO1zwgoVhMLAVZUSrYejSWLpTUCSkiBTM8KIGfGghefVqaLWftqvuy6Pj 4cuuh7ZuMbET9+Psx6/a854XuTdb/FIimeOv+hyIlMgKru2Z+gmys48h3M6bpd7qoo9S ofXdaDOv6K9Q7aqJGX5dIVqwOB1BkpeOLnfajgNaAq1lWHNwWHsbeX+qxUNwQrkaw7IV l0OBLF0KkTk+meKSgsBIoP0zg7mpiUegHM17p6gMhQsXdFTLCF/wxtN3J6eKS2ec8jk2 4TBtpVV9N/go9/UjgELqSmmQAQ9rNqyRMUgByISLZIzK99yXgFdKnM4GqV1aZa/UWhH4 j7Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mt0ebUCDlDgmkudTT+9hpvbvHuHkrX1tE7sw2iHLAt8=; b=EWeQXRlaUMtNADlZY3WbDgYsoel7Pm8ky+bSSmnBUX7px2KxNB1l81sNp8lHaIRjga 1lq79d2w3rCjSi4qnqNoOBYAUeNHnu4i4OKxHzekz40lhpVFaq+Jr0d+XzYanuCzdhkk StqDsIKM9mdzxhsOLHhNW0E1EdmBtbAbA8tkAGD2afUeEm34cN///wRzrz564WkZDaBt 7nXVXe0wME8oPMtw7B6cDrLNJkl6QfgSXDr8hUfd9HKWY21ld9YfR5LP/rmZ7wL42E8u T4cIOE97nu+rnWlveDTsT0ZYplaOCj4IXgx4qB7h/b8u5gfV9kiR7zKJiecW8pet++jj WAsQ== X-Gm-Message-State: APjAAAWo/iaI2FoCZN8/ffVhhO8LtBkOxXcwKaWWdjTwe+9PeaU73blY 1sATEk64G05V0GgX6cTdszhOKFl8dZq6IiP8uzzuBA== X-Google-Smtp-Source: APXvYqyf9UhXEkFzj9oRHoU3UbqvOfk+HCMVWPzXh2Pv1uoa+7cfVmqFdqUILIrrmurrCqbtkC4dtlXxj6WLaa0+9Hc= X-Received: by 2002:aca:1a0a:: with SMTP id a10mr315133oia.146.1575310938470; Mon, 02 Dec 2019 10:22:18 -0800 (PST) MIME-Version: 1.0 References: <20191111014048.21296-1-zhengxiang9@huawei.com> <20191111014048.21296-2-zhengxiang9@huawei.com> In-Reply-To: <20191111014048.21296-2-zhengxiang9@huawei.com> From: Peter Maydell Date: Mon, 2 Dec 2019 18:22:07 +0000 Message-ID: Subject: Re: [RESEND PATCH v21 1/6] hw/arm/virt: Introduce a RAS machine option To: Xiang Zheng Cc: Paolo Bonzini , "Michael S. Tsirkin" , Igor Mammedov , Shannon Zhao , Laszlo Ersek , James Morse , gengdongjiu , Marcelo Tosatti , Richard Henderson , Eduardo Habkost , Jonathan Cameron , "xuwei (O)" , kvm-devel , QEMU Developers , qemu-arm , Linuxarm , wanghaibin.wang@huawei.com Content-Type: text/plain; charset="UTF-8" Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 11 Nov 2019 at 01:44, Xiang Zheng wrote: > > From: Dongjiu Geng > > RAS Virtualization feature is not supported now, so add a RAS machine > option and disable it by default. > > Signed-off-by: Dongjiu Geng > Signed-off-by: Xiang Zheng > --- > hw/arm/virt.c | 23 +++++++++++++++++++++++ > include/hw/arm/virt.h | 1 + > 2 files changed, 24 insertions(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index d4bedc2607..ea0fbf82be 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -1819,6 +1819,20 @@ static void virt_set_its(Object *obj, bool value, Error **errp) > vms->its = value; > } > > +static bool virt_get_ras(Object *obj, Error **errp) > +{ > + VirtMachineState *vms = VIRT_MACHINE(obj); > + > + return vms->ras; > +} > + > +static void virt_set_ras(Object *obj, bool value, Error **errp) > +{ > + VirtMachineState *vms = VIRT_MACHINE(obj); > + > + vms->ras = value; > +} > + > static char *virt_get_gic_version(Object *obj, Error **errp) > { > VirtMachineState *vms = VIRT_MACHINE(obj); > @@ -2122,6 +2136,15 @@ static void virt_instance_init(Object *obj) > "Valid values are none and smmuv3", > NULL); > > + /* Default disallows RAS instantiation */ > + vms->ras = false; > + object_property_add_bool(obj, "ras", virt_get_ras, > + virt_set_ras, NULL); > + object_property_set_description(obj, "ras", > + "Set on/off to enable/disable " > + "RAS instantiation", > + NULL); I think we could make the user-facing description of the option a little clearer: something like "Set on/off to enable/disable reporting host memory errors to a KVM guest using ACPI and guest external abort exceptions" ? Otherwise Reviewed-by: Peter Maydell thanks -- PMM