From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4183BC10F14 for ; Tue, 15 Oct 2019 14:53:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 134D42054F for ; Tue, 15 Oct 2019 14:53:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xub1vEGE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732931AbfJOOxL (ORCPT ); Tue, 15 Oct 2019 10:53:11 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:41096 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732539AbfJOOxL (ORCPT ); Tue, 15 Oct 2019 10:53:11 -0400 Received: by mail-oi1-f194.google.com with SMTP id w65so17047719oiw.8 for ; Tue, 15 Oct 2019 07:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pJHLxWBHfbqmvzOZUSxQLaGo5BYoxOcdXmYT8MESVjw=; b=xub1vEGEH9eORcaWMny1wqHLHVDX8S+d+vqaqqeWA5aKqQSbiX7OrCIGAthe6hu1/d Mrp97VpPtfEgTqcvJ62iH5fRPmM3VcGoRg/OBifl4WEPwpYj64dGvu8B6yBHQ82l5neY eaEnn00p8ynrcNEPceCCijGcb42XzIddNsoN6st0PvBxXwPKwN/36BY7RG6KBgSmNy6p 7/IzPL33RNCtbClPxUtV7wBEfETxpz57wORrtVJodn0AlQ+9IEfAc2E46iFBGz54CXva puTcYU/tgOJ3lLl32zPvdBjNWrRTFQjp+D+CFZksw41S9zGnVWzuT5WBCdW7khas7YPq B/qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pJHLxWBHfbqmvzOZUSxQLaGo5BYoxOcdXmYT8MESVjw=; b=EdPo28xbp7Dk0sd2pXAnr6NSbWXjDZXI25dw7jQFA5FesYY5y2jun1Cbgz3b2iqxLP LzL91bXkAsjWLhI1VhWt3EWBvMK0D3Ymff+6aAhVDog2jYBnwfD7+3ClMTyQKMb+0Lkd RmjDLYbbKNW+uOCewbrp2gQPWis4om9S/6Ia+X03WC+2BuWGXcQqsh4hl/3kdYOJAxeT 2szbsHHCYiex+tyStPJOJBAvFcqsr3TSlAV0/R/gZYtglHYuI3opibkD5lxb9mSL12BB sFKmcuuXZhsiEsiQz18wFzfe43kHb8L2Coqb+JlQ/SdB5Qn28+3zzqMERH/GCtwbWONq Usiw== X-Gm-Message-State: APjAAAWPvTUNVQAgBL1SFevtUZzXPp8SxYKDqYgo8nmHn0C1bH5VVUCX SJMYsHDB9a3SKe4nyOsmhBVTi3mxP3YpcNHQuMCmqg== X-Google-Smtp-Source: APXvYqzqvQComCBgFaQw5Q1kH9xNYO35eAfDsvhDHQduxNV0EVl/ym25KkAdWnopvPsA8eHPMLcixw9oewjaRJjJJ+s= X-Received: by 2002:a54:4e83:: with SMTP id c3mr29597998oiy.170.1571151190401; Tue, 15 Oct 2019 07:53:10 -0700 (PDT) MIME-Version: 1.0 References: <20191015140140.34748-1-zhengxiang9@huawei.com> <20191015140140.34748-4-zhengxiang9@huawei.com> In-Reply-To: <20191015140140.34748-4-zhengxiang9@huawei.com> From: Peter Maydell Date: Tue, 15 Oct 2019 15:52:59 +0100 Message-ID: Subject: Re: [PATCH v19 3/5] ACPI: Add APEI GHES table generation support To: Xiang Zheng Cc: Paolo Bonzini , "Michael S. Tsirkin" , Igor Mammedov , Shannon Zhao , Laszlo Ersek , James Morse , gengdongjiu , Marcelo Tosatti , Richard Henderson , Eduardo Habkost , Jonathan Cameron , "xuwei (O)" , kvm-devel , QEMU Developers , qemu-arm , Linuxarm , wanghaibin.wang@huawei.com Content-Type: text/plain; charset="UTF-8" Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 15 Oct 2019 at 15:02, Xiang Zheng wrote: > > From: Dongjiu Geng > > This patch implements APEI GHES Table generation via fw_cfg blobs. Now > it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, > we can extend the supported types if needed. For the CPER section, > currently it is memory section because kernel mainly wants userspace to > handle the memory errors. > > This patch follows the spec ACPI 6.2 to build the Hardware Error Source > table. For more detailed information, please refer to document: > docs/specs/acpi_hest_ghes.rst > > Suggested-by: Laszlo Ersek > Signed-off-by: Dongjiu Geng > Signed-off-by: Xiang Zheng > + /* Error Status Address */ > + build_append_gas(table_data, AML_SYSTEM_MEMORY, 0x40, 0, > + 4 /* QWord access */, 0); Hi; this doesn't seem to compile with clang: /home/petmay01/linaro/qemu-from-laptop/qemu/hw/acpi/acpi_ghes.c:330:34: error: implicit conversion from enumeration type 'AmlRegionSpace' to different enumeration type 'AmlAddressSpace' [-Werror,-Wenum-conversion] build_append_gas(table_data, AML_SYSTEM_MEMORY, 0x40, 0, ~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~ /home/petmay01/linaro/qemu-from-laptop/qemu/hw/acpi/acpi_ghes.c:351:34: error: implicit conversion from enumeration type 'AmlRegionSpace' to different enumeration type 'AmlAddressSpace' [-Werror,-Wenum-conversion] build_append_gas(table_data, AML_SYSTEM_MEMORY, 0x40, 0, ~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~ 2 errors generated. Should these be AML_AS_SYSTEM_MEMORY, or should the build_append_gas() function be taking an AmlRegionSpace rather than an AmlAddressSpace ? thanks -- PMM