From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D94EC32792 for ; Mon, 30 Sep 2019 21:59:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60042215EA for ; Mon, 30 Sep 2019 21:59:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tVGXXjv3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727681AbfI3V7r (ORCPT ); Mon, 30 Sep 2019 17:59:47 -0400 Received: from mail-ua1-f68.google.com ([209.85.222.68]:45096 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726005AbfI3V7r (ORCPT ); Mon, 30 Sep 2019 17:59:47 -0400 Received: by mail-ua1-f68.google.com with SMTP id j5so4737961uak.12 for ; Mon, 30 Sep 2019 14:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QtvBdRQvi1GH0t6lRFmlMlveMzJkrpmQEmG0i+pGsaA=; b=tVGXXjv39mIHjDE8vkeaxDpBLSJTrjk0DQI3r8U1Tq3B3PLMJQQ1HSLscmpgLMoG/q GUvWf5+0GWYee9ePx6k1nipidvubKzt1p+d8KQX4JKFqvLZb0LF2cgZ4yzdnZBHpVVKn TxjN0QSDf64YxFyJL/hq4V4ScjryBUpp1rAnkuDkEQ9kLpN6gJ3Q+eYR8aQcJnQYwJP8 AOrEVEPvSp2XXdJg2CV3KZ98w7tuc/IsVtfp2WHr8JyAFgdnsYEG0kf0S2TDv7n7Yv/8 1sbw14NrtfuW1frpWa+oJ8tYnEesbQGff9u7axg7vPZXUhsc3nJ/QXIKCFiG6hcc2YKt tNsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QtvBdRQvi1GH0t6lRFmlMlveMzJkrpmQEmG0i+pGsaA=; b=HFTqOz9m/SCpjBAq7ny2lyEw5Wsx53Ff5HtLIgAhTNf7pL8Gq0NedkEeB/zTpMh/na 3L0DVX1QdZq+0rJHYNMmw+9xsiyuH5wdKiddmDQyDucTOwIXJK5Gw9Rn2/X4OXqhsQC6 bqY5IK0L+pOkel374MGurQD9ghPH50Mobzp1se1aV/Qt1LKoHXdgpVSU79TVYzbykmTu d8XhDfHBVQH70ZXIBlMewLLWYdRLxH8HuPtlhpNJJo0kDPXvf1G6KwJrqKMElD9v/0bp 4Swri5u4ZDqldioXrKPM4u4qXtZCCIPcBh0wb5uKMTafeaEIUP/S4936B53MpbJyFoGo lQsg== X-Gm-Message-State: APjAAAWSv+6EBGL/79biPmTd1WMpFnZG5yLVA4er9irzWqeMFLhF+6IW nUizb2+WA2QkhSg4SoIP9jyzaw3QXk6Y+6akO7KN X-Google-Smtp-Source: APXvYqxrgOLUkrBWGYd7LUi01TPfr5SHcJMXNSkmDWYsJ3R89XLi6pDv6N/sv22wYx+0GbYBCqlEejnS+QzOf3ex0N4= X-Received: by 2002:ab0:6046:: with SMTP id o6mr12343745ual.75.1569880785522; Mon, 30 Sep 2019 14:59:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bill Wendling Date: Mon, 30 Sep 2019 14:59:34 -0700 Message-ID: Subject: Re: [kvm-unit-tests PATCH] lib: use an argument which doesn't require default argument promotion To: Jim Mattson , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Cc: kvm list Content-Type: text/plain; charset="UTF-8" Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Sep 10, 2019 at 9:43 AM Jim Mattson wrote: > > On Mon, Sep 9, 2019 at 4:12 PM Bill Wendling wrote: > > > > Clang warns that passing an object that undergoes default argument > > promotion to "va_start" is undefined behavior: > > > > lib/report.c:106:15: error: passing an object that undergoes default > > argument promotion to 'va_start' has undefined behavior > > [-Werror,-Wvarargs] > > va_start(va, pass); > > > > Using an "unsigned" type removes the need for argument promotion. > > > > Signed-off-by: Bill Wendling > Reviewed-by: Jim Mattson