From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AF9CC4332F for ; Tue, 18 Oct 2022 13:12:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230243AbiJRNMQ (ORCPT ); Tue, 18 Oct 2022 09:12:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbiJRNMJ (ORCPT ); Tue, 18 Oct 2022 09:12:09 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34318C7847 for ; Tue, 18 Oct 2022 06:12:06 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id p3-20020a17090a284300b0020a85fa3ffcso17323147pjf.2 for ; Tue, 18 Oct 2022 06:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GfgN++TPk0fTsXy49wFUN76bG9RP2vq/hMwME62fwuc=; b=CGXkSB9uywrxsgCdNFPuLJClpIMUtjLodXrbG2P6EA5GDH5qtFAFuSefrX06MNdx7K y09Se10ajet7taVCaFyZi5lU6ag1p1po3SpuOj8qa3ikH+Rhy59iG7l+QvmqL3EkjN1g 02iO9A1tXmi11e1B8e5QzJHbGC3Ty5fk85n0M0JIFt1xLmuspHls3QZxaKuje3aZt5ag jKBZzNMOFbine3wnRei1n1ogxTbx+zgim9cZLm19B9KInwPb4DFozHlLtBgniMPhONqF kf3LWS87AjBafRqd8MEgPuVjgs1JSn14EQmTft/SLeBBC4E94/3AjdGqwXR3t43SATD6 +8dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GfgN++TPk0fTsXy49wFUN76bG9RP2vq/hMwME62fwuc=; b=i4CxKJwKqAmoK75S0YUr2jXT23t95GG8BpQ9mQkoT8SlBNnaj6qZf7g2bqZomkc/hh CLtVkyrKSmz+06Ro/H108DjD8IRRXewh0hl2l7S1tIW0sta+TGvGaD9CGWd3cW4jp1zr Nz5k2vErJMARf3w8/paSSGKQCBGI2Dnrl+pDoAglgXeyRkn9mPb4GZ+2lxGXzrnGTDnq oxLID5I33BPTECPOtkdkoZ9VmamCq7SFPWzDMT4qT4qmKg4IkK2/ktx/JxEaEr5TKOF4 Vp25OmmrZI9JA/A64WY3j/QvdXnKgbTojm3IXqbmGiQjHX4/LkQYMrfdl3sIL8XdPsFr 0crg== X-Gm-Message-State: ACrzQf0l74VH1l/OExgZzVBUKmEbEjCioeuDDuHcIucJjsvtwNNR1tPR 97CtYSEjM3095SQR++k+iiTPpDaxbXikCrlMhRZUhw== X-Google-Smtp-Source: AMsMyM6WIAnvbu3GJwLi+rnRvx9SP9n/YV8ENAQvAYkNqJyKnq+TLw0aAHXTKYafdDi0g5pfux+aSCbMtCBn6X8DJwg= X-Received: by 2002:a17:90b:38c3:b0:20d:406e:26d9 with SMTP id nn3-20020a17090b38c300b0020d406e26d9mr3569457pjb.121.1666098725139; Tue, 18 Oct 2022 06:12:05 -0700 (PDT) MIME-Version: 1.0 References: <20220819174659.2427983-1-vannapurve@google.com> <20220819174659.2427983-4-vannapurve@google.com> In-Reply-To: From: Vishal Annapurve Date: Tue, 18 Oct 2022 18:41:53 +0530 Message-ID: Subject: Re: [RFC V3 PATCH 3/6] selftests: kvm: ucall: Allow querying ucall pool gpa To: Sean Christopherson Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, pbonzini@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, shuah@kernel.org, yang.zhong@intel.com, drjones@redhat.com, ricarkol@google.com, aaronlewis@google.com, wei.w.wang@intel.com, kirill.shutemov@linux.intel.com, corbet@lwn.net, hughd@google.com, jlayton@kernel.org, bfields@fieldses.org, akpm@linux-foundation.org, chao.p.peng@linux.intel.com, yu.c.zhang@linux.intel.com, jun.nakajima@intel.com, dave.hansen@intel.com, michael.roth@amd.com, qperret@google.com, steven.price@arm.com, ak@linux.intel.com, david@redhat.com, luto@kernel.org, vbabka@suse.cz, marcorr@google.com, erdemaktas@google.com, pgonda@google.com, nikunj@amd.com, diviness@google.com, maz@kernel.org, dmatlack@google.com, axelrasmussen@google.com, maciej.szmigiero@oracle.com, mizhang@google.com, bgardon@google.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Oct 17, 2022 at 11:38 PM Sean Christopherson wrote: > > On Mon, Oct 17, 2022, Vishal Annapurve wrote: > > This is much sleeker and will avoid hacking KVM for testing. Only > > caveat here is that these tests will not be able to exercise implicit > > conversion path if we go this route. > > Yeah, I think that's a perfectly fine tradeoff. Implicit conversion isn't strictly > a UPM feature, e.g. if TDX and SNP "architecturally" disallowed implicit conversions, > then KVM wouldn't need to support implicit conversions at all, i.e. that testing can > be punted to SNP and/or TDX selftests. Ack. Will address this feedback in the next series.