From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F658C433ED for ; Thu, 13 May 2021 13:03:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 450FE61421 for ; Thu, 13 May 2021 13:03:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233712AbhEMNEa (ORCPT ); Thu, 13 May 2021 09:04:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28501 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232807AbhEMNE2 (ORCPT ); Thu, 13 May 2021 09:04:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620910999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=reFKUH6rrlF+AA2394T7GVrIVtOgj3DePRS0lsPMuB0=; b=iU1pLIUggdeYLMe1RxV77TwP4TKS8095Zp61qXjpBza/f0Z8Tm+JsWicylTuwZTxBpBrKC Rqkw/KsfHRHLh/R13T3ePwUM0gMWfOkE/KmJcdYmKPiqRmN9woLdMtj/2u5lQlKJcvltKG s0fWXco4hNiFJdguvQQkM6PSNkzmPv4= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-338-fVcc9EJNN1yxx_SmhV_IvA-1; Thu, 13 May 2021 09:03:17 -0400 X-MC-Unique: fVcc9EJNN1yxx_SmhV_IvA-1 Received: by mail-ed1-f70.google.com with SMTP id r19-20020a05640251d3b02903888eb31cafso14600298edd.13 for ; Thu, 13 May 2021 06:03:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=reFKUH6rrlF+AA2394T7GVrIVtOgj3DePRS0lsPMuB0=; b=JFp+73fuGALW6k8rqQfKyVITMNJYohM9XxFhB92mvJGXOmdRZWTwsfpWuyKb0y6ReA /ibXB+RT3aMyQMVwBuIdf2e+Ezf0Z8SlZ0MmE37GgJNrDUHxVjbNA4wMcIM20EdE6cPR ADAmab2CJw0SHvrZT7pAGtcYMrJIhPB1u8gblleM6oF9ExGMqamMQe3ZkIsN8U3XK6gI sCLZRp46/xapxF3AVMZ25CYLJochg56BjJ/AQyz6yc6hvmZ8LsRFI5a0n1UIRliDI7oi InYhM1LqH6KWy/2y2Z9zqJZQEB43Q6du7b8KCatQVD+RFETGonm9t1Q8Q1mBkk+k9ox2 U1tA== X-Gm-Message-State: AOAM532Z3qEg5/L79liW5Ci9FFwj1aDtKHVHccuCDfyhzxAoXJjKnxx7 nSEfVJS8Wp2YkEundAhQMl1bNQdCz5OYA2qICxKUHx6/bVBe9fqYSXA+SrjQxaBV8pRzFmBd0fb QyTNoKM0NTwj4 X-Received: by 2002:a17:906:a017:: with SMTP id p23mr44269255ejy.460.1620910996141; Thu, 13 May 2021 06:03:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlZU02TavvxbBUmfRJG32boBnlj1iP4tM0Qg/JAmvchXWsqL5Ii9AcVBluYmGFZU6Zj7oJcg== X-Received: by 2002:a17:906:a017:: with SMTP id p23mr44269235ejy.460.1620910995957; Thu, 13 May 2021 06:03:15 -0700 (PDT) Received: from steredhat (host-79-18-148-79.retail.telecomitalia.it. [79.18.148.79]) by smtp.gmail.com with ESMTPSA id h4sm2157154edv.97.2021.05.13.06.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 06:03:15 -0700 (PDT) Date: Thu, 13 May 2021 15:03:13 +0200 From: Stefano Garzarella To: Arseny Krasnov Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jorgen Hansen , Andra Paraschiv , Colin Ian King , Norbert Slusarek , kvm , Linux Virtualization , netdev , kernel list , stsp , Krasnov Arseniy Subject: Re: [RFC PATCH v9 13/19] virtio/vsock: rest of SOCK_SEQPACKET support Message-ID: References: <20210508163027.3430238-1-arseny.krasnov@kaspersky.com> <20210508163558.3432246-1-arseny.krasnov@kaspersky.com> <20210513122708.mwooglzkhv7du7jo@steredhat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210513122708.mwooglzkhv7du7jo@steredhat> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org sdf On Thu, May 13, 2021 at 2:27 PM Stefano Garzarella wrote: > > On Sat, May 08, 2021 at 07:35:54PM +0300, Arseny Krasnov wrote: > >This adds rest of logic for SEQPACKET: > >1) Send SHUTDOWN on socket close for SEQPACKET type. > >2) Set SEQPACKET packet type during send. > >3) 'seqpacket_allow' flag to virtio transport. > > Please update this commit message, point 3 is not included anymore in > this patch, right? > > >4) Set 'VIRTIO_VSOCK_SEQ_EOR' bit in flags for last > > packet of message. > > > >Signed-off-by: Arseny Krasnov > >--- > > v8 -> v9: > > 1) Use cpu_to_le32() to set VIRTIO_VSOCK_SEQ_EOR. > > > > include/linux/virtio_vsock.h | 4 ++++ > > net/vmw_vsock/virtio_transport_common.c | 17 +++++++++++++++-- > > 2 files changed, 19 insertions(+), 2 deletions(-) > > > >diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h > >index 02acf6e9ae04..7360ab7ea0af 100644 > >--- a/include/linux/virtio_vsock.h > >+++ b/include/linux/virtio_vsock.h > >@@ -80,6 +80,10 @@ virtio_transport_dgram_dequeue(struct vsock_sock *vsk, > > struct msghdr *msg, > > size_t len, int flags); > > > >+int > >+virtio_transport_seqpacket_enqueue(struct vsock_sock *vsk, > >+ struct msghdr *msg, > >+ size_t len); > > ssize_t > > virtio_transport_seqpacket_dequeue(struct vsock_sock *vsk, > > struct msghdr *msg, > >diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c > >index 7fea0a2192f7..b6608b4ac7c2 100644 > >--- a/net/vmw_vsock/virtio_transport_common.c > >+++ b/net/vmw_vsock/virtio_transport_common.c > >@@ -74,6 +74,10 @@ virtio_transport_alloc_pkt(struct virtio_vsock_pkt_info *info, > > err = memcpy_from_msg(pkt->buf, info->msg, len); > > if (err) > > goto out; > >+ > >+ if (info->msg->msg_iter.count == 0) > > Also here is better `msg_data_left(info->msg)` > > >+ pkt->hdr.flags = cpu_to_le32(info->flags | > >+ VIRTIO_VSOCK_SEQ_EOR); > > Re-thinking an alternative could be to set EOR here... > > info->flags |= VIRTIO_VSOCK_SEQ_EOR; Or just `pkt->hdr.flags |= cpu_to_le32(VIRTIO_VSOCK_SEQ_EOR)`, as you did in vhost-vsock :-)