From: Yosry Ahmed <yosryahmed@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Marc Zyngier <maz@kernel.org>
Cc: Huang@google.com, Tejun Heo <tj@kernel.org>,
Shaoqin <shaoqin.huang@intel.com>,
Cgroups <cgroups@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeelb@google.com>,
Jim Mattson <jmattson@google.com>,
James Morse <james.morse@arm.com>, Joerg Roedel <joro@8bytes.org>,
Wanpeng Li <wanpengli@tencent.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Oliver Upton <oupton@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Linux-MM <linux-mm@kvack.org>, Zefan Li <lizefan.x@bytedance.com>
Subject: Re: [PATCH v6 0/4] KVM: mm: count KVM mmu usage in memory stats
Date: Thu, 30 Jun 2022 14:01:52 -0700 [thread overview]
Message-ID: <CAJD7tkb3bDwt0gzOhS+3sSiy20Qy=G_AD8jZeY5DYh4=NyX3Bg@mail.gmail.com> (raw)
In-Reply-To: <20220628220938.3657876-1-yosryahmed@google.com>
If/when this patchset gets merged, would it be through the mm tree or
kvm tree? It is based on the kvm-queue branch so I am guessing it
could be easier to go through kvm but I am not sure what the policy is
here. Andrew or Paolo, do you mind clarifying the policy on such
patchsets? Thanks!
On Tue, Jun 28, 2022 at 3:09 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> Add NR_SECONDARY_PAGETABLE memory stat and use it to account KVM mmu
> usage as the first type of accounted secondary page tables. This stat
> can be later extended to account for other types of secondary pages
> tables (e.g. iommu page tables).
>
> Rationale behind why this is useful and link to extended discussion in
> the first patch.
>
> ---
>
> Changes in V6:
> - Rebased on top of kvm/queue and fixed conflicts.
> - Fixed docs spaces and tabs (Sean).
> - More narrative commit logs (Sean and Oliver).
> - Updated kvm_account_pgtable_pages() documentation to describe the
> rules of using it more clearly (Sean).
> - Collected Acks and Reviewed-by's by Shakeel and Oliver (Thanks!)
>
> Changes in V5:
> - Updated cover letter to explain more the rationale behind the change
> (Thanks to contributions by Sean Christopherson).
> - Removed extraneous + in arm64 patch (Oliver Upton, Marc Zyngier).
> - Shortened secondary_pagetables to sec_pagetables (Shakeel Butt).
> - Removed dependency on other patchsets (applies to queue branch).
>
> Changes in V4:
> - Changed accounting hooks in arm64 to only account s2 page tables and
> refactored them to a much cleaner form, based on recommendations from
> Oliver Upton and Marc Zyngier.
> - Dropped patches for mips and riscv. I am not interested in those archs
> anyway and don't have the resources to test them. I posted them for
> completeness but it doesn't seem like anyone was interested.
>
> Changes in V3:
> - Added NR_SECONDARY_PAGETABLE instead of piggybacking on NR_PAGETABLE
> stats.
>
> Changes in V2:
> - Added accounting stats for other archs than x86.
> - Changed locations in the code where x86 KVM page table stats were
> accounted based on suggestions from Sean Christopherson.
>
> ---
>
> Yosry Ahmed (4):
> mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses.
> KVM: mmu: add a helper to account memory used by KVM MMU.
> KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats.
> KVM: arm64/mmu: count KVM s2 mmu usage in secondary pagetable stats
>
> Documentation/admin-guide/cgroup-v2.rst | 5 ++++
> Documentation/filesystems/proc.rst | 4 +++
> arch/arm64/kvm/mmu.c | 36 ++++++++++++++++++++++---
> arch/x86/kvm/mmu/mmu.c | 16 +++++++++--
> arch/x86/kvm/mmu/tdp_mmu.c | 12 +++++++++
> drivers/base/node.c | 2 ++
> fs/proc/meminfo.c | 2 ++
> include/linux/kvm_host.h | 10 +++++++
> include/linux/mmzone.h | 1 +
> mm/memcontrol.c | 1 +
> mm/page_alloc.c | 6 ++++-
> mm/vmstat.c | 1 +
> 12 files changed, 89 insertions(+), 7 deletions(-)
>
> --
> 2.37.0.rc0.161.g10f37bed90-goog
>
prev parent reply other threads:[~2022-06-30 21:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 22:09 [PATCH v6 0/4] KVM: mm: count KVM mmu usage in memory stats Yosry Ahmed
2022-06-28 22:09 ` [PATCH v6 1/4] mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses Yosry Ahmed
2022-06-29 10:29 ` Marc Zyngier
2022-07-07 20:59 ` Sean Christopherson
2022-07-12 23:03 ` Yosry Ahmed
2022-07-12 23:05 ` Sean Christopherson
2022-07-18 18:26 ` Yosry Ahmed
2022-08-08 20:06 ` Yosry Ahmed
2022-08-15 9:18 ` Yosry Ahmed
2022-08-15 15:13 ` Johannes Weiner
2022-08-15 15:39 ` Yosry Ahmed
2022-08-17 17:25 ` Andrew Morton
2022-08-17 17:24 ` Andrew Morton
2022-08-17 22:27 ` Yosry Ahmed
2022-08-23 0:04 ` Yosry Ahmed
2022-08-23 0:08 ` Andrew Morton
2022-06-28 22:09 ` [PATCH v6 2/4] KVM: mmu: add a helper to account memory used by KVM MMU Yosry Ahmed
2022-06-29 10:30 ` Marc Zyngier
2022-07-07 21:08 ` Sean Christopherson
2022-07-12 23:03 ` Yosry Ahmed
2022-06-28 22:09 ` [PATCH v6 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats Yosry Ahmed
2022-07-07 21:11 ` Sean Christopherson
2022-06-28 22:09 ` [PATCH v6 4/4] KVM: arm64/mmu: count KVM s2 " Yosry Ahmed
2022-06-29 10:30 ` Marc Zyngier
2022-06-30 21:01 ` Yosry Ahmed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJD7tkb3bDwt0gzOhS+3sSiy20Qy=G_AD8jZeY5DYh4=NyX3Bg@mail.gmail.com' \
--to=yosryahmed@google.com \
--cc=Huang@google.com \
--cc=akpm@linux-foundation.org \
--cc=alexandru.elisei@arm.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=james.morse@arm.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=maz@kernel.org \
--cc=mhocko@kernel.org \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=roman.gushchin@linux.dev \
--cc=seanjc@google.com \
--cc=shakeelb@google.com \
--cc=shaoqin.huang@intel.com \
--cc=suzuki.poulose@arm.com \
--cc=tj@kernel.org \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).