From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 455BEC432BE for ; Wed, 1 Sep 2021 22:43:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 138D56108E for ; Wed, 1 Sep 2021 22:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244710AbhIAWof (ORCPT ); Wed, 1 Sep 2021 18:44:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232082AbhIAWof (ORCPT ); Wed, 1 Sep 2021 18:44:35 -0400 Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00149C061575 for ; Wed, 1 Sep 2021 15:43:37 -0700 (PDT) Received: by mail-yb1-xb33.google.com with SMTP id c6so3958ybm.10 for ; Wed, 01 Sep 2021 15:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U+r4CwgKG+yEodhHzC7nFI5Y9Wnbyo4zL9qFFX9zlnM=; b=JOkMP8RXO6jdIjIDD6ZH3jrv9UvB6l279lUpP6filw3CBk6k1N1Hwj4bB+HLyMDRma boD3ZbnLqtdnNwuqesuS2HLMkqRyrZHeaia+pvNPCT5BKtEqWOmyEyiXQxJAyJC7Tf9q 4ZnqybnkHfs+Ms/08GdCeE+nkY2Z4/6wD9jZtk51UPliBiGeD3r02osFUGdJfXWK+37N Rh2HJkrC41dh2GjZCh7Y9ajtEv3CGhIGQOw3dol55gzG/dj6A8DAPpPCYb1Sl+W+o/jy 0sCXMnz+HIYSyDRFWFsuXdBSq+fQWnvW9N3oN7tIEn+y26OGONWz2qjuMjcUCQuC9gw/ GLqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U+r4CwgKG+yEodhHzC7nFI5Y9Wnbyo4zL9qFFX9zlnM=; b=I+cZJwG30Jc8gh8Sm2PwafmEUVrEcTCE+B3HeNo8Rsc2EGBmOnUSqVQQ06NuewMbKa s2uD5nSpUxFkVLq/5cf0dYr6duQ6ZoCyvxdOlRigp8qucRwF91TExOR7YDHRY9otZ9Yb eG7+nQF8PYw9fezKi0oeBdo+wpLT956hzhTV12sMI2UlXE5ynb7SYxeogmBHwiP9j10s Hl7gVXpRuLjPBDkyx+WltJxl89D3vETNixuUWQhNf6JPHEF+3vhF9zZmRu3J22eW2nI6 phTobADxnZzUurV4SFuycz5fZ8HXTpFdLO26Yke7yRu/pgyHixrtXKwK1kBrrBNR6IPc 6hhQ== X-Gm-Message-State: AOAM530LlO6Wm1pL9NuxMUtY5jA9F821ZGa+cF7EgcM0aK067gdw6e/Q RqqhfFQVfPJnJoqzElVyLq4pxV7pzH0ww4YEdoWDJA== X-Google-Smtp-Source: ABdhPJzi+Lf0Xejnkm0ckXhh2uNvzEvpcGrgx17PRpTaVpfoZFF6sLe4mbguXZjsOTaBLHIIADIlXq1Ey2THBjkzhnc= X-Received: by 2002:a25:6507:: with SMTP id z7mr276648ybb.439.1630536217085; Wed, 01 Sep 2021 15:43:37 -0700 (PDT) MIME-Version: 1.0 References: <20210901211412.4171835-1-rananta@google.com> <20210901211412.4171835-2-rananta@google.com> In-Reply-To: From: Raghavendra Rao Ananta Date: Wed, 1 Sep 2021 15:43:24 -0700 Message-ID: Subject: Re: [PATCH v3 01/12] KVM: arm64: selftests: Add MMIO readl/writel support To: Oliver Upton Cc: Paolo Bonzini , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Peter Shier , Ricardo Koller , Reiji Watanabe , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Sep 1, 2021 at 2:23 PM Oliver Upton wrote: > > On Wed, Sep 01, 2021 at 09:14:01PM +0000, Raghavendra Rao Ananta wrote: > > Define the readl() and writel() functions for the guests to > > access (4-byte) the MMIO region. > > > > The routines, and their dependents, are inspired from the kernel's > > arch/arm64/include/asm/io.h and arch/arm64/include/asm/barrier.h. > > > > Signed-off-by: Raghavendra Rao Ananta > > --- > > .../selftests/kvm/include/aarch64/processor.h | 45 ++++++++++++++++++- > > 1 file changed, 44 insertions(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/kvm/include/aarch64/processor.h b/tools/testing/selftests/kvm/include/aarch64/processor.h > > index c0273aefa63d..3cbaf5c1e26b 100644 > > --- a/tools/testing/selftests/kvm/include/aarch64/processor.h > > +++ b/tools/testing/selftests/kvm/include/aarch64/processor.h > > @@ -130,6 +130,49 @@ void vm_install_sync_handler(struct kvm_vm *vm, > > val; \ > > }) > > > > -#define isb() asm volatile("isb" : : : "memory") > > +#define isb() asm volatile("isb" : : : "memory") > > Is this a stray diff? > Oh no, that's intentional. Just trying to align with others below. Regards, Raghavendra > Otherwise: > > Reviewed-by: Oliver Upton