From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FB82C4167B for ; Wed, 9 Dec 2020 18:50:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4EE623C44 for ; Wed, 9 Dec 2020 18:50:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730901AbgLISu3 (ORCPT ); Wed, 9 Dec 2020 13:50:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:27596 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731168AbgLISu2 (ORCPT ); Wed, 9 Dec 2020 13:50:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607539742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ZdtDVnVSLorYMf0VwrM99dH6Rak2Bc4C+97zOEHdxY=; b=OnNniVY8/pADg5bhmkfgdzo8Xlg04yazL6ma77dje9HHqASpIpN6eYPK9x8quFaH/XJjtF 4BNHKdUZ73ChYmE8XJ4c3nG90Q+/SdaV7g8Vcczm/WlC1tVDDGK8eKVWWov5s4MtoGLtZa x7RhJ+tfXIv4Fz+LRXVoCHav0zI1Ikg= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-514-7iwc_1LkMFqJ4UTQYb4hww-1; Wed, 09 Dec 2020 13:49:00 -0500 X-MC-Unique: 7iwc_1LkMFqJ4UTQYb4hww-1 Received: by mail-qk1-f199.google.com with SMTP id z129so1782174qkb.13 for ; Wed, 09 Dec 2020 10:49:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2ZdtDVnVSLorYMf0VwrM99dH6Rak2Bc4C+97zOEHdxY=; b=TbFTpx2eEZ9zixsxXihOOQ37fc/OAWiXJWVVRnnVyVNuJS10HjV2uKElTeC2xkArHj 3lgdy22zlHka8INV0IT3aWCTSG8vfEtIH8IOlk68Szyo8yZs3xLANYl6EZB9qAJFKmaA lf7ENg8xGiL5spf90RtZOq4zGk185Qr4xITyEA6qm7EOb0i1nPY74fzyJ6gB2Ain+hPx t6V8cPbzuWthvFhmUp0Y6/7RSB3QqCNDDDUPxmG2Xr6xY7Qv8n2EZlhznb7XCn4jSlxY VLbz5c2eoF84ds6lxJ6HIVZHK3rTY3wY1YkuEXU+EuvnWbSoKi47ucJT2IHe8e22HVhQ VYxQ== X-Gm-Message-State: AOAM531Ke6wNXZ1ndbhRFMgT9lYNcrqtwIJxRGS2JyS8QLG+bSSMZxeZ Cv2NyIvvJljulAciX8QUlbqI/atvPbEDN8GFzz/E5F0s9olaAta5ozN4URzgZ8EkGRuUfRVOCSb GS9+CtfgU9WAT+HbwuuIE0jBFkroP X-Received: by 2002:ac8:e06:: with SMTP id a6mr4783865qti.384.1607539740287; Wed, 09 Dec 2020 10:49:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzUDRcl0vkOdfin0XBAKi1xojbc8ggj/scgMp3QAm6uN/Gb1T8m4oXNBcerz4NAW0ctj6nhIRule5lH9IWXXNI= X-Received: by 2002:ac8:e06:: with SMTP id a6mr4783839qti.384.1607539740115; Wed, 09 Dec 2020 10:49:00 -0800 (PST) MIME-Version: 1.0 References: <20201120185105.279030-1-eperezma@redhat.com> <20201120185105.279030-19-eperezma@redhat.com> <20201208084158.GU203660@stefanha-x1.localdomain> In-Reply-To: <20201208084158.GU203660@stefanha-x1.localdomain> From: Eugenio Perez Martin Date: Wed, 9 Dec 2020 19:48:24 +0100 Message-ID: Subject: Re: [RFC PATCH 18/27] vhost: add vhost_vring_poll_rcu To: Stefan Hajnoczi Cc: qemu-level , Lars Ganrot , virtualization@lists.linux-foundation.org, Salil Mehta , "Michael S. Tsirkin" , Liran Alon , Rob Miller , Max Gurtovoy , Alex Barba , Stefan Hajnoczi , Jim Harford , Jason Wang , Harpreet Singh Anand , Christophe Fontaine , vm , Daniel Daly , Michael Lilja , Stefano Garzarella , Nitin Shrivastav , Lee Ballard , Dmytro Kazantsev , Juan Quintela , kvm list , Howard Cai , Xiao W Wang , Sean Mooney , Parav Pandit , Eli Cohen , Siwei Liu , Stephen Finucane Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Dec 8, 2020 at 9:42 AM Stefan Hajnoczi wrote: > > On Fri, Nov 20, 2020 at 07:50:56PM +0100, Eugenio P=C3=A9rez wrote: > > @@ -83,6 +89,18 @@ void vhost_vring_set_notification_rcu(VhostShadowVir= tqueue *vq, bool enable) > > smp_mb(); > > } > > > > +bool vhost_vring_poll_rcu(VhostShadowVirtqueue *vq) > > A name like "more_used" is clearer than "poll". I agree, I will rename. Thanks!