From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EE97C433DF for ; Fri, 9 Oct 2020 19:31:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EA4C2237B for ; Fri, 9 Oct 2020 19:31:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="hXg/sBmJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390450AbgJITbi (ORCPT ); Fri, 9 Oct 2020 15:31:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388857AbgJITbf (ORCPT ); Fri, 9 Oct 2020 15:31:35 -0400 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87626C0613D6 for ; Fri, 9 Oct 2020 12:31:33 -0700 (PDT) Received: by mail-ot1-x341.google.com with SMTP id d28so10055022ote.1 for ; Fri, 09 Oct 2020 12:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ySYcyJJ3sOG5YMU4GVRG3lJgkS40H3Co9lykIQ/+sFM=; b=hXg/sBmJSAZ0qahG3krkGP++08QEfAEMObPCQZW5DNP0jHoKuyBCogfErWstdU2/EU 4l6+qOuyilHrRv6mQOMt0oKIaOKSkC6+0fry3akULqNmxrd1f0WP5RaWhgCgr3v3riEu U91Cvo/twFXWkhQ9v9MjLxy+AB8Sb+wfsvumA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ySYcyJJ3sOG5YMU4GVRG3lJgkS40H3Co9lykIQ/+sFM=; b=QZ5s9W6RAs9SMVJ5dKx/M/w2pW58WpuItoB0cvAgK/T72eDgc5wrQfy1Kl+aXNX1WM uchIyNKu/r9OGuGFEFO2zGppOJld/5HYz0Foz+Sxd+iN7Zmt0TfUnYeewnF8LPfcHOIS Twbe0DxVOFKUDlyk7C2PTkH59giPKr8chdkMuXCUyEHhlMBAZJ4qQeCoR2rPu2qgLcKM DCQqGeRZlRH5KIPNAqn+mLGOi4wuvGzI6s2J85ktCL6F7nlSYOH0WWLepOEBxMq+m2FO GW0+qasuhOcyBCfc9gNEa0puLZHdbUM+QzyR/wiL60j+KGkW0PWi1F1XHd6mIXF3RBqC MEcA== X-Gm-Message-State: AOAM531WaftLMo8Nm3V3p6eAWJ/tQO7i+vfZnSP5F5xxBmmKpp907Pa4 ck0sPQl55Voh2d2tsmzsO+UwNBxbAZPliQxpIHJmW1cNr+Gmog== X-Google-Smtp-Source: ABdhPJyt5F3KZ1qsKCAYucLfuox0J0LV3cC5oyQ21k96htMG1d9Z2x9WEkAwzZmqGd0OEOmrQ583B82fEkZeh8i2caA= X-Received: by 2002:a05:6830:1647:: with SMTP id h7mr10464001otr.281.1602271892694; Fri, 09 Oct 2020 12:31:32 -0700 (PDT) MIME-Version: 1.0 References: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> <20201009075934.3509076-10-daniel.vetter@ffwll.ch> <20201009123421.67a80d72@coco.lan> <20201009122111.GN5177@ziepe.ca> <20201009143723.45609bfb@coco.lan> <20201009124850.GP5177@ziepe.ca> <20201009180145.GB5177@ziepe.ca> In-Reply-To: <20201009180145.GB5177@ziepe.ca> From: Daniel Vetter Date: Fri, 9 Oct 2020 21:31:21 +0200 Message-ID: Subject: Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn To: Jason Gunthorpe Cc: Mauro Carvalho Chehab , DRI Development , LKML , KVM list , Linux MM , Linux ARM , linux-samsung-soc , "open list:DMA BUFFER SHARING FRAMEWORK" , linux-s390 , Daniel Vetter , Kees Cook , Dan Williams , Andrew Morton , John Hubbard , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jan Kara , Linus Torvalds Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Oct 9, 2020 at 8:01 PM Jason Gunthorpe wrote: > > On Fri, Oct 09, 2020 at 07:52:05PM +0200, Daniel Vetter wrote: > > > > > If this is the case, the proper fix seems to have a GFP_NOT_MOVABLE > > > > flag that it would be denying the core mm code to set __GFP_MOVABLE. > > > > > > We can't tell from the VMA these kinds of details.. > > > > > > It has to go the other direction, evey mmap that might be used as a > > > userptr here has to be found and the VMA specially created to allow > > > its use. At least that is a kernel only change, but will need people > > > with the HW to do this work. > > > > I think the only reasonable way to keep this working is: > > - add a struct dma_buf *vma_tryget_dma_buf(struct vm_area_struct *vma); > > - add dma-buf export support to fbdev and v4l > > - roll this out everywhere we still need it. > > It seems to me there is a technical way forward to restore user > compat, so it is really no different than RDMA/DRM pain we both > suffered before. > > Thus no justification to NAK it. If media wants things to keep working > they have to do the technical path like you outline above. > > > Realistically this just isn't going to happen. > > If your series goes ahead it will get solved. Someone will take on the > huge project to either add DMA buf to the drivers people still care > about, or do the work above to transparently handle in kernel. > > If we allow things to keep working without consequence then nobody > will do it. > > The only reason we did the 4 years of work in RDMA was because Linus > went in and broke the uABI for a security fix. It was hundreds of > patches to fix it, so I don't have much sympathy for "it is too hard" > here. Oh fully agreeing with you here, I just wanted to lay out that a) there is a solid plan to fix it and b) it's way too much work for me to just type it as a part of a "learn me some core mm semantics" project :-) I was hoping that we could get away with a special marker for problematic vma, and filter those out. But after all the digging I've noticed that on anything remotely modern, there's just nothing left. Device memory management has become massively more dynamic in the past 10 years. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch