From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 578CDC32771 for ; Sun, 12 Jan 2020 09:45:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 247632187F for ; Sun, 12 Jan 2020 09:45:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lz/w3v3F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732395AbgALJnP (ORCPT ); Sun, 12 Jan 2020 04:43:15 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:45034 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732307AbgALJnO (ORCPT ); Sun, 12 Jan 2020 04:43:14 -0500 Received: by mail-lj1-f196.google.com with SMTP id u71so6692515lje.11 for ; Sun, 12 Jan 2020 01:43:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=uQmpwxVEj1cR4VjtZn7xRR3NzxiwsRUjQ/Q0ih7Ijuw=; b=lz/w3v3FvAImk7GIfeLMkjq7yFJEO27+zK0Trfs/b6YTLzlbx4zyrGmcYD5lup1nyi hdf54ZKtgUWMHwcA0ZCauN1r7BGXb6sRsJpw3sc2lLdV84h+oDivN4YzY2GdJWcD5NF9 LCPlvrzEl/MnPz6qdIEt4MUWdwQLVWLs2e0+L+imOZHL1QBd9Q1RiURQ1Z7G3bVESAKX xvWR8jjK6XeaCb6+QObz4P49sgddj7H8lfmdPdysgvTLtuc0nfea0P9EaAptRhhP86KQ EwArp9tWLTwNvdSjCwwcbGNfG/uVQmNGZCefwAQFRAtttELBxu22e/W1/EXG2/jNkH9J kmqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=uQmpwxVEj1cR4VjtZn7xRR3NzxiwsRUjQ/Q0ih7Ijuw=; b=bz35zvexeMyRyNjy12iCWgO3wYbA4UGoliXL/DOOcZQRINS3gk7rvEZogwnuRSloDh tM5P894SqgaKzgeX2N51ust9Z1one/0QeLwaeuzNBDyEoCpy8HXU3+IRyNX+v1DHRwfl /avP4kS+QFvpwAKl03+fhujXnkWepTvtp07vv47CChwOlIvkyF8SabkGOiY1OFrHaidl Uoe41lYvyuCxkjXqwott8/3EixbP6Gs4KOrAyqgweMtp3gLDP65CigQ1C2wdcLQmy4dK jCpLT8nhhF4zs5lMS0vQlfD/KO8GBB7R2uxVe7JGzynghlUBKV4Hb57kBtaKl896yA8+ xMhQ== X-Gm-Message-State: APjAAAX+GCFy9gNQAkIY3usg46TBo0LPTlXGbYkyb0KbJGUn4p/wc1Zx qSVsFCg5ABoCaxlrl4XX9Z6ATUIBmkiYxtnx+zU= X-Google-Smtp-Source: APXvYqx2g1B8y9igJ79V+P1O1imbGLRFl3oMl1i8j7mLFRCVYeIYDi7trAw9KXRVQNnUEJuDknDqFeYmZsHJGGOEhaU= X-Received: by 2002:a2e:9b03:: with SMTP id u3mr7679182lji.87.1578822193085; Sun, 12 Jan 2020 01:43:13 -0800 (PST) MIME-Version: 1.0 References: <20200109152133.23649-1-philmd@redhat.com> <20200109152133.23649-6-philmd@redhat.com> In-Reply-To: <20200109152133.23649-6-philmd@redhat.com> From: Alistair Francis Date: Sun, 12 Jan 2020 17:42:45 +0800 Message-ID: Subject: Re: [PATCH 05/15] device-hotplug: Replace current_machine by qdev_get_machine() To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: "qemu-devel@nongnu.org Developers" , Peter Maydell , Eduardo Habkost , "open list:Overall" , Juan Quintela , "open list:New World" , Marcelo Tosatti , "Dr. David Alan Gilbert" , qemu-arm , Alistair Francis , Paolo Bonzini , David Gibson , Richard Henderson Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Jan 9, 2020 at 11:27 PM Philippe Mathieu-Daud=C3=A9 wrote: > > As we want to remove the global current_machine, > replace MACHINE_GET_CLASS(current_machine) by > MACHINE_GET_CLASS(qdev_get_machine()). > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > device-hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/device-hotplug.c b/device-hotplug.c > index f01d53774b..44d687f254 100644 > --- a/device-hotplug.c > +++ b/device-hotplug.c > @@ -45,7 +45,7 @@ static DriveInfo *add_init_drive(const char *optstr) > if (!opts) > return NULL; > > - mc =3D MACHINE_GET_CLASS(current_machine); > + mc =3D MACHINE_GET_CLASS(qdev_get_machine()); > dinfo =3D drive_new(opts, mc->block_default_type, &err); > if (err) { > error_report_err(err); > -- > 2.21.1 > >