From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E7C4C33CA9 for ; Tue, 14 Jan 2020 01:59:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F7EC20CC7 for ; Tue, 14 Jan 2020 01:59:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ldG5Kb8X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729346AbgANB7g (ORCPT ); Mon, 13 Jan 2020 20:59:36 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:41984 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728838AbgANB7g (ORCPT ); Mon, 13 Jan 2020 20:59:36 -0500 Received: by mail-lf1-f65.google.com with SMTP id y19so8473095lfl.9 for ; Mon, 13 Jan 2020 17:59:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5OXR1lgWAptLKU3W0CQIZNE+hOvlwc8nHcCeOKgikCc=; b=ldG5Kb8Xh6+ISy/6M54NdrAwwDLsh66IGzfYLcVVU4QSsBHgAHo3KU4OxzOD/8Ic68 plq1yDtgwqyTzATD/ld0jlxwDkm3v2+KbGdHf4Rn1TTntg2f3e+dJ+A4cQKDUOUqj/K2 T806kS52ldq6cOCKN0qXiNVZlgN/pBHxiUl4S5P9mnt5JJcg/pXSCUUxzqOTGqbZMuXo WTPo8k2HjXHyWns5E4e8rN64JFSPmYm87BxhTbq0cCuUX6EJt1aCp7GyAlQ80J9O29dd KRtoMDGxeDhgZqImrxAZAvW8Px3NHISp3unhudz/I1Iyn+tp16qmBO9+FA9NUBIGKkkf U9tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5OXR1lgWAptLKU3W0CQIZNE+hOvlwc8nHcCeOKgikCc=; b=AcgnLZTLVSe1UTztWScgKrB+9DFPZjuiFO5+jbyQcPyOv1TTY3slCVZCktYE/GI66D k72Vw3OpDTCfqcrgXW1nGeYIBdOkb7YzaUv7HilaqF+5aPzxZh7HIzSso4HtRp4C4Kwl gIlFmByRQitSUQCA1JQ8rCgFgZzZwmEDGRZZ+VwantJxzUemHC1YtiMdogt8S+RxPtMZ fuD4ceyzprawRX3CDPLPxrp32rfWeMSGKMJylSXDxJVdKNwLqTgIZYhXaUOqpVfAzKj1 GOOboCtoh33rasDXU1sVcWAVH/lVOwlOuf8WKoSd3KaQFiHRJ1H/KKsiqAL0ZPxY01Du UBXw== X-Gm-Message-State: APjAAAVHcAINJ2vb4iDH8bqqyQJlg43ycMelZ3CmscWxVNnDEHKgGMcG /wbsG82TK75gsHfZEgd/FdMSl4wuo7VGQzG1Kxc= X-Google-Smtp-Source: APXvYqyc60nAVZIP/khaHSKFSbqDkQ8o2ZT3rRwZZiRCLs8WEvt5bZycEm1x0HSBiWNbIlCrFwD/SlCWkEpEDF8sqQQ= X-Received: by 2002:ac2:46dc:: with SMTP id p28mr235710lfo.23.1578967174451; Mon, 13 Jan 2020 17:59:34 -0800 (PST) MIME-Version: 1.0 References: <20200109152133.23649-1-philmd@redhat.com> <20200109152133.23649-13-philmd@redhat.com> In-Reply-To: <20200109152133.23649-13-philmd@redhat.com> From: Alistair Francis Date: Tue, 14 Jan 2020 11:59:07 +1000 Message-ID: Subject: Re: [PATCH 12/15] accel: Introduce the current_accel() method To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: "qemu-devel@nongnu.org Developers" , Peter Maydell , Eduardo Habkost , "open list:Overall" , Juan Quintela , "open list:New World" , Marcelo Tosatti , "Dr. David Alan Gilbert" , qemu-arm , Alistair Francis , Paolo Bonzini , David Gibson , Richard Henderson Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Jan 10, 2020 at 1:27 AM Philippe Mathieu-Daud=C3=A9 wrote: > > We want to remove the global current_machine. The accel/ > code access few times current_machine->accelerator. Introduce > the current_accel() method first, it will then be easier to > replace 'current_machine' by MACHINE(qdev_get_machine()). > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > include/sysemu/accel.h | 2 ++ > accel/accel.c | 5 +++++ > 2 files changed, 7 insertions(+) > > diff --git a/include/sysemu/accel.h b/include/sysemu/accel.h > index d4c1429711..47e5788530 100644 > --- a/include/sysemu/accel.h > +++ b/include/sysemu/accel.h > @@ -70,4 +70,6 @@ int accel_init_machine(AccelState *accel, MachineState = *ms); > /* Called just before os_setup_post (ie just before drop OS privs) */ > void accel_setup_post(MachineState *ms); > > +AccelState *current_accel(void); > + > #endif > diff --git a/accel/accel.c b/accel/accel.c > index 1c5c3a6abb..cb555e3b06 100644 > --- a/accel/accel.c > +++ b/accel/accel.c > @@ -63,6 +63,11 @@ int accel_init_machine(AccelState *accel, MachineState= *ms) > return ret; > } > > +AccelState *current_accel(void) > +{ > + return current_machine->accelerator; > +} > + > void accel_setup_post(MachineState *ms) > { > AccelState *accel =3D ms->accelerator; > -- > 2.21.1 > >