From: Nick Desaulniers <ndesaulniers@google.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
kernel test robot <lkp@intel.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
Yishai Hadas <yishaih@nvidia.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [vfio:next 33/38] drivers/gpu/drm/i915/i915_pci.c:975:2: warning: missing field 'override_only' initializer
Date: Fri, 1 Oct 2021 10:18:20 -0700 [thread overview]
Message-ID: <CAKwvOdkVAKOCH1hfSqNphKco8rLOmyAg0PVGzmpMRu6Svs1hSQ@mail.gmail.com> (raw)
In-Reply-To: <878rzdt3a3.fsf@intel.com>
On Fri, Oct 1, 2021 at 4:04 AM Jani Nikula <jani.nikula@linux.intel.com> wrote:
>
> Anyway, we've got
>
> subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers)
> subdir-ccflags-y += $(call cc-disable-warning, initializer-overrides)
>
> in drivers/gpu/drm/i915/Makefile, so I wonder why they're not respected.
You do have to be super careful with `:=` assignment in Make;
generally folks mean to use `+=` and end up overwriting the existing
KBUILD_CFLAGS. I'm not sure if that's the issue here, but it's worth
an audit of your Makefiles.
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2021-10-01 17:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 15:12 [vfio:next 33/38] drivers/gpu/drm/i915/i915_pci.c:975:2: warning: missing field 'override_only' initializer kernel test robot
2021-08-27 15:34 ` Jason Gunthorpe
2021-10-01 11:04 ` Jani Nikula
2021-10-01 11:51 ` Jason Gunthorpe
2021-10-05 9:00 ` Jani Nikula
2021-10-01 17:18 ` Nick Desaulniers [this message]
2021-10-01 17:45 ` [Intel-gfx] " Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdkVAKOCH1hfSqNphKco8rLOmyAg0PVGzmpMRu6Svs1hSQ@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=alex.williamson@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kbuild-all@lists.01.org \
--cc=kvm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mgurtovoy@nvidia.com \
--cc=rodrigo.vivi@intel.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).