From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBC76C433EF for ; Mon, 6 Sep 2021 20:05:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB9A16069E for ; Mon, 6 Sep 2021 20:05:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236274AbhIFUGj (ORCPT ); Mon, 6 Sep 2021 16:06:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229717AbhIFUGi (ORCPT ); Mon, 6 Sep 2021 16:06:38 -0400 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F473C061575 for ; Mon, 6 Sep 2021 13:05:33 -0700 (PDT) Received: by mail-yb1-xb2a.google.com with SMTP id q70so15412854ybg.11 for ; Mon, 06 Sep 2021 13:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Lm4jdiDuWbqAv4O7YJ6wZ0vVIEpUpOQJ86d4UA/6SjA=; b=I5fTuvgnT9HxQ8xV0WPigXQzCZJUNgH1XdAnBxrfTTXtABBsN58Equ7pN+lofptQr5 v8AJZEUyQ5CEVJ1PuLnXmMsIggU6WfCOxXtAskYJS3GsrojX31Qqk/lQu3VEDJXYq6Gi F3LhosFyS3VlcpzONHNaDcLIchdgiL5v4NA35UZSDxOFigjbi3/k2ZSVwDtxBAdMLeEh PiApND73vDcx4gkZyX2ovCBhM57vfLg6OLSOS0lritofSJz4hrdw/sM8mUdEhTGvv1aw U7mhhYqzmX6t+hCI8DkX+hR+3KQpqsrlj3AtMfivn9VVLvlapxzhUfpCVoN9HAmKa7Ej E3Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lm4jdiDuWbqAv4O7YJ6wZ0vVIEpUpOQJ86d4UA/6SjA=; b=Jeu2nOjtV13uC7K3n/Gc6l9vUzrmOPM7+kn18X5H279bZjZSfT/t187qIVYfR26o49 SokvSRavpcN1PNuZhLem5ifbqAIDtLAvV88PHisr3EktXfRYio1OYF8Ij1dJU2y3TzHP PlD3Y5kzcNu9UQRtuQ/VcSruBjn4h22q57M13+GkOtiKVZFzwNcLYrGHeTM92xfTy4iX kDHgAVhmponHoTyddn6ya/pihzHjc7r8h4fBr777AaQ5HoKHJBSeeFN7LYLmWsNWxRGg bSD71adKclor1xRqed7XL9xXBFhThUMHRefHq7sQJ1yAjUZmhZDvSbEn7qaU4Nm79GZg TIpg== X-Gm-Message-State: AOAM530MB9qj7gI38FJKqWJxshuxpIUfPTrmPvej2mKj4925UItvIDq9 kaeIW1MezatQKpDKpb+nlM1Dp4lKwIVn7N1WfDoXHQ== X-Google-Smtp-Source: ABdhPJxRjqK/FZ4AoWTnkr8ASqTSmfC1tsb9qFvW2zNIHqFPVPi5jMbxh0tyslfhYDzSJFTj5fVm7boyJH+vPTsyD1I= X-Received: by 2002:a25:3046:: with SMTP id w67mr18083671ybw.134.1630958732615; Mon, 06 Sep 2021 13:05:32 -0700 (PDT) MIME-Version: 1.0 References: <20210830044425.2686755-1-mizhang@google.com> <20210830044425.2686755-3-mizhang@google.com> In-Reply-To: From: Mingwei Zhang Date: Mon, 6 Sep 2021 13:05:21 -0700 Message-ID: Subject: Re: [PATCH v3 2/2] selftests: KVM: use dirty logging to check if page stats work correctly To: Sean Christopherson Cc: Ben Gardon , Paolo Bonzini , kvm , LKML , David Matlack , Jing Zhang , Peter Xu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Aug 31, 2021 at 9:58 AM Sean Christopherson wrote: > > On Mon, Aug 30, 2021, Ben Gardon wrote: > > On Sun, Aug 29, 2021 at 9:44 PM Mingwei Zhang wrote: > > > diff --git a/tools/testing/selftests/kvm/lib/test_util.c b/tools/testing/selftests/kvm/lib/test_util.c > > > index af1031fed97f..07eb6b5c125e 100644 > > > --- a/tools/testing/selftests/kvm/lib/test_util.c > > > +++ b/tools/testing/selftests/kvm/lib/test_util.c > > > @@ -15,6 +15,13 @@ > > > #include "linux/kernel.h" > > > > > > #include "test_util.h" > > > +#include "processor.h" > > > + > > > +static const char * const pagestat_filepaths[] = { > > > + "/sys/kernel/debug/kvm/pages_4k", > > > + "/sys/kernel/debug/kvm/pages_2m", > > > + "/sys/kernel/debug/kvm/pages_1g", > > > +}; > > > > I think these should only be defined for x86_64 too. Is this the right > > file for these definitions or is there an arch specific file they > > should go in? > > The stats also need to be pulled from the selftest's VM, not from the overall KVM > stats, otherwise the test will fail if there are any other active VMs on the host, > e.g. I like to run to selftests and kvm-unit-tests in parallel. That is correct. But since this selftest is not the 'default' selftest that people normally run, can we make an assumption on running these tests at this moment? I am planning to submit this test and improve it in the next series by using Jing's fd based KVM stats interface to eliminate the assumption of the existence of a single running VM. Right now, this interface still needs some work, so I am taking a shortcut that directly uses the whole-system metricfs based interface. But I can choose to do that and submit the fd-based API together with this series. What do you suggest?