From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F048CC33C8C for ; Mon, 6 Jan 2020 20:16:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4344207FF for ; Mon, 6 Jan 2020 20:16:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Tx133Dbu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726779AbgAFUQx (ORCPT ); Mon, 6 Jan 2020 15:16:53 -0500 Received: from mail-io1-f67.google.com ([209.85.166.67]:35692 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbgAFUQx (ORCPT ); Mon, 6 Jan 2020 15:16:53 -0500 Received: by mail-io1-f67.google.com with SMTP id h8so2904026iob.2 for ; Mon, 06 Jan 2020 12:16:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ad1Ao2TlSfLCNigJ6Pa+3nawhinGXzkpiWfEgqcNlkE=; b=Tx133DbulEz48pvKM16QrOTa6SZ28yS4BBeei2HnoOx+0KVySJgiNWMTLHVNcbxMqs +uzP9l3dy899SpHobHnByiwalfHz4eThgOlxnvMCV1GO5KJViLO/Yx47cRhfzuYfWq7W nSvVHrkyVWVmKOf8scyQmojf2UkxHBnkOsKsPrGkoju1JDAMgXefnp9f0eJ0HmKH7G70 c4NSG2PXorEyu0HFzENfdo7Mf2U5DXvN46b2g7TDNb8XfcAltl9bmlnHIUTRZblFQvTb p2js4weuJx6rCjiwnnfjOZuFlwFBFkTcHFspYJQ+WczeLq4SrTWmOgqbzFQxxn8/95UJ 06VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ad1Ao2TlSfLCNigJ6Pa+3nawhinGXzkpiWfEgqcNlkE=; b=rbquRJ4pcVYF1idK05nxNSOeKH36vR24DatKMI0lRHJUibnsYVrDizMjpOtIoqg2bJ +sI30G5jexrtCqOW7qUlKAG5aSlKC0fCkN3b1ft6IFXLsw6ghM62CfWx4lPf0dlc+AvG 5oOryIcKE1ZhYNVjoIYfg4/7t4DPlSn0CZa+m6/nQ9UGYk3DtaFRjPux1lcsDw4pOSMB Xo2QmjR13FuFPjqSsCiQH8ohpKWiVvigE8xs5+6B7M7AFLBLg3F37I2mgsg46LQ+VVbl 00lucV9mbIfbn+a60uZfemHjhPZX00J30Ks/0XSUU43FIX/95KD7NzW+TNkehKy/xH3H 7AsA== X-Gm-Message-State: APjAAAUFm1m4TdzJ4zpurJwlRxaeYhvqfm6GzwLh8drWgGVbG1UP4LvM Ddw/KNkAXv/mNtkx04kThZCzbq+Jb5FHGYrVZH8U0w== X-Google-Smtp-Source: APXvYqwwxRjaUDXqnO8pwICqhkfTcFjemZ9i/gfqccux/oxs4oMkZdlQpoikYKZZolo7WWtBG/O8CGjdGya5UKFV970= X-Received: by 2002:a5d:9953:: with SMTP id v19mr70376880ios.118.1578341812201; Mon, 06 Jan 2020 12:16:52 -0800 (PST) MIME-Version: 1.0 References: <20191211204753.242298-1-pomonis@google.com> <20191211204753.242298-3-pomonis@google.com> <314f6d96-b75f-e159-d94d-1d30a5140e40@de.ibm.com> <73a7a1ce-7e68-7b15-70eb-7b6217af5e1a@de.ibm.com> In-Reply-To: <73a7a1ce-7e68-7b15-70eb-7b6217af5e1a@de.ibm.com> From: Jim Mattson Date: Mon, 6 Jan 2020 12:16:41 -0800 Message-ID: Subject: Re: [PATCH v2 02/13] KVM: x86: Protect kvm_hv_msr_[get|set]_crash_data() from Spectre-v1/L1TF attacks To: Christian Borntraeger Cc: Marios Pomonis , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "the arch/x86 maintainers" , kvm list , LKML , Nick Finco , Andrew Honig , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Dec 12, 2019 at 9:47 AM Christian Borntraeger wrote: > > > > On 12.12.19 18:44, Jim Mattson wrote: > > On Thu, Dec 12, 2019 at 9:31 AM Christian Borntraeger > > wrote: > >> > >> > >> > >> On 11.12.19 21:47, Marios Pomonis wrote: > >>> This fixes Spectre-v1/L1TF vulnerabilities in kvm_hv_msr_get_crash_data() > >>> and kvm_hv_msr_set_crash_data(). > >>> These functions contain index computations that use the > >>> (attacker-controlled) MSR number. > >>> > >>> Fixes: commit e7d9513b60e8 ("kvm/x86: added hyper-v crash msrs into kvm hyperv context") > >>> > >>> Signed-off-by: Nick Finco > >>> Signed-off-by: Marios Pomonis > >>> Reviewed-by: Andrew Honig > >>> Cc: stable@vger.kernel.org Reviewed-by: Jim Mattson