From: Jim Mattson <jmattson@google.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: kvm list <kvm@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
frankja@linux.ibm.com, thuth@redhat.com,
David Hildenbrand <david@redhat.com>,
drjones@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 2/4] lib/alloc_page: change some parameter types
Date: Mon, 6 Jul 2020 09:58:30 -0700 [thread overview]
Message-ID: <CALMp9eSzbPiN_nCH7pVGKADkEFyXoo7pfVFj06zms6TrGahcXw@mail.gmail.com> (raw)
In-Reply-To: <20200706164324.81123-3-imbrenda@linux.ibm.com>
On Mon, Jul 6, 2020 at 9:43 AM Claudio Imbrenda <imbrenda@linux.ibm.com> wrote:
>
> For size parameters, size_t is probably semantically more appropriate
> than unsigned long (although they map to the same value).
>
> For order, unsigned long is just too big. Also, get_order returns an
> unsigned int anyway.
>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Reviewed-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Jim Mattson <jmattson@google.com>
next prev parent reply other threads:[~2020-07-06 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 16:43 [kvm-unit-tests PATCH v2 0/4] More lib/alloc cleanup and a minor improvement Claudio Imbrenda
2020-07-06 16:43 ` [kvm-unit-tests PATCH v2 1/4] lib/vmalloc: fix pages count local variable to be size_t Claudio Imbrenda
2020-07-06 16:57 ` Jim Mattson
2020-07-06 16:43 ` [kvm-unit-tests PATCH v2 2/4] lib/alloc_page: change some parameter types Claudio Imbrenda
2020-07-06 16:58 ` Jim Mattson [this message]
2020-07-13 15:16 ` Thomas Huth
2020-07-06 16:43 ` [kvm-unit-tests PATCH v2 3/4] lib/alloc_page: move get_order and is_power_of_2 to a bitops.h Claudio Imbrenda
2020-07-06 16:43 ` [kvm-unit-tests PATCH v2 4/4] lib/vmalloc: allow vm_memalign with alignment > PAGE_SIZE Claudio Imbrenda
2020-07-06 16:48 ` [kvm-unit-tests PATCH v2 0/4] More lib/alloc cleanup and a minor improvement Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALMp9eSzbPiN_nCH7pVGKADkEFyXoo7pfVFj06zms6TrGahcXw@mail.gmail.com \
--to=jmattson@google.com \
--cc=david@redhat.com \
--cc=drjones@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).