From: David Matlack <dmatlack@google.com>
To: Venkatesh Srinivas <venkateshs@chromium.org>
Cc: kvm list <kvm@vger.kernel.org>, Jim Mattson <jmattson@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Benjamin Segall <bsegall@google.com>
Subject: Re: [PATCH] kvm: exit halt polling on need_resched() as well
Date: Fri, 30 Apr 2021 08:48:51 -0700 [thread overview]
Message-ID: <CALzav=ccDsmemKK2ffBKertVD2yMZUFsYEzvrwNO4BUhCRR2Qw@mail.gmail.com> (raw)
In-Reply-To: <20210429162233.116849-1-venkateshs@chromium.org>
On Thu, Apr 29, 2021 at 9:22 AM Venkatesh Srinivas
<venkateshs@chromium.org> wrote:
>
> From: Benjamin Segall <bsegall@google.com>
>
> single_task_running() is usually more general than need_resched()
> but CFS_BANDWIDTH throttling will use resched_task() when there
> is just one task to get the task to block. This was causing
> long-need_resched warnings and was likely allowing VMs to
> overrun their quota when halt polling.
>
> Signed-off-by: Ben Segall <bsegall@google.com>
> Signed-off-by: Venkatesh Srinivas <venkateshs@chromium.org>
Reviewed-by: David Matlack <dmatlack@google.com>
next prev parent reply other threads:[~2021-04-30 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 16:22 [PATCH] kvm: exit halt polling on need_resched() as well Venkatesh Srinivas
2021-04-29 16:39 ` Jim Mattson
2021-04-30 15:48 ` David Matlack [this message]
2021-04-30 17:43 ` Christian Borntraeger
2021-05-03 14:52 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALzav=ccDsmemKK2ffBKertVD2yMZUFsYEzvrwNO4BUhCRR2Qw@mail.gmail.com' \
--to=dmatlack@google.com \
--cc=bsegall@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=venkateshs@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).