From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CD9AC433B4 for ; Fri, 14 May 2021 21:33:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41F9C6143F for ; Fri, 14 May 2021 21:33:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232810AbhENVeX (ORCPT ); Fri, 14 May 2021 17:34:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230309AbhENVeW (ORCPT ); Fri, 14 May 2021 17:34:22 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9032EC06174A for ; Fri, 14 May 2021 14:33:10 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id x19so360211lfa.2 for ; Fri, 14 May 2021 14:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DgAKwIM9zch8xYFNPJtzcIGRCfmQye33dMFzHuDOjA8=; b=Ma9YTpFKv2FKqspm+/+nOYKxqwaYNdETxuDqxtZyA7ZnVB17mpdfo0ZQZ1QAMyP7bQ 2NoTwneXD9c+6ebVHoiqc6oePXLumrECPiQv+8vOzySGekm4yv4qyr/1A5OQgNBWIdOc GC91s86KWPnv8OcKzcAtpmA6LtDhi2dV4QHzddOOZPk3XWb4BwhtopFJddjuMGi0t41q Jt0ib/JJrlJ/eTK/VFDyP2XjLu/w++ESDctvgTGDtx+T4x5lrWiNYYxvwr1aWxUfB5gb DYjv0/UJb4ygI1UCeFfyaQGMxfketFlRyTTSsDTQ0S3dPSWKpNzYhoYbxy3ooFhgS+3n 2mNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DgAKwIM9zch8xYFNPJtzcIGRCfmQye33dMFzHuDOjA8=; b=MlrOcARiK93R+Ak+PpzTwEvOY2nuH1V4ANSe9ISeaYenQMM5M1CDlskhSUQsqimLCu pU6o1ZFOIoWRf4RG7bM/v8K3tphPhYSsstIqJ8e3ncbNAT2u2GsaoqA5IB/nPDaEQsfc fBujO0zSv91Iy4iLFhqZ+kekOVEaTvOxmSnawvy/hof3HSatlYkFnoiEr/TTZY4VKyJT /ojWinWmC6tcloIQ71iT5Xrbfhhqoi0bcGcdcPG52yOro92hkQ/K4S6UhZzg+Js/FQl2 imFUDRM9X+Uo2u+vZXD3mkpL1E8vK3QtjedUIZm2Y1ncdEuMQimLxPR5gA0Txj1xJ2kY Na6g== X-Gm-Message-State: AOAM530JEiFdo58XNYBAOIu1xxkRNgxqMrTcJaiJeLe8Ny7mFhf2gx33 qofg0q3NAhnlPtLA8zLq8b2ilhkHSsLgbwCtI90A3w== X-Google-Smtp-Source: ABdhPJwaWVyRTYrod/pJttPl6eOfPN7YN4oV2Ff7Rx7cDDSMWwaxFsTSlvdmGRhuFsgKwiPdwp1Wmw5xH9pEHIajUKQ= X-Received: by 2002:a05:6512:2243:: with SMTP id i3mr33685984lfu.46.1621027988910; Fri, 14 May 2021 14:33:08 -0700 (PDT) MIME-Version: 1.0 References: <1620871189-4763-1-git-send-email-wanpengli@tencent.com> In-Reply-To: <1620871189-4763-1-git-send-email-wanpengli@tencent.com> From: David Matlack Date: Fri, 14 May 2021 14:32:42 -0700 Message-ID: Subject: Re: [PATCH v2 2/4] KVM: X86: Bail out of direct yield in case of under-comitted scenarios To: Wanpeng Li Cc: linux-kernel@vger.kernel.org, kvm list , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, May 12, 2021 at 7:01 PM Wanpeng Li wrote: > > From: Wanpeng Li > > In case of under-comitted scenarios, vCPU can get scheduling easily, > kvm_vcpu_yield_to adds extra overhead, we can observe a lot of race > between vcpu->ready is true and yield fails due to p->state is > TASK_RUNNING. Let's bail out in such scenarios by checking the length > of current cpu runqueue, it can be treated as a hint of under-committed > instead of guarantee of accuracy. > > Signed-off-by: Wanpeng Li > --- > v1 -> v2: > * move the check after attempted counting > * update patch description > > arch/x86/kvm/x86.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 9b6bca6..dfb7c32 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -8360,6 +8360,9 @@ static void kvm_sched_yield(struct kvm_vcpu *vcpu, unsigned long dest_id) > > vcpu->stat.directed_yield_attempted++; > > + if (single_task_running()) > + goto no_yield; Since this is a heuristic, do you have any experimental or real world results that show the benefit? > + > rcu_read_lock(); > map = rcu_dereference(vcpu->kvm->arch.apic_map); > > -- > 2.7.4 >