From: Wanpeng Li <kernellwp@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kvm <kvm@vger.kernel.org>,
"Yunhong Jiang" <yunhong.jiang@intel.com>,
"Wanpeng Li" <wanpeng.li@hotmail.com>
Subject: Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers
Date: Wed, 26 Oct 2016 19:26:18 +0800 [thread overview]
Message-ID: <CANRm+Cw3SZc-Y8C6sc2_O2V_WbgKYXEjUChwVcAVR8FnGYsknQ@mail.gmail.com> (raw)
In-Reply-To: <13aa20e8-2931-8817-1d07-7bda8f28fb19@redhat.com>
2016-10-26 19:15 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>
>
> On 26/10/2016 12:23, Wanpeng Li wrote:
>>> >
>>> > if (apic_lvtt_oneshot(apic) &&
>>> > - ktime_after(apic->lapic_timer.target_expiration,
>>> > - apic->lapic_timer.timer.base->get_time())) {
>>> > + !ktime_after(apic->lapic_timer.target_expiration,
>>> > + apic->lapic_timer.timer.base->get_time())) {
>>> > apic_timer_expired(apic);
>>> > return;
>>> > }
>>> >
>>> > Paolo, can you squash that?
>> It seems that squash is impossible since the dependency of current
>> kvm/queue(KVM: x86: use ktime_get instead of seeking the
>> hrtimer_clock_base), I will send out a separate patch to fix this.
>
> It is squashed in:
>
> + if (apic_lvtt_oneshot(apic) &&
> + ktime_after(apic->lapic_timer.timer.base->get_time(),
> + apic->lapic_timer.target_expiration)) {
> + apic_timer_expired(apic);
> + return;
> + }
>
> Notice that the order of the arguments is inverted (alternatively I
> could have used ktime_before).
Indeed.
Regards,
Wanpeng Li
next prev parent reply other threads:[~2016-10-26 11:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 10:23 [PATCH v3 0/5] KVM: LAPIC: Add APIC Timer periodic/oneshot mode VMX preemption timer support Wanpeng Li
2016-10-24 10:23 ` [PATCH v3 1/5] KVM: LAPIC: extract start_sw_period() to handle periodic/oneshot mode Wanpeng Li
2016-10-24 10:23 ` [PATCH v3 2/5] KVM: LAPIC: guarantee the timer is in tsc-deadline mode Wanpeng Li
2016-10-24 10:23 ` [PATCH v3 3/5] KVM: LAPIC: introduce kvm_get_lapic_target_expiration_tsc() Wanpeng Li
2016-10-24 10:23 ` [PATCH v3 4/5] KVM: LAPIC: rename start/cancel_hv_tscdeadline to start/cancel_hv_timer Wanpeng Li
2016-10-24 10:23 ` [PATCH v3 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX preemption timer support Wanpeng Li
2016-10-24 14:50 ` Radim Krčmář
2016-10-24 23:33 ` Wanpeng Li
2016-10-24 15:03 ` [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Radim Krčmář
2016-10-24 15:09 ` Paolo Bonzini
2016-10-24 15:27 ` Radim Krčmář
2016-10-24 23:39 ` Wanpeng Li
2016-10-25 11:43 ` Radim Krčmář
2016-10-25 11:55 ` Paolo Bonzini
2016-10-26 6:02 ` Wanpeng Li
2016-10-26 6:08 ` Wanpeng Li
2016-10-26 14:01 ` Radim Krčmář
2016-10-27 2:33 ` Wanpeng Li
2016-10-26 13:32 ` Radim Krčmář
2016-10-27 2:11 ` Wanpeng Li
2016-10-26 10:23 ` Wanpeng Li
2016-10-26 11:15 ` Paolo Bonzini
2016-10-26 11:26 ` Wanpeng Li [this message]
[not found] ` <SG2PR02MB1550E0FF04F2614BE0E262BC80A80@SG2PR02MB1550.apcprd02.prod.outlook.com>
2016-10-25 13:03 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANRm+Cw3SZc-Y8C6sc2_O2V_WbgKYXEjUChwVcAVR8FnGYsknQ@mail.gmail.com \
--to=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=wanpeng.li@hotmail.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).