From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2126EC31E5B for ; Tue, 18 Jun 2019 00:43:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF81720663 for ; Tue, 18 Jun 2019 00:43:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qjQIrGkQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726286AbfFRAnZ (ORCPT ); Mon, 17 Jun 2019 20:43:25 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:42342 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbfFRAnZ (ORCPT ); Mon, 17 Jun 2019 20:43:25 -0400 Received: by mail-ot1-f67.google.com with SMTP id l15so2138119otn.9; Mon, 17 Jun 2019 17:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=k2lbSxS7dzxwxb6i0Oq5RHt/qUDihaL0G0ctkpHTiJo=; b=qjQIrGkQ5XeuD8j9pDA0Qpe4HhzVjPlsGzACmzSceha6vC5OX5Kql7+UP7LiIlWHYj acDmor3TqCWB6woaO12rj90cteAj0iWOiIdLkIQTSPNU8dvie8Fv1E/XTkLLu33fGmud fOmmk0eExMhiBZFbPKu2VezF+vxVgwa+ZQg/0lV9BSMpZZJ3hk4QU+Ag92nlvBm2IN/4 Npi4k2gwdgLHq5jzQtAPO7AuJ9sC01TAjX9HE5vW8h0jsEPuHN/FPY2p3CR3aoeAm8cg F8JFjUyKGFHqYl38TzGsG/NQbcQ3o/IEwDQHqbxchAKbcEpEDKGo0+OjXj7fMGSjY3Mt +9tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=k2lbSxS7dzxwxb6i0Oq5RHt/qUDihaL0G0ctkpHTiJo=; b=Ms7JEPv06MAQ+GIER49ZroFukCjdFs3Pm4zXGwEJB9yiUKtux1noUh7ql3wfjSRhKe lj4CAwrrvDaqcDhagAV2PSg2JTm75ukSvhdtwLbvh6nnpBuk5b+PqLOg8x7vqGm0+/fa pVT5BqGhWtqpfwrgUzTjD8tC9VEAkq3uwSowd2y+dJScI2b40GR4B2t2XZLZWtFfEbzY kgV1czym4/IcqcEQgU5CPqvMyeH6anNn0cRWclChy1nplocxPRegXmTgOsYavRkGujZY Vv/pgfA3TvV3nLo+/aA98OUEm5zkzIhTKyaIevTyPXku/I1oZLJPYAaMft7AHlOB33Jc hniA== X-Gm-Message-State: APjAAAUoExTbNCg/5rKZVqxMksooSXbRTEqvEU47k9sE0PQI48zSF7nh zP6Uo/mLon6w8lr+5kTqnvabHixJTXqfXDnNEG4= X-Google-Smtp-Source: APXvYqz4ITqIRl3oYOhvThVAimSH0fc5M/eLGiTGrmNUEYhqJJXeEUPvocWkLLkya2ZPWQgr46dZhjjTUATXxbsVOfA= X-Received: by 2002:a9d:6959:: with SMTP id p25mr38008868oto.118.1560818604278; Mon, 17 Jun 2019 17:43:24 -0700 (PDT) MIME-Version: 1.0 References: <1560770687-23227-1-git-send-email-wanpengli@tencent.com> <1560770687-23227-6-git-send-email-wanpengli@tencent.com> <20190617213201.GA26346@flask> In-Reply-To: <20190617213201.GA26346@flask> From: Wanpeng Li Date: Tue, 18 Jun 2019 08:44:00 +0800 Message-ID: Subject: Re: [PATCH v4 5/5] KVM: LAPIC: add advance timer support to pi_inject_timer To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Cc: LKML , kvm , Paolo Bonzini , Marcelo Tosatti Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 18 Jun 2019 at 05:32, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > > 2019-06-17 19:24+0800, Wanpeng Li: > > From: Wanpeng Li > > > > Wait before calling posted-interrupt deliver function directly to add > > advance timer support to pi_inject_timer. > > > > Cc: Paolo Bonzini > > Cc: Radim Kr=C4=8Dm=C3=A1=C5=99 > > Cc: Marcelo Tosatti > > Signed-off-by: Wanpeng Li > > --- > > Please merge this patch with [2/5], so bisection doesn't break. Agreed. > > > arch/x86/kvm/lapic.c | 6 ++++-- > > arch/x86/kvm/lapic.h | 2 +- > > arch/x86/kvm/svm.c | 2 +- > > arch/x86/kvm/vmx/vmx.c | 2 +- > > 4 files changed, 7 insertions(+), 5 deletions(-) > > > > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c > > index 1a31389..1a31ba5 100644 > > --- a/arch/x86/kvm/lapic.c > > +++ b/arch/x86/kvm/lapic.c > > @@ -1462,6 +1462,8 @@ static void apic_timer_expired(struct kvm_lapic *= apic, bool can_pi_inject) > > return; > > > > if (can_pi_inject && posted_interrupt_inject_timer(apic->vcpu)) { > > + if (apic->lapic_timer.timer_advance_ns) > > + kvm_wait_lapic_expire(vcpu, true); > > From where does kvm_wait_lapic_expire() take > apic->lapic_timer.expired_tscdeadline? Sorry, I failed to understand this. https://git.kernel.org/pub/scm/virt/kvm/kvm.git/tree/arch/x86/kvm/lapic.c?h= =3Dqueue#n1541 We can get apic->lapic_timer.expired_tscdeadline in kvm_wait_lapic_expire() directly. Regards, Wanpeng Li