From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,PDS_TONAME_EQ_TOLOCAL_SHORT, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3119BC2D0C0 for ; Fri, 6 Dec 2019 03:10:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0517824659 for ; Fri, 6 Dec 2019 03:10:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GzHq8NpM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726271AbfLFDKk (ORCPT ); Thu, 5 Dec 2019 22:10:40 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:37288 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726097AbfLFDKk (ORCPT ); Thu, 5 Dec 2019 22:10:40 -0500 Received: by mail-oi1-f193.google.com with SMTP id x195so4876351oix.4; Thu, 05 Dec 2019 19:10:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2I9BWtfZOL4P/xg0P2ezGpWnMFLsd6sr0G++N9fRRxI=; b=GzHq8NpMIji/ZUYeXBB7aIxQR4Mc7udXrEbwBXLusafbAPZ3D7zzDr8w636bC0comQ RsHWoQ7rbyjLs46a7OCdFBUkAilc5pjenmzQF7dz7tYfSVOrc5b1pE+WBJBAzm3/i1qB uyPxPX3gcp6YsA+UfpCkyQ484LFV6YilI2+0HyeiWflRXskQMasNj+zn3FS/fqyWGlKb U4CpR6rXINBbqzozKiVeZfDdFduUdsS31+gXvlLJxoSp4KrsE989XjiV5Myl9x/5RmFP aKB9Bf87jfq2dimHpii5yAgDCz7kyF5AZ9+kLxv1R56PEKwmL/q+s9E0hzjnqmpONUec aUVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2I9BWtfZOL4P/xg0P2ezGpWnMFLsd6sr0G++N9fRRxI=; b=da+7KFq0eujRVdaT3gJyEuG1qiMYcv81CR9K6Qaq0Z3za0jfSMHOWksHlcxfSvDSTw RQSKQ8j8tkXZ2iT/pTJL1iKLzcDRxz09MBUbMRgJceg4aax9HfXwe064HceOnkwFIclm CkcTiAK4ATqsJpQ6hAqlRsEUDPq8p2ckVvOcb60xUjIA1VAi/0TVl60mnnWBfAUKA3lQ 4jQ8jE7gpclW54QCtTChYq9TvJrPktkLEBl8409pJAXOyXhWp5uXZDeBw9v3UcSPmQHA 4NxzG4IspA5fxqCkUNGuYEsFzFErKGKCClU00en1eFdqJOSwe0/jVAbcesJus8mUdI3z 9DtQ== X-Gm-Message-State: APjAAAURpRrtcKMoXFZ7WjPgli2Zyw08CXrMwmzpVVbyVcN33DtXRKrk OSuVIo5hBCJ2G4JnvnmMyLyBzzbsUm33RL6xhCI= X-Google-Smtp-Source: APXvYqx9zG1sYufPVsO7WozDLyQ35GubaJfMfrnr/QH9wAwzMD5FWPGGVddq6XEwYkOOehhG+VDTOSzclCjamAzTUTo= X-Received: by 2002:aca:758c:: with SMTP id q134mr10736499oic.33.1575601839698; Thu, 05 Dec 2019 19:10:39 -0800 (PST) MIME-Version: 1.0 References: <833788ce05014084af1e6160fb81e5cd@huawei.com> In-Reply-To: <833788ce05014084af1e6160fb81e5cd@huawei.com> From: Wanpeng Li Date: Fri, 6 Dec 2019 11:10:32 +0800 Message-ID: Subject: Re: [PATCH] KVM: vmx: remove unreachable statement in vmx_get_msr_feature() To: linmiaohe Cc: Liran Alon , "pbonzini@redhat.com" , "rkrcmar@redhat.com" , "sean.j.christopherson@intel.com" , "vkuznets@redhat.com" , "wanpengli@tencent.com" , "jmattson@google.com" , "joro@8bytes.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "hpa@zytor.com" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, 6 Dec 2019 at 09:54, linmiaohe wrote: > > > > >I personally just prefer to remove the =E2=80=9Cdefault=E2=80=9D case an= d change this =E2=80=9Creturn 0;=E2=80=9D to =E2=80=9Creturn 1;=E2=80=9D. > >But it=E2=80=99s a matter of taste of course. > > > Yes. As what " Turnip greens, all have love " said. ^_^ Actually it is a great appreciated to introduce something more useful instead of tons of cleanups, I saw guys did one cleanup and can incur several bugs before. Wanpeng