From: Tianyu Lan <lantianyu1986@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Sasha Levin <sashal@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"the arch/x86 maintainers" <x86@kernel.org>,
Radim Krcmar <rkrcmar@redhat.com>,
michael.h.kelley@microsoft.com,
Vitaly Kuznetsov <vkuznets@redhat.com>,
linux-hyperv@vger.kernel.org,
"linux-kernel@vger kernel org" <linux-kernel@vger.kernel.org>,
kvm <kvm@vger.kernel.org>, Tianyu Lan <Tianyu.Lan@microsoft.com>
Subject: Re: [PATCH V2 3/3] KVM/Hyper-V/VMX: Add direct tlb flush support
Date: Thu, 15 Aug 2019 20:24:14 +0800 [thread overview]
Message-ID: <CAOLK0pxX=fY=1Kux5_K-qZBU3CNoL1dmnghtL-_Yrh0UgAbbQA@mail.gmail.com> (raw)
In-Reply-To: <1a1410a7-e2dc-904e-a271-3e2017d42bae@redhat.com>
Hi Paolo:
Thanks for your review.
On Wed, Aug 14, 2019 at 9:33 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 14/08/19 09:34, lantianyu1986@gmail.com wrote:
> > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> > index c5da875f19e3..479ad76661e6 100644
> > --- a/include/linux/kvm_host.h
> > +++ b/include/linux/kvm_host.h
> > @@ -500,6 +500,7 @@ struct kvm {
> > struct srcu_struct srcu;
> > struct srcu_struct irq_srcu;
> > pid_t userspace_pid;
> > + struct hv_partition_assist_pg *hv_pa_pg;
> > };
> >
> > #define kvm_err(fmt, ...) \
>
> This does not exist on non-x86 architectures. Please move it to struct
> kvm_arch.
>
Nice catch. Will update in the next version. Thanks.
--
Best regards
Tianyu Lan
prev parent reply other threads:[~2019-08-15 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 7:34 [PATCH V2 0/3] KVM/Hyper-V: Add Hyper-V direct tlb flush support lantianyu1986
2019-08-14 7:34 ` [PATCH V2 1/3] x86/Hyper-V: Fix definition of struct hv_vp_assist_page lantianyu1986
2019-08-14 13:26 ` Paolo Bonzini
2019-08-14 13:28 ` Paolo Bonzini
2019-08-14 7:34 ` [PATCH V2 2/3] KVM/Hyper-V: Add new KVM cap KVM_CAP_HYPERV_DIRECT_TLBFLUSH lantianyu1986
2019-08-14 7:34 ` [PATCH V2 3/3] KVM/Hyper-V/VMX: Add direct tlb flush support lantianyu1986
2019-08-14 13:33 ` Paolo Bonzini
2019-08-15 12:24 ` Tianyu Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLK0pxX=fY=1Kux5_K-qZBU3CNoL1dmnghtL-_Yrh0UgAbbQA@mail.gmail.com' \
--to=lantianyu1986@gmail.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=bp@alien8.de \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.h.kelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).