From: Oliver Upton <oupton@google.com>
To: Ricardo Koller <ricarkol@google.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
drjones@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
maz@kernel.org
Subject: Re: [kvm-unit-tests PATCH v2] arm64: debug: mark test_[bp,wp,ss] as noinline
Date: Wed, 12 Jan 2022 09:38:57 -0600 [thread overview]
Message-ID: <CAOQ_QshBSJTR2aH4nDNnXD9ZsmU0uE+7Bh_SUHOBZEpNWGnfUA@mail.gmail.com> (raw)
In-Reply-To: <20220112152155.2600645-1-ricarkol@google.com>
On Wed, Jan 12, 2022 at 9:22 AM Ricardo Koller <ricarkol@google.com> wrote:
>
> Clang inlines some functions (like test_ss) which define global labels
> in inline assembly (e.g., ss_start). This results in:
>
> arm/debug.c:382:15: error: invalid symbol redefinition
> asm volatile("ss_start:\n"
> ^
> <inline asm>:1:2: note: instantiated into assembly here
> ss_start:
> ^
> 1 error generated.
>
> Fix these functions by marking them as "noinline".
>
> Cc: Andrew Jones <drjones@redhat.com>
> Signed-off-by: Ricardo Koller <ricarkol@google.com>
Reviewed-by: Oliver Upton <oupton@google.com>
next prev parent reply other threads:[~2022-01-12 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 15:21 [kvm-unit-tests PATCH v2] arm64: debug: mark test_[bp,wp,ss] as noinline Ricardo Koller
2022-01-12 15:38 ` Oliver Upton [this message]
2022-01-12 15:49 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ_QshBSJTR2aH4nDNnXD9ZsmU0uE+7Bh_SUHOBZEpNWGnfUA@mail.gmail.com \
--to=oupton@google.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=ricarkol@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).