From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9DF4C4BA0B for ; Wed, 26 Feb 2020 08:23:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79A24222C2 for ; Wed, 26 Feb 2020 08:23:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rzt7mcbQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727377AbgBZIXH (ORCPT ); Wed, 26 Feb 2020 03:23:07 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:33792 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727247AbgBZIXH (ORCPT ); Wed, 26 Feb 2020 03:23:07 -0500 Received: by mail-lj1-f196.google.com with SMTP id x7so2043449ljc.1 for ; Wed, 26 Feb 2020 00:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nRyrJ0JXVtXKugLelSGVM5EpQ374/a6s5wZoNbpi0oU=; b=rzt7mcbQaAXnc/YOikYn/LG99+3Xutx/j3MoDupiNol9Jz9vqYOUVlzSbnntFveg4C hLNFFn+yvSZDoOZNth2vzatr2HWOn0Gh4tkaH86pKH0x/QAhCxKHihqrcEDQ4vBAob8n H405O8iCajDEZdqDxOTRRpyc/GTFBhxLNzJPDoy9r1zNVldnWcwKC2nEyr23DOmV0AYO 7gzGQBE+wNqEJyoXNUopY9euEFxaeAEIoDKc/CeAAg5LyPYjcdXRMgu07GUNh3kRDc7j RJoOrJT1fbFmVeo2L2qNiCPANz+qhtbutvSlJ7RxWO1/f10gHAYNJNR2tt/ly3FbZT+G NkSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nRyrJ0JXVtXKugLelSGVM5EpQ374/a6s5wZoNbpi0oU=; b=mrzJIVsLL6koapjLDeGH89hDi+7/0EPwbuC5AuhfuCAA6L4Tcfjjj7a+7aMgZQcbXk rMZ/EJ/bmGxs4qdlsKr874gWXBDXCSdU6T0dDcgWG3pGd93t/fHjJZ4wi6F5t3YPVkwe yIspFA/rvinekt1PMk0LnTSKLJKAOWXmpXtA5N2rkuMW//VgHExcYmRfnL5wpSb4rYIJ qleYUqp+tcfdl8hX6Is14bZAIUWVqkpNbM30LzDm1uR1/2pRbesHEUN7k8ES8eHGsPg5 qSlT18euvfX07uDDP/n3tXWilRERMnaK177bxD6c1ks+8KLqtIsayp98lC1hTAKG+w8J kauQ== X-Gm-Message-State: APjAAAVU/eZtBpYeOdgDeJmQF9EXLEFrkunyHN2dajLae8J4/ybJky63 +iqQajldTtZsrmuDlxZdNM2Knk1ABTtAM2/FVBN3uQ== X-Google-Smtp-Source: APXvYqyZG7ECRsLYkQgo9u6c7Sg1a9/CJRhVU1QDO7sqSMGVeDZlNXpwqLna0Tno/NNFCaHOj1vAGayVZokey3jkJpk= X-Received: by 2002:a2e:884c:: with SMTP id z12mr2221324ljj.55.1582705384953; Wed, 26 Feb 2020 00:23:04 -0800 (PST) MIME-Version: 1.0 References: <20200226074427.169684-1-morbo@google.com> <20200226074427.169684-8-morbo@google.com> In-Reply-To: From: Oliver Upton Date: Wed, 26 Feb 2020 00:22:53 -0800 Message-ID: Subject: Re: [kvm-unit-tests PATCH 7/7] x86: VMX: the "noclone" attribute is gcc-specific To: Bill Wendling Cc: kvm list , Paolo Bonzini Content-Type: text/plain; charset="UTF-8" Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Blech... On Wed, Feb 26, 2020 at 12:21 AM Oliver Upton wrote: > > On Tue, Feb 25, 2020 at 11:45 PM wrote: > > > > From: Bill Wendling > > > > Don't use the "noclone" attribute for clang as it's not supported. > > > > Signed-off-by: Bill Wendling > Signed-off-by: Oliver Upton s/Signed-off-by/Reviewed-by/ > > --- > > x86/vmx_tests.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c > > index ad8c002..ec88016 100644 > > --- a/x86/vmx_tests.c > > +++ b/x86/vmx_tests.c > > @@ -4976,7 +4976,10 @@ extern unsigned char test_mtf1; > > extern unsigned char test_mtf2; > > extern unsigned char test_mtf3; > > > > -__attribute__((noclone)) static void test_mtf_guest(void) > > +#ifndef __clang__ > > +__attribute__((noclone)) > > +#endif > > +static void test_mtf_guest(void) > > { > > asm ("vmcall;\n\t" > > "out %al, $0x80;\n\t" > > -- > > 2.25.0.265.gbab2e86ba0-goog > >