From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24CFEC433E1 for ; Tue, 30 Jun 2020 03:45:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFDBB206CB for ; Tue, 30 Jun 2020 03:45:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com header.b="s4tFRNcw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728414AbgF3DpN (ORCPT ); Mon, 29 Jun 2020 23:45:13 -0400 Received: from mga09.intel.com ([134.134.136.24]:28695 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726686AbgF3DpM (ORCPT ); Mon, 29 Jun 2020 23:45:12 -0400 IronPort-SDR: LzbFG7JLHBwUfiNfi5cAdXEfJYmNkLag11HQBUz8to0TIwPEmVep8KDJQ23s1U/+wk4fDnsG9e KYpsTRdgBk5Q== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="147689275" X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208";a="147689275" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 20:45:12 -0700 IronPort-SDR: SDPcqvEJjGT8KJ27k18hc1otKI8qTkldfWQj+9pyuq9segpUdfUL45MfeL0ePAuc1QZ1yLWOUH YbRwtN4fm1QQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208";a="265006040" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 29 Jun 2020 20:45:12 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 29 Jun 2020 20:45:11 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 29 Jun 2020 20:45:11 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 29 Jun 2020 20:45:11 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 29 Jun 2020 20:45:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F8EKsq9rmdW8Wh5srxi+I9Kv9xfoayQi3X1iot95KYq+aaVvag0YSRezYfiEbXL4fIfCYpdxV9UydGC92wLWHgZoIRl3jbCUsn1B3L1opx0bUezsJZQHby+nHf36SKJyFf4eoyN8OHu/GWWaT4W0l7h79/lyQ9OD740WAhfDs4GpSqBcm4dR/29ejAplf74F5280xbJZE7TGzbvueUJixaz/ReI7YLv1z8VbfOgtEezVZ6Pj+ShdloplysBCh0/P3G/e7P7YeXYx6PCmcbFNFkpWjo8sDkNnDuAvApu+LbAvGdrU9SZ9BekH3LujbLHCczE7BQKcLTe+PwF8cxBYcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xo8LFCLPtF8KBAVRZx44CTeM7yA2A81HGCrnVpdM1oE=; b=cIG8YDKDgusyEVBhiKCQfEWDNV3pxPKcHcd+OhJeSAzGNpTAWtbgD98hEdIs5OmJJ74znspYozJNyQ6HYs9Tka421ltYY6QBw8r6SwxihAXERYJRLbIgFyx6aJRs+wwgWvBcGCZghUkg42pfy+yTt/jkfAxC07gzXp0E4WJMGtwuvQ98T01rBQQ0A3AReKf6x4LrsTMyR9NettwWU6x898RP6NjqoUSrLFyMcZA8Bh7NRFlT036OK0ZeTFGxtaMxkspjBrRT2iKidQpvdcGGf2aNaScIHOi58HtHXZgchpYgiqLwF+yQ9ixhLCpI8ksOXCEjzNw7tHW5GQRymYd0SA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xo8LFCLPtF8KBAVRZx44CTeM7yA2A81HGCrnVpdM1oE=; b=s4tFRNcwWmsMyNkWR8RHXr2UIpaQka5LzHUaYiGOeKaTPyIUTVM4LjyyBShkZWFWR1P19pNY2ht7AERQU+TRi9RX8aUsZvWfDpnbMPGZ7WavTSt2PlwHj4vlHDWk9Lrj4dyd/Ww0Wr7Rz+cL+PfNTEkYlLZaNptv4ZpB4Q5UlPw= Received: from DM5PR11MB1435.namprd11.prod.outlook.com (2603:10b6:4:7::18) by DM6PR11MB4724.namprd11.prod.outlook.com (2603:10b6:5:2ad::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.23; Tue, 30 Jun 2020 03:45:09 +0000 Received: from DM5PR11MB1435.namprd11.prod.outlook.com ([fe80::2c3d:98d9:4e81:c86c]) by DM5PR11MB1435.namprd11.prod.outlook.com ([fe80::2c3d:98d9:4e81:c86c%6]) with mapi id 15.20.3131.027; Tue, 30 Jun 2020 03:45:09 +0000 From: "Liu, Yi L" To: "Tian, Kevin" , Stefan Hajnoczi CC: "alex.williamson@redhat.com" , "eric.auger@redhat.com" , "baolu.lu@linux.intel.com" , "joro@8bytes.org" , "jacob.jun.pan@linux.intel.com" , "Raj, Ashok" , "Tian, Jun J" , "Sun, Yi Y" , "jean-philippe@linaro.org" , "peterx@redhat.com" , "Wu, Hao" , "iommu@lists.linux-foundation.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3 02/14] iommu: Report domain nesting info Thread-Topic: [PATCH v3 02/14] iommu: Report domain nesting info Thread-Index: AQHWSgRQVmc9Qp+Xi0mQEumzIJrE0qjvWjsAgAAviUCAAObAgIAAF5Ww Date: Tue, 30 Jun 2020 03:45:09 +0000 Message-ID: References: <1592988927-48009-1-git-send-email-yi.l.liu@intel.com> <1592988927-48009-3-git-send-email-yi.l.liu@intel.com> <20200629092448.GB31392@stefanha-x1.localdomain> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 76f2a4b1-0a33-4558-bdef-08d81ca7fc64 x-ms-traffictypediagnostic: DM6PR11MB4724: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0450A714CB x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bMvEyngG+3yII4GcvSmqyWgdhrc8K1wJCw3ddl/KIYVZMv8ruEeR9VpJUKfiBY97Yj7PMHf4PP76NPWgQc4nbEru5r1HBQdQURs0uupDbRcsr3s7T+QWSXjM66vZkfqJFPo2J69oFlJEAf+k4INp6NgaxsmgV9DZVu9XUwBt0WPgqSGAg9WURsxGgdCPRY7XpX4xNSpcqVB64KUiBeTUN7RKs4zYqeuRuEdF9UZrEup6indqf1pnUvOS0sOKr+czAnuyJdh5FdjwXvp2kIdTqRDafQ0uJP00d23yEc6hpYLcytkCy/a9EH8faufNX8B1zqjvQNKn3YYbMqxlhrtsdw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1435.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(136003)(376002)(346002)(366004)(39860400002)(66556008)(64756008)(66446008)(66476007)(83380400001)(76116006)(66946007)(86362001)(5660300002)(55016002)(4326008)(9686003)(33656002)(52536014)(316002)(110136005)(54906003)(8676002)(186003)(6506007)(26005)(2906002)(7696005)(8936002)(71200400001)(478600001)(7416002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: hosVh63789Bizc4borH0rYuvrtES/Q3vtv3BR5kkWa/zRJR1cAYaZVo3eRvSK0BH9jDDlegy0OCfQg3esuqzoitONgMhnXABkspCppVQMCajmfDmMrxnjH0Hpa2+Ke8FdIEylBFmUby8TF6cUBlUC/ketmT5hlUxd7AqmikFQq74/sLEmNoepZjouTZaLqNlSqrAMWGqBW2NN36Rf5GJj8G6h2C/hvXDc7JYvIMx0bSv0yuUGcx8mhihuEV2uW+QYUWIUp5bbdhOXVRIdM9K90dhaG5RbyVrw2U+6lCuKY50uStXNSRSFX1hHQ2AnFtpd7QVKhsaZquDJfFMI62LBp8B8KKc+pdDsysSr0xN52K01Sb/r/q3Y7OIudYB2u0OFHEBjv9lCWaWPuIUqGSZZiPnydkwWgWmgA8d9ZRu7E4ypsTcZz6l2HZyF/O57fdwa9rEMrhoeFqRfYZaLY1Y9+IvLIxc2KNNcR8KaAbElR8sFaxh/Iiy+KsvtitxQG+P Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1435.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76f2a4b1-0a33-4558-bdef-08d81ca7fc64 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2020 03:45:09.0582 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y6YHQqzUdE6TKQ0v9xi5nP0igDAxNgOj3DMsMhg07a9zolLTZmlr8DMXISOPx91+wOtVl1KmEmujUu86FmiGFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4724 X-OriginatorOrg: intel.com Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org > From: Tian, Kevin > Sent: Tuesday, June 30, 2020 10:01 AM > > > From: Liu, Yi L > > Sent: Monday, June 29, 2020 8:23 PM > > > > Hi Stefan, > > > > > From: Stefan Hajnoczi > > > Sent: Monday, June 29, 2020 5:25 PM > > > > > > On Wed, Jun 24, 2020 at 01:55:15AM -0700, Liu Yi L wrote: > > > > +/* > > > > + * struct iommu_nesting_info - Information for nesting-capable IOM= MU. > > > > + * user space should check it before using > > > > + * nesting capability. > > > > + * > > > > + * @size: size of the whole structure > > > > + * @format: PASID table entry format, the same definition with > > > > + * @format of struct iommu_gpasid_bind_data. > > > > + * @features: supported nesting features. > > > > + * @flags: currently reserved for future extension. > > > > + * @data: vendor specific cap info. > > > > + * > > > > + * +---------------+----------------------------------------------= ------+ > > > > + * | feature | Notes = | > > > > + * > > > > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > =3D=3D=3D=3D > > > =3D+ > > > > + * | SYSWIDE_PASID | Kernel manages PASID in system wide, PASIDs > > used | > > > > + * | | in the system should be allocated by host ke= rnel | > > > > + * +---------------+----------------------------------------------= ------+ > > > > + * | BIND_PGTBL | bind page tables to host PASID, the PASID co= uld | > > > > + * | | either be a host PASID passed in bind reques= t or | > > > > + * | | default PASIDs (e.g. default PASID of aux-do= main) | > > > > + * +---------------+----------------------------------------------= ------+ > > > > + * | CACHE_INVLD | mandatory feature for nesting capable IOMMU > > | > > > > + * +---------------+----------------------------------------------= ------+ > > > > > > This feature description is vague about what CACHE_INVLD does and how > > to > > > use it. If I understand correctly, the presence of this feature means > > > that VFIO_IOMMU_NESTING_OP_CACHE_INVLD must be used? > > > > > > The same kind of clarification could be done for SYSWIDE_PASID and > > > BIND_PGTBL too. > > > > For SYSWIDE_PASID and BIND_PGTBL, yes, presence of the feature bit > > means must use. So the two are requirements to user space if it wants > > to setup nesting. While for CACHE_INVLD, it's kind of availability > > here. How about removing CACHE_INVLD as presence of BIND_PGTBL should > > indicates support of CACHE_INVLD? > > >=20 > So far this assumption is correct but it may not be true when thinking fo= rward. > For example, a vendor might find a way to allow the owner of 1st-level pa= ge > table to directly invalidate cache w/o going through host IOMMU driver. F= rom > this angle I feel explicitly reporting this capability is more robust. I see. explicitly require 1st-level page table owner to do cache invalidati= on after modifying page table is fair to me. > Regarding to the description, what about below? >=20 > -- > SYSWIDE_PASID: PASIDs are managed in system-wide, instead of per device. > When a device is assigned to userspace or VM, proper uAPI (provided by > userspace driver framework, e.g. VFIO) must be used to allocate/free PASI= Ds > for the assigned device. >=20 > BIND_PGTBL: The owner of the first-level/stage-1 page table must explicit= ly > bind the page table to associated PASID (either the one specified in bind > request or the default PASID of the iommu domain), through VFIO_IOMMU > _NESTING_OP >=20 > CACHE_INVLD: The owner of the first-level/stage-1 page table must > explicitly invalidate the IOMMU cache through VFIO_IOMMU_NESTING_OP, > according to vendor-specific requirement when changing the page table. > -- thanks for the statements, will apply. Regards, Yi Liu > Thanks > Kevin >=20 >=20