From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4C4AC433E1 for ; Wed, 19 Aug 2020 13:00:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EEB22054F for ; Wed, 19 Aug 2020 13:00:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="abfE9VhO"; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="abfE9VhO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728550AbgHSNA2 (ORCPT ); Wed, 19 Aug 2020 09:00:28 -0400 Received: from mail-eopbgr150047.outbound.protection.outlook.com ([40.107.15.47]:14422 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728551AbgHSM7d (ORCPT ); Wed, 19 Aug 2020 08:59:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2SMMQbSx+ksBgWTfTO9apqIrlmn8I5S/P+QjfNFrp94=; b=abfE9VhOVlMqMHw5f6eqQlTppx/n4G7kanK3peiB5YHFyC3fxNEFjfDXxjlSTMXaGdHg7mdy9EfE2gXV7o1frhJPmW//MSG3QmobkrE3H7PtctUVaYU2Adj3DrvNCc5d5M5bpBXIztTyJvlNeoTzhZM4ZDa9VgjVtmzENY0WqCQ= Received: from MRXP264CA0023.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:15::35) by AM6PR08MB3222.eurprd08.prod.outlook.com (2603:10a6:209:43::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.20; Wed, 19 Aug 2020 12:59:09 +0000 Received: from VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:15:cafe::80) by MRXP264CA0023.outlook.office365.com (2603:10a6:500:15::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.25 via Frontend Transport; Wed, 19 Aug 2020 12:59:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; vger.kernel.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;vger.kernel.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT036.mail.protection.outlook.com (10.152.19.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24 via Frontend Transport; Wed, 19 Aug 2020 12:59:08 +0000 Received: ("Tessian outbound e8cdb8c6f386:v64"); Wed, 19 Aug 2020 12:59:08 +0000 X-CR-MTA-TID: 64aa7808 Received: from c159c1ad27bb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 90658EE3-E10E-4616-B0EE-2D28435DFC50.1; Wed, 19 Aug 2020 12:59:03 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c159c1ad27bb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 19 Aug 2020 12:59:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hvpcjT926hwhgaLLuj9QeQ3tlIDnZkWPIdd5XvKQzN/ARD4pWN9++Dvvl3JBNEkgbqKbY4QlKAA4zAu1S1XKXvdngoh+k+kSeucF82dAzpZ0612X+c+Oq78ta2fKhq6TmoLkrKzno9plThKBEXcfAOUGQncTDBqivmBdaxUuUgoxl2j1tYUiWX27JPelXwixX1xZ7OfmG4v0z2bCDvd5OSd1oIIsdhzrVc87zr4o6RBSEQAVjkUi6pZs+zzZq0fZDhSU6Rd8LdYF04yYl0Sh0Hv41IKW5wLEbpODwDdU/y2oeOIga6cE4QU+wpPsft/71EqU5qVGKbDXp+rNkJwiWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2SMMQbSx+ksBgWTfTO9apqIrlmn8I5S/P+QjfNFrp94=; b=EXdLsX7y6u8FRQ3wtzRk5VgwsSLlAzjhY4eD0ElEe2gLEjrK94V5ynDIX6wDlQXdMD/gtbzI7cEKnnnnwsPeldh4HH+2fZD5tNg2ujzxDV5hwVXiYD5gumio1I1G270Ol2izlJbNwbwVpqb7iVZ4JATZZ0pwvTMfN+astPDeLEq3HQoPo8dNXapqwUhyFEFIc0WFV1wwI/rtmVkOl29SbZ4cxAD423paA0BajBQ9pj8p1okekVDb8Fz7H6otfHukulWxmF6l4/E1oE2HUbpdodJt4teK6kCpbaXimdxUCY529RAsjKsJe76Rla5VCwBywz99IvZwWUOTwH5G+OoOYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2SMMQbSx+ksBgWTfTO9apqIrlmn8I5S/P+QjfNFrp94=; b=abfE9VhOVlMqMHw5f6eqQlTppx/n4G7kanK3peiB5YHFyC3fxNEFjfDXxjlSTMXaGdHg7mdy9EfE2gXV7o1frhJPmW//MSG3QmobkrE3H7PtctUVaYU2Adj3DrvNCc5d5M5bpBXIztTyJvlNeoTzhZM4ZDa9VgjVtmzENY0WqCQ= Received: from HE1PR0802MB2555.eurprd08.prod.outlook.com (2603:10a6:3:e0::7) by HE1PR0801MB1722.eurprd08.prod.outlook.com (2603:10a6:3:87::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.16; Wed, 19 Aug 2020 12:58:58 +0000 Received: from HE1PR0802MB2555.eurprd08.prod.outlook.com ([fe80::a457:845c:78c6:29c0]) by HE1PR0802MB2555.eurprd08.prod.outlook.com ([fe80::a457:845c:78c6:29c0%5]) with mapi id 15.20.3283.028; Wed, 19 Aug 2020 12:58:58 +0000 From: Jianyong Wu To: Marc Zyngier CC: Paolo Bonzini , Peng Hao , "kernel-team@android.com" , "kvm@vger.kernel.org" , Will Deacon , Catalin Marinas , Alexander Graf , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH 47/56] KVM: arm64: timers: Move timer registers to the sys_regs file Thread-Topic: [PATCH 47/56] KVM: arm64: timers: Move timer registers to the sys_regs file Thread-Index: AQHWa1Xu75d1j9xetEK2hY75HyglSak/PN3ggAALmACAAAFIoIAACZ2AgAAmpjA= Date: Wed, 19 Aug 2020 12:58:57 +0000 Message-ID: References: <20200805175700.62775-1-maz@kernel.org> <20200805175700.62775-48-maz@kernel.org> <551eac52dcd3b19ae6db45dd6f6e168b@kernel.org> <5dd5ccf145b366e562782f117f25d880@kernel.org> In-Reply-To: <5dd5ccf145b366e562782f117f25d880@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1C9047D31495EC44A661620DA3AD3F82.0 x-checkrecipientchecked: true Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [2409:8a1e:6c6d:bd10:253b:c89:1240:79a8] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 39cc48c4-988d-4a92-0107-08d8443fa971 x-ms-traffictypediagnostic: HE1PR0801MB1722:|AM6PR08MB3222: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:651;OLM:651; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: EADkXhqFKtBfV/gU67pFACKHaLsvR4IiIeC5x4QzxBL9upthSF3+TatuioWoHXVDWB/J9xJwf6WHYc8eNFWjOy2UDdi9QfbRFWniVOUhlTadXYHg2+BTZoj1KpcTncZynVvZcicJUnFPFE+/qGMmh5mo6EJmb+pkXD+LII2a6xyzc/wrKuqXTudKuUUQcvYpUOfOkT3mA9/JaC+p4Ctx8+Ewjfzy7n5P9hOjvVIjwYbVx2QkfVD3DxQzkuG7fQWkuBIRgmWUedQ02S/BrLseKG3M3pvDC6VqG1SlScGBCz7HWoy7PdOHr+vxkE7VL8+ZuHNxu80fCes1CdgEpA6pwwMU3s1e8RAxwyw1cmVYEFcLqLv/E6A4yJ3Hiv73WLbhZ7KJ1JHk3utxAxksaj9/tw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0802MB2555.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(376002)(366004)(136003)(39860400002)(66556008)(4326008)(5660300002)(66946007)(86362001)(76116006)(8936002)(2906002)(66446008)(66476007)(52536014)(64756008)(186003)(966005)(55016002)(9686003)(53546011)(316002)(478600001)(54906003)(6506007)(83380400001)(8676002)(6916009)(33656002)(71200400001)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: EBBq2ApKATqHonVz5rFJJCIlpoFJ2Zuo5X9Ci5+abzLdJvAfvfwI7W/Q0Tf1AQIlLv5wCo0RQnRQBKhD8pHW1A6bsVE8p31FdCVTxj6DrEqcv3fGUFyByuJH+ur5Ktg4tlICqvBCAXLt+f3Sas0LpTj9/V30bTuq5d62dMo+ZBOWVnNF79YaktpqnBFVpH0IiUCP7xp0NsmomDn+8NKPbFblT0ODAZaz6wG9bvXVwtWC3M7RBLI/MWLpSo2LSOXXxXsWN5pjrvoOuiB/m0LBCGJ8NcdO8Pfo6Nw+zOt2n1VdZKaNU3unrUE5lfGWosG6W5rAWz3pFCBKXftMjMCOdncc8H0bYZg/XWx9+nfNl7SjHE7Hgyp7d1/SXh3crFjSS/I0dLlHQEK5ZU7n6RtklZ1I9Dx/tFv0ByBQNW0Oq6vv5ePlEwDN0lOiRwJXIIO+NKDQ+t1APMm9Oy78sgRLD4LLgcYkGZ3TYHetkbqfV25WqPoFHkdh+OVz1dbf7yXwaKCQR8/rfmuP/4osM125TZpYT6ulOZRl3dN9zCl5Dv6pPM8pi9evtrWOjkibudvaOqz01+J75EFLNZ0rJZSMZ9YFECnKjwgrV7PT9XQ4E1NDL9NZj4IuC7pJth0ZFpea3+YPUGI0BferTpw4Mt0uyFmswwN+e+lhIs2ktHTDT9Rqo07ucCS04n5s9KfUTrLdp6Wt6K/SVIKbFlEzJOurfw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1722 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 298008af-e5ec-4857-ec63-08d8443fa30c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bZtpXDDrdU4AxF27ejODWeC1HOK0kAPgt/B0DzV8W43pLjwIwe19X5ssxobukByJ+zZoBHlcgAWMqT+jjQw6jziCsn0vivJMtntB7LUav08hAIlfl43jvI0x+cXwJ3nlulM184xktfkr/ASNXjSPVWWizK8gd/HOdQOkLHNNQ9ru4kZIEz/1sGvWNVcqiXifBYU38ZfCaSWS2LNFVUaQ4bawjMtoM7rzrVcBYHxIVeTLryJsQK2gHOM0MB5VlnCk9+5DvGqqBszsGscNIhyr1NyOdra1NQBqPntwg/KJDH6Fw7zBvse23os2tBWrBJrD2oLxtq2M1/d1AWB1pWJ2jk2nAUNHgo2N+fjEH68MPvtmllm4/sRHqxu/6Oz0q+grDQ0l3NJlvcbWnqdPOIXqxS93CvApiaCGIasEi+7eYTI2pv0r5yaWN6ChPjk4QatZc8wzzt2xo3z2lY5T2RmJgf7urXbE5TfL5+SCHFk/oaQ= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(346002)(396003)(136003)(39860400002)(46966005)(26005)(86362001)(6506007)(7696005)(82740400003)(336012)(33656002)(53546011)(52536014)(47076004)(2906002)(5660300002)(966005)(186003)(9686003)(55016002)(478600001)(107886003)(316002)(8936002)(83380400001)(82310400002)(36906005)(70586007)(8676002)(81166007)(54906003)(356005)(6862004)(70206006)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2020 12:59:08.8175 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 39cc48c4-988d-4a92-0107-08d8443fa971 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3222 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org > -----Original Message----- > From: Marc Zyngier > Sent: Wednesday, August 19, 2020 6:39 PM > To: Jianyong Wu > Cc: Paolo Bonzini ; Peng Hao > ; kernel-team@android.com; kvm@vger.kernel.org; > Will Deacon ; Catalin Marinas ; > Alexander Graf ; kvmarm@lists.cs.columbia.edu; linux- > arm-kernel@lists.infradead.org > Subject: Re: [PATCH 47/56] KVM: arm64: timers: Move timer registers to th= e > sys_regs file >=20 > On 2020-08-19 11:18, Jianyong Wu wrote: > >> -----Original Message----- > >> From: Marc Zyngier > >> Sent: Wednesday, August 19, 2020 6:00 PM > >> To: Jianyong Wu > >> Cc: Paolo Bonzini ; Peng Hao > >> ; kernel-team@android.com; > >> kvm@vger.kernel.org; Will Deacon ; Catalin Marinas > >> ; Alexander Graf ; > >> kvmarm@lists.cs.columbia.edu; linux-arm-kernel@lists.infradead.org > >> Subject: Re: [PATCH 47/56] KVM: arm64: timers: Move timer registers > >> to the sys_regs file > >> > >> On 2020-08-19 10:24, Jianyong Wu wrote: > >> > Hi Marc, > >> > > >> > -----Original Message----- > >> > From: kvmarm-bounces@lists.cs.columbia.edu > >> > On Behalf Of Marc Zyngier > >> > Sent: Thursday, August 6, 2020 1:57 AM > >> > To: Paolo Bonzini > >> > Cc: Peng Hao ; kernel-team@android.com; > >> > kvm@vger.kernel.org; Will Deacon ; Catalin Marinas > >> > ; Alexander Graf ; > >> > kvmarm@lists.cs.columbia.edu; linux-arm-kernel@lists.infradead.org > >> > Subject: [PATCH 47/56] KVM: arm64: timers: Move timer registers to > >> > the sys_regs file > >> > > >> > Move the timer gsisters to the sysreg file. This will further help > >> > when they are directly changed by a nesting hypervisor in the VNCR > >> > page. > >> > > >> > This requires moving the initialisation of the timer struct so that > >> > some of the helpers (such as arch_timer_ctx_index) can work > >> > correctly at an early stage. > >> > > >> > Signed-off-by: Marc Zyngier > >> > --- > >> > arch/arm64/include/asm/kvm_host.h | 6 ++ > >> > arch/arm64/kvm/arch_timer.c | 155 +++++++++++++++++++++++----= --- > >> > arch/arm64/kvm/trace_arm.h | 8 +- > >> > include/kvm/arm_arch_timer.h | 11 +-- > >> > 4 files changed, 136 insertions(+), 44 deletions(-) > >> > > >> > +static u64 timer_get_offset(struct arch_timer_context *ctxt) { > >> > + struct kvm_vcpu *vcpu =3D ctxt->vcpu; > >> > + > >> > + switch(arch_timer_ctx_index(ctxt)) { > >> > + case TIMER_VTIMER: > >> > + return __vcpu_sys_reg(vcpu, CNTVOFF_EL2); > >> > + default: > >> > + return 0; > >> > + } > >> > +} > >> > + > >> > Can I export this helper? As in my ptp_kvm implementation I need > >> > get VCNT offset value separately not just give me a result of VCNT. > >> > >> Sorry, you need to give me a bit more context. What do you need the > >> offset for exactly? > > > > Yeah, > > In my ptp_kvm implementation, I need acquire wall time and counter > > cycle in the same time in host. After get host counter cycle, I need > > subtract it by VCNT offset to obtain VCNT. See > > https://lkml.org/lkml/2020/6/19/441 > > https://lkml.org/lkml/2020/6/19/441 > > But now I can't get the VCNT offset easily like before using " > > vcpu_vtimer(vcpu)->cntvoff" and I can't use the helper like > > "kvm_arm_timer_read" as I need acquire the counter cycle in the same > > time with the host wall time. >=20 > I must be missing something. CNTVOFF_EL2 is now implemented as a standard > system register, and has the same visibility as any other vcpu sysreg. >=20 > Why doesn't vcpu_read_sys_reg(vcpu, CNTVOFF_EL2) work for you? Maybe it serves me, let me try it, thanks. Thanks Jianyong >=20 > M. > -- > Jazz is not dead. It just smells funny...