From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BD03C433DF for ; Wed, 29 Jul 2020 23:49:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F14D3207E8 for ; Wed, 29 Jul 2020 23:49:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com header.b="dr9mtEcj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728030AbgG2Xtb (ORCPT ); Wed, 29 Jul 2020 19:49:31 -0400 Received: from mga11.intel.com ([192.55.52.93]:52007 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727087AbgG2Xtb (ORCPT ); Wed, 29 Jul 2020 19:49:31 -0400 IronPort-SDR: PyuL0+PdALzLn6Ylzgpj6tvVkI//q3Kpblgh7flY/yyEPfGvN95WtJ58PN6L+PGo5es/1lqMI9 Dy9qx6TJuruQ== X-IronPort-AV: E=McAfee;i="6000,8403,9697"; a="149351304" X-IronPort-AV: E=Sophos;i="5.75,412,1589266800"; d="scan'208";a="149351304" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2020 16:49:29 -0700 IronPort-SDR: cJN+EpEeZf6xpMog5KiEddhdCqM6Wf9v5/VE5ymk6GT2AnFjWFGU1k+sKJKq0pm5oxfEb9vvvi VPntrYy+kfQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,412,1589266800"; d="scan'208";a="364997503" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 29 Jul 2020 16:49:29 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 29 Jul 2020 16:49:28 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 29 Jul 2020 16:49:28 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.50) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Jul 2020 16:49:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TbZuiqWoLVlcDWCnql8UcKh4XTDr9NBmquKOugE/81XB99z9GaqyEo/4xM+tdwna4MqP1qj3hjKZQBygoTI0uUwGQCeHkzMkU3QOBMMnyY1BwNxbAT86lo67bFFbZsch+nD2h8pchDFpGL8+rRg65xQ3KtoDoqB9ysIeLzKoR/Cdq57aH0qTb4d32zMnpviNkFw1dycIJqRet5G8XOQK3ORjPvv456LvZiOIQf/YAYfb6jNbo+T3OpNRXY1+EH+fNC2cvVKyPbWr0A1JYAB1bmgiuc4SHuN+e2AqKbpqMfwV1E6HM6Sor8A5rmS2dH21pJ4rEhU/gRJUktTwkgNrSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4PK7/KpLzdW+2/tPM96HKKp0bFLdDyBix5v336s6YSE=; b=jMmhI0ISh5SqwYCfOIFZzHoQVuy8u7913vdzANODlEvi7thP2YefWdnelnCSq5L4RVZAcq165eYWEQHKnlApSw5LLxpXsYoVXBo7tr7zJucj8MPq0rO6Gz5V5Kh5j5W8C9rB2jc+U1kc0dJ1rYKV30IHjL0dVAbE1I2B/a5mjFN32djFbNZTrOXRpH+p0Iua2NtKP1qBPV+x7vmTOZao5nOFybtAu3v/VlvdfI/vryE5ROadqUoi8Vi+OFheKQjOr3KDFvn2+8FIYOWnEd6xwWYHjUWhD7kLlThAGQyrRZMG0n5z5ZBNcLmrnizwJh6MhUvYFY7cn7HxRh3SSTZMfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4PK7/KpLzdW+2/tPM96HKKp0bFLdDyBix5v336s6YSE=; b=dr9mtEcjRAagwVIBUPdJraTcc8uwa3nMfXep92JGYsZgLWXUqQWFIInktZKYONzxsut3LiuCpkV+3nn1wtn6zz+P+9Qf3tsbE22UwRk/AjTmrPrVi2es7gotyFaTwX7gjHW4CzucyH4KNVh5xMwXS2EAMBQ6sCnzguWrvlbVLSo= Received: from MWHPR11MB1645.namprd11.prod.outlook.com (2603:10b6:301:b::12) by MWHPR11MB2048.namprd11.prod.outlook.com (2603:10b6:300:27::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23; Wed, 29 Jul 2020 23:49:20 +0000 Received: from MWHPR11MB1645.namprd11.prod.outlook.com ([fe80::9864:e0cb:af36:6feb]) by MWHPR11MB1645.namprd11.prod.outlook.com ([fe80::9864:e0cb:af36:6feb%5]) with mapi id 15.20.3216.034; Wed, 29 Jul 2020 23:49:20 +0000 From: "Tian, Kevin" To: Alex Williamson , Lu Baolu CC: Joerg Roedel , Robin Murphy , Jean-Philippe Brucker , Cornelia Huck , "Raj, Ashok" , "Jiang, Dave" , "Liu, Yi L" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" Subject: RE: [PATCH v3 3/4] iommu: Add iommu_aux_get_domain_for_dev() Thread-Topic: [PATCH v3 3/4] iommu: Add iommu_aux_get_domain_for_dev() Thread-Index: AQHWWaRTwLJlmIhIiUK0CZQgQ7WVGKkfGWqAgAA12uA= Date: Wed, 29 Jul 2020 23:49:20 +0000 Message-ID: References: <20200714055703.5510-1-baolu.lu@linux.intel.com> <20200714055703.5510-4-baolu.lu@linux.intel.com> <20200729142507.182cd18a@x1.home> In-Reply-To: <20200729142507.182cd18a@x1.home> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0fe8b92e-f994-4fed-af2e-08d8341a03c0 x-ms-traffictypediagnostic: MWHPR11MB2048: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CwMY34YJTUNPck3YhDobpyFsmMHtA0DbI1+JwYlrMFq7/8OEt/L3+XrqvgaiPaxI6AJHz7q7HeNGGEvzDYO86c41FIfhke/KV0Z0+6rHMLrJOga7FgQ/AwBUKvWR7EB/Me+XIOWAjBg+JDFYGd9oP/VSShlsw4nqkaD/5tVyx5CfSox5MydaMtYO1JpxyEFK7/LvOItVoUQDgh37GgsSsq+Gp/nl+BPMB//cKraD6jhIIeRHmvAWytWkpE9ZWaOpkQnrk8e6UopqF4QlyEm1HpWEA33Yp8f4QVD9A84fhp5UCFUHisIlI4CdxNv3EnDE/JyXfIZX7uIi5TxlsXCfSA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1645.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(39860400002)(376002)(366004)(136003)(346002)(66476007)(6506007)(66446008)(66556008)(8676002)(64756008)(5660300002)(52536014)(66946007)(76116006)(7696005)(2906002)(110136005)(33656002)(9686003)(8936002)(316002)(478600001)(55016002)(86362001)(26005)(71200400001)(4326008)(54906003)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 1B7RTU2pT1+d25U00Jx1PqSoJ+3WSIRJTjzhspCS9fBw4eTUwg9xjAakfXyKedT3Ixpiisz1fq/6L9hvFUObcUzx6kaejpyjQkSxpBuODYvedWvLWEjYcwi0a6ybXo2ewVoLZZXH/WED4vX17l6XaotdM7jLF39Qrcq+5vx+8mMhLdfB5dlZt120I6XIRsje/X0fZerwLIUnxPLfz7T7uNDltMbrcEgR+XQMw415AsbXWXj9KCsO/AdZKzWDEvpncdL38u9xJn8R0tTMHxS9fYe9iP8isf/+Xn2p2eF3VJHkXo2KiFqMgZC6V7WZoGSd0oRwLTIvtKDnkoeGQaWbJYA6KPjdCd9VSGTHCoFIcDLhrNU7mAzZL0Yr0+t5Fi+nYsC9pd8539SUia/0yCpX5KWc2mtgclr2TCGZadEBONZpr3SZ+m4Nju6kUa2poLgCI5aauoEsaQLcNbR8NV59KTtKJZtaSWhfZ5wv8iUNzbMO7y4uaEyO86hM+BfEtuY4 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1645.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0fe8b92e-f994-4fed-af2e-08d8341a03c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2020 23:49:20.8679 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w1M+7a5MHIcYeFdB/4MouDzxXqw+OlaYhCfHfB4sLp69TPOSHUBeuPU9RsefR513MRv39kn/a6e6bFcm+QQdsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2048 X-OriginatorOrg: intel.com Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org > From: Alex Williamson > Sent: Thursday, July 30, 2020 4:25 AM >=20 > On Tue, 14 Jul 2020 13:57:02 +0800 > Lu Baolu wrote: >=20 > > The device driver needs an API to get its aux-domain. A typical usage > > scenario is: > > > > unsigned long pasid; > > struct iommu_domain *domain; > > struct device *dev =3D mdev_dev(mdev); > > struct device *iommu_device =3D vfio_mdev_get_iommu_device(dev)= ; > > > > domain =3D iommu_aux_get_domain_for_dev(dev); > > if (!domain) > > return -ENODEV; > > > > pasid =3D iommu_aux_get_pasid(domain, iommu_device); > > if (pasid <=3D 0) > > return -EINVAL; > > > > /* Program the device context */ > > .... > > > > This adds an API for such use case. > > > > Suggested-by: Alex Williamson > > Signed-off-by: Lu Baolu > > --- > > drivers/iommu/iommu.c | 18 ++++++++++++++++++ > > include/linux/iommu.h | 7 +++++++ > > 2 files changed, 25 insertions(+) > > > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > > index cad5a19ebf22..434bf42b6b9b 100644 > > --- a/drivers/iommu/iommu.c > > +++ b/drivers/iommu/iommu.c > > @@ -2817,6 +2817,24 @@ void iommu_aux_detach_group(struct > iommu_domain *domain, > > } > > EXPORT_SYMBOL_GPL(iommu_aux_detach_group); > > > > +struct iommu_domain *iommu_aux_get_domain_for_dev(struct device > *dev) > > +{ > > + struct iommu_domain *domain =3D NULL; > > + struct iommu_group *group; > > + > > + group =3D iommu_group_get(dev); > > + if (!group) > > + return NULL; > > + > > + if (group->aux_domain_attached) > > + domain =3D group->domain; >=20 > Why wouldn't the aux domain flag be on the domain itself rather than > the group? Then if we wanted sanity checking in patch 1/ we'd only > need to test the flag on the object we're provided. >=20 > If we had such a flag, we could create an iommu_domain_is_aux() > function and then simply use iommu_get_domain_for_dev() and test that > it's an aux domain in the example use case. It seems like that would IOMMU layer manages domains per parent device. Here given a dev (of mdev), we need a way to find its associated domain under its parent device. And we cannot simply use iommu_get_domain_for_dev on the parent device of the mdev, as it will give us the primary domain of parent device.=20 Thanks Kevin > resolve the jump from a domain to an aux-domain just as well as adding > this separate iommu_aux_get_domain_for_dev() interface. The is_aux > test might also be useful in other cases too. Thanks, >=20 > Alex >=20 > > + > > + iommu_group_put(group); > > + > > + return domain; > > +} > > +EXPORT_SYMBOL_GPL(iommu_aux_get_domain_for_dev); > > + > > /** > > * iommu_sva_bind_device() - Bind a process address space to a device > > * @dev: the device > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > > index 9506551139ab..cda6cef7579e 100644 > > --- a/include/linux/iommu.h > > +++ b/include/linux/iommu.h > > @@ -639,6 +639,7 @@ int iommu_aux_attach_group(struct > iommu_domain *domain, > > struct iommu_group *group, struct device *dev); > > void iommu_aux_detach_group(struct iommu_domain *domain, > > struct iommu_group *group, struct device *dev); > > +struct iommu_domain *iommu_aux_get_domain_for_dev(struct device > *dev); > > > > struct iommu_sva *iommu_sva_bind_device(struct device *dev, > > struct mm_struct *mm, > > @@ -1040,6 +1041,12 @@ iommu_aux_detach_group(struct > iommu_domain *domain, > > { > > } > > > > +static inline struct iommu_domain * > > +iommu_aux_get_domain_for_dev(struct device *dev) > > +{ > > + return NULL; > > +} > > + > > static inline struct iommu_sva * > > iommu_sva_bind_device(struct device *dev, struct mm_struct *mm, void > *drvdata) > > {