From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A15C433E9 for ; Mon, 21 Dec 2020 18:31:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8ACD6230FC for ; Mon, 21 Dec 2020 18:31:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbgLUSbb (ORCPT ); Mon, 21 Dec 2020 13:31:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbgLUSba (ORCPT ); Mon, 21 Dec 2020 13:31:30 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE0DAC061248 for ; Mon, 21 Dec 2020 10:30:50 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id v1so6624289pjr.2 for ; Mon, 21 Dec 2020 10:30:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9BndlnR8XFV7ufaUUoRBTJ+c5o1iLuwOiCGBoThwMts=; b=Fya1rBbEsbyEQQ+HWesPL7CMy2wvqOkx7OLk8aDsoKZy3PmgBwKNg3vz/LaEam8pMY Yns4sFjlmT4mmwsPsE2vu2J+srX4q6c66fpGm1Yt8ryY8G8OcXzw57KrSi+e+nPa9c9m Q2v5DpqiPly3llZtPexN0PGGooUWox5HJJ8bv/JR7igogjxW47lg69if5f6Fs1fEW3PE BHGs5dLhLdpOaUNZhkZbFW5iQu/fvZqz2A8DKqOTgdnUCMH4emOBUOlU73b3Jn67EEcd b5JuyFRMe37nqNb09homoUH/NRXj9sxnsSZWmAQcVonRa7jptSTG8C2VxJcwMfQJWkNu gseg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9BndlnR8XFV7ufaUUoRBTJ+c5o1iLuwOiCGBoThwMts=; b=P0tdNTx7YrtvyUkvf64b7O8xS4xQilgovy5jCO81C1rk/gx8AmbpLUv+TL4cF1/dt8 r/j36eF6eBjGKF7bfyxjtThaiR4RYNOv8utsAACcOUgT5jOWlioUR4BuYbhFZQha19aR 0jOTDcE7D0yh5QhO2o5FMoxGsK8Ta8IIx4JlvfaWqyvxpxfhXda7Gq7qtirzLmbm9AbI 6wh6Dl+6u5yGnsWkqZhYyHKwaSk46iess/UELrJWwrbEkefvNKyB2idJqXXzTb5fYbzn BoKczJX+E0wJUuqXgzLxqU4O1rDLO88/ONeOWV7HiE0xYr7jObR3jukFAEUteKXyCbbx LiZw== X-Gm-Message-State: AOAM533gI1PwVzqptWMFjP5OUmcX72P6EuvQXvfnXpA95aakpxNrsDss hwZSTKI17hT7Nj+pW2n8cww4pQ== X-Google-Smtp-Source: ABdhPJzWkvFh2A1UOPl97SQ4AcJKKgP93CoLuXU9vMBQjF4kQHp2OSo8wtjRTXHm1Wf4N8AmEzXXCQ== X-Received: by 2002:a17:902:b783:b029:da:6567:f244 with SMTP id e3-20020a170902b783b02900da6567f244mr17115792pls.45.1608575450120; Mon, 21 Dec 2020 10:30:50 -0800 (PST) Received: from google.com ([2620:15c:f:10:1ea0:b8ff:fe73:50f5]) by smtp.gmail.com with ESMTPSA id j16sm17737497pgl.50.2020.12.21.10.30.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 10:30:49 -0800 (PST) Date: Mon, 21 Dec 2020 10:30:42 -0800 From: Sean Christopherson To: Paolo Bonzini Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon , Richard Herbert Subject: Re: [PATCH 2/4] KVM: x86/mmu: Get root level from walkers when retrieving MMIO SPTE Message-ID: References: <20201218003139.2167891-1-seanjc@google.com> <20201218003139.2167891-3-seanjc@google.com> <87r1nntr7s.fsf@vitty.brq.redhat.com> <493c0252-7aa1-b14d-0172-91bf75cf7553@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <493c0252-7aa1-b14d-0172-91bf75cf7553@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Dec 21, 2020, Paolo Bonzini wrote: > On 18/12/20 10:10, Vitaly Kuznetsov wrote: > > > - int root = vcpu->arch.mmu->shadow_root_level; > > > - int leaf; > > > - int level; > > > + int root, leaf, level; > > > bool reserved = false; > > Personal taste: I would've renamed 'root' to 'root_level' (to be > > consistent with get_walk()/kvm_tdp_mmu_get_walk()) and 'level' to > > e.g. 'l' as it's only being used as an interator ('i' would also do). > > Maybe agree on the former, not really on the latter. :) Same here. I kept 'root' to reduce code churn, even though I'd probably have used 'root_level' if I were writing from scratch.