kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Bill Wendling <morbo@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	linux-kselftest@vger.kernel.org, kvm@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Shuah Khan <shuah@kernel.org>, Jian Cai <caij2003@gmail.com>
Subject: Re: [PATCH] selftests: kvm: remove reassignment of non-absolute variables
Date: Thu, 10 Dec 2020 16:50:09 -0800	[thread overview]
Message-ID: <X9LCQYB2yqMaUqkj@google.com> (raw)
In-Reply-To: <20201210043611.3156624-1-morbo@google.com>

On Wed, Dec 09, 2020, Bill Wendling wrote:
> Clang's integrated assembler does not allow symbols with non-absolute
> values to be reassigned. Modify the interrupt entry loop macro to be
> compatible with IAS by using a label and an offset.
> 
> Cc: Jian Cai <caij2003@gmail.com>
> Signed-off-by: Bill Wendling <morbo@google.com>
> References: https://lore.kernel.org/lkml/20200714233024.1789985-1-caij2003@gmail.com/
> ---
>  tools/testing/selftests/kvm/lib/x86_64/handlers.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/kvm/lib/x86_64/handlers.S b/tools/testing/selftests/kvm/lib/x86_64/handlers.S
> index aaf7bc7d2ce1..3f9181e9a0a7 100644
> --- a/tools/testing/selftests/kvm/lib/x86_64/handlers.S
> +++ b/tools/testing/selftests/kvm/lib/x86_64/handlers.S
> @@ -54,9 +54,9 @@ idt_handlers:
>  	.align 8
>  
>  	/* Fetch current address and append it to idt_handlers. */
> -	current_handler = .
> +0 :
>  .pushsection .rodata
> -.quad current_handler
> +	.quad 0b

Bit of a silly nit: can we use a named label, or at least a non-zero shorthand?
It's really easy to misread "0b" as zeroing out the value, at least for me.

>  .popsection
>  
>  	.if ! \has_error
> -- 
> 2.29.2.576.ga3fc446d84-goog
> 

  reply	other threads:[~2020-12-11  0:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10  4:36 Bill Wendling
2020-12-11  0:50 ` Sean Christopherson [this message]
2020-12-11  1:04   ` Bill Wendling
2020-12-11  1:07     ` Sean Christopherson
2020-12-11  1:10       ` Bill Wendling
2020-12-11  1:19         ` Sean Christopherson
2020-12-11  1:23           ` [PATCH v2] " Bill Wendling
2021-05-03 18:37             ` Jim Mattson
2021-05-04  7:22               ` Paolo Bonzini
2020-12-11  1:36     ` [PATCH] " Jim Mattson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X9LCQYB2yqMaUqkj@google.com \
    --to=seanjc@google.com \
    --cc=benh@kernel.crashing.org \
    --cc=caij2003@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=morbo@google.com \
    --cc=pbonzini@redhat.com \
    --cc=shuah@kernel.org \
    --subject='Re: [PATCH] selftests: kvm: remove reassignment of non-absolute variables' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).