From: Sean Christopherson <seanjc@google.com>
To: Will Deacon <will@kernel.org>
Cc: Quentin Perret <qperret@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
"open list:KERNEL VIRTUAL MACHINE (KVM)" <kvm@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
android-kvm@google.com, kernel-team@android.com
Subject: Re: [PATCH] KVM: Documentation: Fix spec for KVM_CAP_ENABLE_CAP_VM
Date: Fri, 15 Jan 2021 14:31:57 -0800 [thread overview]
Message-ID: <YAIX3WkXSURLyj0S@google.com> (raw)
In-Reply-To: <20210115165004.GA14556@willie-the-truck>
On Fri, Jan 15, 2021, Will Deacon wrote:
> On Fri, Jan 08, 2021 at 04:53:49PM +0000, Quentin Perret wrote:
> > The documentation classifies KVM_ENABLE_CAP with KVM_CAP_ENABLE_CAP_VM
> > as a vcpu ioctl, which is incorrect. Fix it by specifying it as a VM
> > ioctl.
On a related topic, x86 should report KVM_CAP_ENABLE_CAP as supported, it's had
a vCPU version since commit 5c919412fe61 ("kvm/x86: Hyper-V synthetic interrupt
controller"). I'll send a patch.
> > Fixes: e5d83c74a580 ("kvm: make KVM_CAP_ENABLE_CAP_VM architecture agnostic")
> > Signed-off-by: Quentin Perret <qperret@google.com>
> > ---
> > Documentation/virt/kvm/api.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
> > index 70254eaa5229..68898b623d86 100644
> > --- a/Documentation/virt/kvm/api.rst
> > +++ b/Documentation/virt/kvm/api.rst
> > @@ -1328,7 +1328,7 @@ documentation when it pops into existence).
> >
> > :Capability: KVM_CAP_ENABLE_CAP_VM
> > :Architectures: all
> > -:Type: vcpu ioctl
> > +:Type: vm ioctl
> > :Parameters: struct kvm_enable_cap (in)
> > :Returns: 0 on success; -1 on error
>
> I tripped over this as well, so:
>
> Acked-by: Will Deacon <will@kernel.org>
The problem is that you read the documentation. Who does that?
Reviewed-by: Sean Christopherson <seanjc@google.com>
next prev parent reply other threads:[~2021-01-15 22:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 16:53 [PATCH] KVM: Documentation: Fix spec for KVM_CAP_ENABLE_CAP_VM Quentin Perret
2021-01-15 13:49 ` Quentin Perret
2021-01-15 16:50 ` Will Deacon
2021-01-15 22:31 ` Sean Christopherson [this message]
2021-01-18 17:38 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAIX3WkXSURLyj0S@google.com \
--to=seanjc@google.com \
--cc=android-kvm@google.com \
--cc=corbet@lwn.net \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qperret@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).