From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A56CC433DB for ; Wed, 20 Jan 2021 17:22:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1AD5233E2 for ; Wed, 20 Jan 2021 17:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730722AbhATOuA (ORCPT ); Wed, 20 Jan 2021 09:50:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:36592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732270AbhATOKc (ORCPT ); Wed, 20 Jan 2021 09:10:32 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D4BFE23340; Wed, 20 Jan 2021 14:09:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611151791; bh=+QB0BLymRI9B7AAdcngdNimXE2bx1a9/kQQUVsTMFrw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PLhHQTlscjRHcQLw3JMl9XVdL+D+8Z0yMiPjwWYRBWnqNp7syNqBbBJ2niQOWRUEr INHkLC9v8qlq/6RuckYbfVaaeDOjNaJwOLXxzDF6fYDR96daP41NIc2+9hRKq9N6dU lrPI9l+hQGWOUkA9jMUEz0EsoWto8gidn5yi14XEdKiJbodQln/3u+JirnZ537i9g8 WawxXcrpaywahopwuistd3y1LzIBM+yq0R/t/6bQ4il0AMO6BqF2f9rpmm3DhIC0zJ S1mamlcutpVxTvk+HvMXZfaLAXmU+IJu9hZX4WGrIuRfrXoUbBIHW+h5YchglHtkqG OEAiKFSrm2Tfw== Date: Wed, 20 Jan 2021 16:09:45 +0200 From: Jarkko Sakkinen To: Kai Huang Cc: linux-sgx@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org, seanjc@google.com, luto@kernel.org, dave.hansen@intel.com, haitao.huang@intel.com, pbonzini@redhat.com, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com Subject: Re: [RFC PATCH v2 14/26] x86/sgx: Move provisioning device creation out of SGX driver Message-ID: References: <4aeb65be69701a4a6e7d479ad3563bf7a9f052d5.1610935432.git.kai.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4aeb65be69701a4a6e7d479ad3563bf7a9f052d5.1610935432.git.kai.huang@intel.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Jan 18, 2021 at 04:28:07PM +1300, Kai Huang wrote: > From: Sean Christopherson > > And extract sgx_set_attribute() out of sgx_ioc_enclave_provision() and > export it as symbol for KVM to use. > > Provisioning key is sensitive. SGX driver only allows to create enclave > which can access provisioning key when enclave creator has permission to > open /dev/sgx_provision. It should apply to VM as well, as provisioning > key is platform specific, thus unrestricted VM can also potentially > compromise provisioning key. > > Move provisioning device creation out of sgx_drv_init() to sgx_init() as > preparation for adding SGX virtualization support, so that even SGX > driver is not enabled due to flexible launch control is not available, > SGX virtualization can still be enabled, and use it to restrict VM's > capability of being able to access provisioning key. > > Signed-off-by: Sean Christopherson > Signed-off-by: Kai Huang > --- > arch/x86/include/asm/sgx.h | 3 +++ > arch/x86/kernel/cpu/sgx/driver.c | 17 ------------ > arch/x86/kernel/cpu/sgx/ioctl.c | 16 ++---------- > arch/x86/kernel/cpu/sgx/main.c | 45 +++++++++++++++++++++++++++++++- > 4 files changed, 49 insertions(+), 32 deletions(-) > > diff --git a/arch/x86/include/asm/sgx.h b/arch/x86/include/asm/sgx.h > index 0d643b985085..795d724fab87 100644 > --- a/arch/x86/include/asm/sgx.h > +++ b/arch/x86/include/asm/sgx.h > @@ -4,6 +4,9 @@ > > #include > > +int sgx_set_attribute(unsigned long *allowed_attributes, > + unsigned int attribute_fd); > + > #ifdef CONFIG_X86_SGX_VIRTUALIZATION > struct sgx_pageinfo; > > diff --git a/arch/x86/kernel/cpu/sgx/driver.c b/arch/x86/kernel/cpu/sgx/driver.c > index f2eac41bb4ff..4f3241109bda 100644 > --- a/arch/x86/kernel/cpu/sgx/driver.c > +++ b/arch/x86/kernel/cpu/sgx/driver.c > @@ -133,10 +133,6 @@ static const struct file_operations sgx_encl_fops = { > .get_unmapped_area = sgx_get_unmapped_area, > }; > > -const struct file_operations sgx_provision_fops = { > - .owner = THIS_MODULE, > -}; > - > static struct miscdevice sgx_dev_enclave = { > .minor = MISC_DYNAMIC_MINOR, > .name = "sgx_enclave", > @@ -144,13 +140,6 @@ static struct miscdevice sgx_dev_enclave = { > .fops = &sgx_encl_fops, > }; > > -static struct miscdevice sgx_dev_provision = { > - .minor = MISC_DYNAMIC_MINOR, > - .name = "sgx_provision", > - .nodename = "sgx_provision", > - .fops = &sgx_provision_fops, > -}; > - > int __init sgx_drv_init(void) > { > unsigned int eax, ebx, ecx, edx; > @@ -184,11 +173,5 @@ int __init sgx_drv_init(void) > if (ret) > return ret; > > - ret = misc_register(&sgx_dev_provision); > - if (ret) { > - misc_deregister(&sgx_dev_enclave); > - return ret; > - } > - > return 0; > } > diff --git a/arch/x86/kernel/cpu/sgx/ioctl.c b/arch/x86/kernel/cpu/sgx/ioctl.c > index 1bae754268d1..4714de12422d 100644 > --- a/arch/x86/kernel/cpu/sgx/ioctl.c > +++ b/arch/x86/kernel/cpu/sgx/ioctl.c > @@ -2,6 +2,7 @@ > /* Copyright(c) 2016-20 Intel Corporation. */ > > #include > +#include > #include > #include > #include > @@ -664,24 +665,11 @@ static long sgx_ioc_enclave_init(struct sgx_encl *encl, void __user *arg) > static long sgx_ioc_enclave_provision(struct sgx_encl *encl, void __user *arg) > { > struct sgx_enclave_provision params; > - struct file *file; > > if (copy_from_user(¶ms, arg, sizeof(params))) > return -EFAULT; > > - file = fget(params.fd); > - if (!file) > - return -EINVAL; > - > - if (file->f_op != &sgx_provision_fops) { > - fput(file); > - return -EINVAL; > - } > - > - encl->attributes_mask |= SGX_ATTR_PROVISIONKEY; > - > - fput(file); > - return 0; > + return sgx_set_attribute(&encl->attributes_mask, params.fd); > } > > long sgx_ioctl(struct file *filep, unsigned int cmd, unsigned long arg) > diff --git a/arch/x86/kernel/cpu/sgx/main.c b/arch/x86/kernel/cpu/sgx/main.c > index 1cf1f0f058b8..e14ddfa9b78b 100644 > --- a/arch/x86/kernel/cpu/sgx/main.c > +++ b/arch/x86/kernel/cpu/sgx/main.c > @@ -1,14 +1,18 @@ > // SPDX-License-Identifier: GPL-2.0 > /* Copyright(c) 2016-20 Intel Corporation. */ > > +#include > #include > #include > #include > +#include > #include > #include > #include > #include > #include > +#include > +#include > #include "driver.h" > #include "encl.h" > #include "encls.h" > @@ -705,6 +709,38 @@ void sgx_update_lepubkeyhash(u64 *lepubkeyhash) > wrmsrl(MSR_IA32_SGXLEPUBKEYHASH0 + i, lepubkeyhash[i]); > } > > +const struct file_operations sgx_provision_fops = { > + .owner = THIS_MODULE, > +}; > + > +static struct miscdevice sgx_dev_provision = { > + .minor = MISC_DYNAMIC_MINOR, > + .name = "sgx_provision", > + .nodename = "sgx_provision", > + .fops = &sgx_provision_fops, > +}; > + > +int sgx_set_attribute(unsigned long *allowed_attributes, > + unsigned int attribute_fd) kdoc > +{ > + struct file *file; > + > + file = fget(attribute_fd); > + if (!file) > + return -EINVAL; > + > + if (file->f_op != &sgx_provision_fops) { > + fput(file); > + return -EINVAL; > + } > + > + *allowed_attributes |= SGX_ATTR_PROVISIONKEY; > + > + fput(file); > + return 0; > +} > +EXPORT_SYMBOL_GPL(sgx_set_attribute); > + > static void __init sgx_init(void) > { > int ret; > @@ -719,13 +755,20 @@ static void __init sgx_init(void) > if (!sgx_page_reclaimer_init()) > goto err_page_cache; > > + ret = misc_register(&sgx_dev_provision); > + if (ret) > + goto err_kthread; > + > /* Success if the native *or* virtual EPC driver initialized cleanly. */ > ret = !!sgx_drv_init() & !!sgx_virt_epc_init(); > if (ret) > - goto err_kthread; > + goto err_provision; > > return; > > +err_provision: > + misc_deregister(&sgx_dev_provision); > + > err_kthread: > kthread_stop(ksgxd_tsk); > > -- > 2.29.2 > > /Jarkko