From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D354AC433E0 for ; Wed, 27 Jan 2021 05:00:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C6D12070A for ; Wed, 27 Jan 2021 05:00:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238517AbhA0EY6 (ORCPT ); Tue, 26 Jan 2021 23:24:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725320AbhA0BZT (ORCPT ); Tue, 26 Jan 2021 20:25:19 -0500 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47E9EC061786 for ; Tue, 26 Jan 2021 17:12:05 -0800 (PST) Received: by mail-pg1-x534.google.com with SMTP id z21so443370pgj.4 for ; Tue, 26 Jan 2021 17:12:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=h4YmZOf34leeTQFI3eVZ6RKnokT375TaRDpu5h/uKr0=; b=C22G2NnLTkRdn/mttyEGOMoXxuTI2raLaGT4eCAOpNLzguJMhhMmlz0hxMQ5gA2Rj9 qTOfsm8D9kYABK9iahC0LW6TJZGFYlNTBRFUajK7C0nvPhjSPfRyPxrSld7uQxz5yEPk 8gOyD6zIHU7KjQD4jKwUI3I0eCeE4pQBotxDMRCpTJ3onB6SaWW6YcvXP1A3os4mkSh+ ZWrMmw2P91GRl1Zfse3yYl0EuS7KKt7X4SpR8JphUOejt6zAT3zvjROsAJ8vux6lw3Tb YXzV6lDO0Zfg+oWDaGv5DDtrpWLiCpE/+MzqEQ1j9jOyYE+FHvZUTvAXPton0sk+fASu ZqXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=h4YmZOf34leeTQFI3eVZ6RKnokT375TaRDpu5h/uKr0=; b=FHXLw3FB4sjB4ODgJlzrBTL4oTBaFqfWNwsR7BayR+bBDA3MjFRCpuIcyKC4wz2+a7 GU/jvsX0pUV+DqTn4pWK8XYxsJKAiTF/ELkE2r8GGff89fnfHNMkHBN/GzVteU0w13GH C/JloHOxyCwihj5caIW+BmFcXQyAhdHB43N6xw8+L1aizeLsiVEaWjYfbpmDIhv9BxN+ UBBSzHfeWQa8QBP8zxL04Lf2hQUlqV9pw4zLiAVn5VPH5rjdvzc0ZsgQ1M8ddbCEcZXb 5wuKq4BrteypDBNovFHqRzlk4JuiqmIAER9ze5HF95KfYj1m7HuqN0Lz2Vlp4sK/WOYY lYWQ== X-Gm-Message-State: AOAM531zhBGl3bGwPaLzmMYZ4VzGzg+GBRzggSExi3YHfP7WTlglwDFT x/mnK9ZSKTf6Yf8KnD44PTmUcQ== X-Google-Smtp-Source: ABdhPJyEFpCKvCKNjaSTTtBB/neKejTeHgWHIeRI3pSHLk8JaIe8gAIqZfxZc0fdfHzlPPO0ubyR3w== X-Received: by 2002:a65:6895:: with SMTP id e21mr8328535pgt.240.1611709924537; Tue, 26 Jan 2021 17:12:04 -0800 (PST) Received: from google.com ([2620:0:1008:10:1ea0:b8ff:fe75:b885]) by smtp.gmail.com with ESMTPSA id gx21sm136854pjb.31.2021.01.26.17.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 17:12:03 -0800 (PST) Date: Tue, 26 Jan 2021 17:11:59 -0800 From: Vipin Sharma To: Tejun Heo Cc: David Rientjes , Sean Christopherson , Tom Lendacky , "Singh, Brijesh" , "Grimm, Jon" , "Van Tassell, Eric" , pbonzini@redhat.com, lizefan@huawei.com, hannes@cmpxchg.org, frankja@linux.ibm.com, borntraeger@de.ibm.com, corbet@lwn.net, joro@8bytes.org, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, gingell@google.com, dionnaglaze@google.com, kvm@vger.kernel.org, x86@kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v4 1/2] cgroup: svm: Add Encryption ID controller Message-ID: References: <1744f6c-551b-8de8-263e-5dac291b7ef@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jan 26, 2021 at 05:01:04PM -0500, Tejun Heo wrote: > The whole thing seems pretty immature to me and I agree with you that coming > up with an abstraction at this stage feels risky. > > I'm leaning towards creating a misc controller to shove these things into: > > * misc.max and misc.current: nested keyed files listing max and current > usage for the cgroup. > > * Have an API to activate or update a given resource with total resource > count. I'd much prefer the resource list to be in the controller itself > rather than being through some dynamic API just so that there is some > review in what keys get added. > > * Top level cgroup lists which resource is active and how many are > available. Sounds good, we can have a single top level stat file misc.stat Shows how many are supported on the host: $ cat misc.stat sev 500 sev_es 10 If total value of some resource is 0 then it will be considered inactive and won't show in misc.{stat, current, max} We discussed earlier, instead of having "stat" file we should show "current" and "capacity" files in the root but I think we can just have stat at top showing total resources to keep it consistent with other cgroup files. Thanks Vipin