From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96CE2C433E9 for ; Fri, 12 Mar 2021 15:38:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7466764FF3 for ; Fri, 12 Mar 2021 15:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231786AbhCLPiJ (ORCPT ); Fri, 12 Mar 2021 10:38:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231855AbhCLPhv (ORCPT ); Fri, 12 Mar 2021 10:37:51 -0500 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14214C061574 for ; Fri, 12 Mar 2021 07:37:51 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id y13so2126363pfr.0 for ; Fri, 12 Mar 2021 07:37:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Jt792dKs/llgyWo33ymCHaCpazZPEqhvhL9FOp358RY=; b=QPGQHAi8U/A8w1ozQCOU/Sp7LU/rEAp/duoe1R09x6vf8uNlf96uvoVoCvXv0Y0Gns 2dHixhTPIxSQG0erhnkUDsm0gFXbesWBuaT6u/msjXrwkYlj3v5QDYW9taAo/PGOlXkL YRKZk6/yjFL2epGSNWNXiwtABmPLrafl9RMtFrye/de9eZ5nNLePa70ziFrGCUJrl2na lA1BoJpbAflNA6j1uJ8bHglxKBUOGI925DbfnpLJbozUJLhETto4nR61qj/SbJwDaS17 tWtUTmGMpTx8kAsRSDENkwQ2k7aTwxGbLNHwhKTrmutcUptbymYKHnNt2OMQfDf+o1zQ sxYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Jt792dKs/llgyWo33ymCHaCpazZPEqhvhL9FOp358RY=; b=sbXZilMhYD/4WEd3jkrpucJiw/3I79WJpHsdQOO4B3GFHJwUJm81NDba59MPckUJtA U/q/hlGeG2Dj1roiXUKN9RI55uOz0YpUfd+dIMOv1QbdYxmOkyWWk6kxM51MqcF1TuuX M3Dgl+9QpmFGUqm7vLkED/vBG3U2i8wCsOryj/22GRBa+lc7Ha73cKPeyWrfqkKbGliG x+5c5f/T9CWv0EUSgBkFO+7pEy+/HbguZxcc+hYhuLi8JmLC6s4Hf7b72FXI4zQRvZhK OyqjtXEKlKD72LA+Bdn4xEa3fHZkpsCAy8voRrah/Y8pT5d+KKrf/4jseneBNfPa4u26 CeWw== X-Gm-Message-State: AOAM530vt+aJbAYG83dyjbjaWn9EXM+gGF8ElOKRzLm2V5M7fwAMjaux bRocaWBO00jol5IYgbCCKRxizw== X-Google-Smtp-Source: ABdhPJy7W4+TtX5yPhl51VidgkDEFB41N9o6eUWz+XIlw9pLvmmH+nNSdsbWFo95/Bk7G1dsBd4juw== X-Received: by 2002:a63:fc12:: with SMTP id j18mr12234082pgi.334.1615563470368; Fri, 12 Mar 2021 07:37:50 -0800 (PST) Received: from google.com ([2620:15c:f:10:e1a6:2eeb:4e45:756]) by smtp.gmail.com with ESMTPSA id e1sm5905729pfi.175.2021.03.12.07.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 07:37:49 -0800 (PST) Date: Fri, 12 Mar 2021 07:37:43 -0800 From: Sean Christopherson To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Peter Shier , Jim Mattson Subject: Re: [PATCH 1/4] KVM: x86/mmu: Fix RCU usage in handle_removed_tdp_mmu_page Message-ID: References: <20210311231658.1243953-1-bgardon@google.com> <20210311231658.1243953-2-bgardon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210311231658.1243953-2-bgardon@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Mar 11, 2021, Ben Gardon wrote: > The pt passed into handle_removed_tdp_mmu_page does not need RCU > protection, as it is not at any risk of being freed by another thread at > that point. However, the implicit cast from tdp_sptep_t to u64 * dropped > the __rcu annotation without a proper rcu_derefrence. Fix this by > passing the pt as a tdp_ptep_t and then rcu_dereferencing it in > the function. > > Suggested-by: Sean Christopherson > Reported-by: kernel test robot Should be . Looks like you've been taking pointers from Paolo :-) https://lkml.org/lkml/2019/6/17/1210 Other than that, Reviewed-by: Sean Christopherson > Signed-off-by: Ben Gardon