From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3996C433E0 for ; Fri, 12 Mar 2021 19:49:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C2FE64F84 for ; Fri, 12 Mar 2021 19:49:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234423AbhCLTtQ (ORCPT ); Fri, 12 Mar 2021 14:49:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234483AbhCLTsp (ORCPT ); Fri, 12 Mar 2021 14:48:45 -0500 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21DA5C061761 for ; Fri, 12 Mar 2021 11:48:45 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id p21so16536920pgl.12 for ; Fri, 12 Mar 2021 11:48:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zuaTRfZk4KRzZSmxlNItyx5xWByHUkD0/JshLCV8WMM=; b=IaU52dkJTOEb+ySNKCWrDTgUccXTzzNVSIkFb/oKqISl2Zm82pfTIJJrINPh3gEISu wqODIgofIW2biXzNaXrk3K+R3ysiwdg1lxXYXgGwQhEoZim8L6kmWGvPvbPFsLuqwe2Q vVCGaYGtGcQzOgriqb7Hp2kKwnHn7/oAzr0LLbRo1OS1HxJtuPo8NChHgDBZXrOz/HOG VG/JR249fw7osncKemnky6bHNM+nEzmsBDygYDdRYTuS9U36krcOs5ZhiEDJ6Ylcq2sW 2+IGeAShq0oeY79hz1mA+M0B0L64tNihivmYUoJmtqNaIdMvuwJtTIpBY/LhINyzP5aT 1/jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zuaTRfZk4KRzZSmxlNItyx5xWByHUkD0/JshLCV8WMM=; b=X1DbxvzwXeretEuymbiuhXvJ45XzWM3b+/ScJzBJp2nu6EReQ8ERg9QnwCrZdRjK6N 8dpDt8rXt+8TzThZLFFgP1pYGfumL6sRf55AfEdU4gwVnscYwN6+31FP9VlOqCmpbFA9 U+5+tRGbFj6kpvbplnXEghbmZPs6hZWWwxNDgkVA2sQY7dPdznHbCtpC3FJ2pjfx31wK EeKquHC866vEJLqiRQIojhxHVAWisA2EzoIPnc3PUjyayiYUyPSxuQo0kJHPfgtYISuW VZfTNN2zgTm206XKZ7QMCYrJ2v2eAs4f79LQXi38oYgAxN4EAU5SFWsl8RTuAAWD+aFJ 4HPQ== X-Gm-Message-State: AOAM531BHEjdaHLi3a83Ncm0ExQDDs3WiVDiX6Dd82FbEDngSCZYmuDq T7Mbhg9QaGR8/Y2RcfVvnJkswg== X-Google-Smtp-Source: ABdhPJzGk8z+hRYJIelsgLmqze4xOJsszbrmql44ifGCVwomYJCoZkZ9EwNOwzZxf4uGsUWJtnSg9A== X-Received: by 2002:a63:1d26:: with SMTP id d38mr13639513pgd.385.1615578524487; Fri, 12 Mar 2021 11:48:44 -0800 (PST) Received: from google.com ([2620:0:1008:10:18a1:1d64:e35b:961e]) by smtp.gmail.com with ESMTPSA id d22sm5745803pfn.25.2021.03.12.11.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 11:48:43 -0800 (PST) Date: Fri, 12 Mar 2021 11:48:37 -0800 From: Vipin Sharma To: Michal =?iso-8859-1?Q?Koutn=FD?= , thomas.lendacky@amd.com, brijesh.singh@amd.com Cc: tj@kernel.org, rdunlap@infradead.org, jon.grimm@amd.com, eric.vantassell@amd.com, pbonzini@redhat.com, hannes@cmpxchg.org, frankja@linux.ibm.com, borntraeger@de.ibm.com, corbet@lwn.net, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, gingell@google.com, rientjes@google.com, dionnaglaze@google.com, kvm@vger.kernel.org, x86@kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v3 1/2] cgroup: sev: Add misc cgroup controller Message-ID: References: <20210304231946.2766648-1-vipinsh@google.com> <20210304231946.2766648-2-vipinsh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Mar 11, 2021 at 07:59:03PM +0100, Michal Koutný wrote: > > +#ifndef CONFIG_KVM_AMD_SEV > > +/* > > + * When this config is not defined, SEV feature is not supported and APIs in > > + * this file are not used but this file still gets compiled into the KVM AMD > > + * module. > > + * > > + * We will not have MISC_CG_RES_SEV and MISC_CG_RES_SEV_ES entries in the enum > > + * misc_res_type {} defined in linux/misc_cgroup.h. > BTW, was there any progress on conditioning sev.c build on > CONFIG_KVM_AMD_SEV? (So that the defines workaround isn't needeed.) Tom, Brijesh, Is this something you guys thought about or have some plans to do in the future? Basically to not include sev.c in compilation if CONFIG_KVM_AMD_SEV is disabled. Michal, This should not be a blocker for misc controller. This thing can change independent of misc cgroup. Thanks Vipin