From: Ricardo Koller <ricarkol@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH 3/5] tools headers x86: Copy cpuid helpers from the kernel
Date: Thu, 22 Apr 2021 17:08:58 -0700 [thread overview]
Message-ID: <YIIQGu82bdqjpktA@google.com> (raw)
In-Reply-To: <404e903a-5752-6ab2-9b46-aa40f7fb0fba@redhat.com>
On Thu, Apr 22, 2021 at 08:59:50AM +0200, Paolo Bonzini wrote:
> On 22/04/21 02:56, Ricardo Koller wrote:
> > Copy arch/x86/include/asm/acpufeature.h and arch/x86/kvm/reverse_cpuid.h
> > from the kernel so that KVM selftests can use them in the next commits.
> > Also update the tools copy of arch/x86/include/asm/acpufeatures.h.
>
> Typo.
>
> > These should be kept in sync, ideally with the help of some script like
> > check-headers.sh used by tools/perf/.
>
> Please provide such a script.
>
> Also, without an automated way to keep them in sync I think it's better to
> copy all of them to tools/testing/selftests/kvm
Will move them to the kvm subdir. The only issue is cpufeatures.h as
that would create a third copy of it: there is one already at
tools/arch/x86/include/asm/cpufeatures.h. Note that we can't move
cpufeatures.h from tools/arch/x86/include/asm to
tools/testing/selftests/kvm as it's already included by others like
tools/perf.
> so that we can be sure that
> a maintainer (me) runs the script and keeps them up to date. I am fairly
> sure that the x86 maintainers don't want to have anything to do with all of
> this business!
>
> Paolo
>
Thanks for the review!
I'll try this approach for the next version: copy the new headers to
tools/testing/selftests/kvm (except cpufeatures.h), and add the script.
next prev parent reply other threads:[~2021-04-23 0:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 0:56 [PATCH 0/5] KVM: x86: Use kernel x86 cpuid utilities in KVM selftests Ricardo Koller
2021-04-22 0:56 ` [PATCH 1/5] KVM: x86: Move reverse CPUID helpers to separate header file Ricardo Koller
2021-04-22 0:56 ` [PATCH 2/5] x86/cpu: Expose CPUID regs, leaf and index definitions to tools Ricardo Koller
2021-04-22 0:56 ` [PATCH 3/5] tools headers x86: Copy cpuid helpers from the kernel Ricardo Koller
2021-04-22 6:59 ` Paolo Bonzini
2021-04-23 0:08 ` Ricardo Koller [this message]
2021-04-22 0:56 ` [PATCH 4/5] KVM: selftests: Introduce utilities for checking x86 features Ricardo Koller
2021-04-22 0:56 ` [PATCH 5/5] KVM: selftests: Use kernel x86 cpuid features format Ricardo Koller
2021-04-22 7:02 ` [PATCH 0/5] KVM: x86: Use kernel x86 cpuid utilities in KVM selftests Paolo Bonzini
2021-04-28 19:46 ` Ricardo Koller
2021-06-29 17:28 ` Jim Mattson
2021-07-08 16:50 ` Paolo Bonzini
2021-07-08 17:21 ` Ricardo Koller
2021-07-08 17:57 ` Paolo Bonzini
2021-07-08 19:46 ` Ricardo Koller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIIQGu82bdqjpktA@google.com \
--to=ricarkol@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=jolsa@redhat.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).