From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A7C2C433ED for ; Tue, 27 Apr 2021 16:23:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15EAD61027 for ; Tue, 27 Apr 2021 16:23:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237732AbhD0QYe (ORCPT ); Tue, 27 Apr 2021 12:24:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:50375 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237922AbhD0QWp (ORCPT ); Tue, 27 Apr 2021 12:22:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3685A613E8; Tue, 27 Apr 2021 16:14:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619540042; bh=iJNKy1jyc1ewpilCIEXTE5LNRd9USHOEzh5sVXQBNr8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c4YWzbE16b+wOrx0Qj3/x9fWhJchKLjSqDiarZ5i15sQ+QxblkpVH0BM/5vjBFnhs qSGShTAsnBdpOl59Pp/+b26Kb47Z0QJfF32EokvL0j+h0BwIvrRFOW3tTQoWkY/VWT lhla5Tk9oq7njCe39geH8pQH/cXHgQEx+O0Mhf6E= Date: Tue, 27 Apr 2021 18:14:00 +0200 From: Greg KH To: firas ashkar Cc: mst@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] uio: uio_pci_generic: add memory mappings Message-ID: References: <20210426190346.173919-1-firas.ashkar@savoirfairelinux.com> <878b461c295c084aa7152b56668b3e61aa78f744.camel@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878b461c295c084aa7152b56668b3e61aa78f744.camel@savoirfairelinux.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Apr 27, 2021 at 10:06:39AM -0400, firas ashkar wrote: > Hi, > The reason for these extra changes is the result of running > fashkar@barbarian:~/Downloads/linux_mainline$ clang-format -style=file > -i drivers/uio/uio_pci_generic.c Please do not mix coding style changes with real fixes/additions. And always review what a tool does, some of those changes were wrong. thanks, greg k-h