From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B945C43462 for ; Tue, 4 May 2021 14:23:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01A7F61186 for ; Tue, 4 May 2021 14:23:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231579AbhEDOYl (ORCPT ); Tue, 4 May 2021 10:24:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231576AbhEDOYk (ORCPT ); Tue, 4 May 2021 10:24:40 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D256C06174A for ; Tue, 4 May 2021 07:23:44 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a4so13462115ejk.1 for ; Tue, 04 May 2021 07:23:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=ensQSDTh3BO9iGPVrV6EYBnSBYEfz7lspMmgWRr6tEM=; b=A/agEr85m2gTABKwkX7MweJdDLUWMMy/uuv8cOATtF0IOSbqQGQWqB7WVO/2i6CTej A/xEN0wabqwjnysRyxUsM6987Nm7ZjOXb3ElY7BOmpcbi2Nz6d878YWmh7i2EiFYeKva NM7Q/fRoU0PTIKl2uxcCG8z+XO6JfxPjFQ6us= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=ensQSDTh3BO9iGPVrV6EYBnSBYEfz7lspMmgWRr6tEM=; b=mjrmCYpS2wbJgDmo9jFW+IZSa1JtEGtK6zmy1a2kFEZC52XyE89qIAIDuorEWXGGYT iMs9Rkgw4R/pMSphOpNF8b3rB3diAvdwBozbanmsNCiJ6WkyHQhKJGjrxLLHe7tPPame THb9zjhJpkaC8iKHGW/wNiZ8plNZBGGMG/Ln8V+B1UJASJ+SWpbbRJexYdy7byoqa8YY Plv5ZtfVTl44S648fSPCDj3TTVCalvrxXe/UjRYHayuLIM7BuuahxYrGKU6K+fqHp3LI vh8Rbi5kChFlEEH1uitygXyuAy5SW7FyvdbWiSw6VxXwKRauJTfUNW7Fx/pKsxCbgxsu fKUw== X-Gm-Message-State: AOAM531xnofoWFjIc4QLT8QlxFIdGzT86EG/5flgBASN+xWZXTVvPKz+ ZJQXrtL/mqy3XOLmQbK8hWnk0g== X-Google-Smtp-Source: ABdhPJzaM96uclt2Tpt863I3ZtqPW7KYS209iLyt378polAbgvCVI1aPL30//Pa3FZcXPaOgGHkVGA== X-Received: by 2002:a17:906:194d:: with SMTP id b13mr22253337eje.83.1620138223252; Tue, 04 May 2021 07:23:43 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id t14sm1462204ejc.121.2021.05.04.07.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 May 2021 07:23:42 -0700 (PDT) Date: Tue, 4 May 2021 16:23:40 +0200 From: Daniel Vetter To: Greg Kurz Cc: Greg Kroah-Hartman , Christoph Hellwig , Michael Ellerman , Alex Williamson , Jason Gunthorpe , kvm@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Paul Mackerras , Daniel Vetter , linux-api@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org Subject: Re: remove the nvlink2 pci_vfio subdriver v2 Message-ID: Mail-Followup-To: Greg Kurz , Greg Kroah-Hartman , Christoph Hellwig , Michael Ellerman , Alex Williamson , Jason Gunthorpe , kvm@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Paul Mackerras , linux-api@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org References: <20210326061311.1497642-1-hch@lst.de> <20210504142236.76994047@bahia.lan> <20210504152034.18e41ec3@bahia.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210504152034.18e41ec3@bahia.lan> X-Operating-System: Linux phenom 5.10.32scarlett+ Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, May 04, 2021 at 03:20:34PM +0200, Greg Kurz wrote: > On Tue, 4 May 2021 14:59:07 +0200 > Greg Kroah-Hartman wrote: > > > On Tue, May 04, 2021 at 02:22:36PM +0200, Greg Kurz wrote: > > > On Fri, 26 Mar 2021 07:13:09 +0100 > > > Christoph Hellwig wrote: > > > > > > > Hi all, > > > > > > > > the nvlink2 vfio subdriver is a weird beast. It supports a hardware > > > > feature without any open source component - what would normally be > > > > the normal open source userspace that we require for kernel drivers, > > > > although in this particular case user space could of course be a > > > > kernel driver in a VM. It also happens to be a complete mess that > > > > does not properly bind to PCI IDs, is hacked into the vfio_pci driver > > > > and also pulles in over 1000 lines of code always build into powerpc > > > > kernels that have Power NV support enabled. Because of all these > > > > issues and the lack of breaking userspace when it is removed I think > > > > the best idea is to simply kill. > > > > > > > > Changes since v1: > > > > - document the removed subtypes as reserved > > > > - add the ACK from Greg > > > > > > > > Diffstat: > > > > arch/powerpc/platforms/powernv/npu-dma.c | 705 --------------------------- > > > > b/arch/powerpc/include/asm/opal.h | 3 > > > > b/arch/powerpc/include/asm/pci-bridge.h | 1 > > > > b/arch/powerpc/include/asm/pci.h | 7 > > > > b/arch/powerpc/platforms/powernv/Makefile | 2 > > > > b/arch/powerpc/platforms/powernv/opal-call.c | 2 > > > > b/arch/powerpc/platforms/powernv/pci-ioda.c | 185 ------- > > > > b/arch/powerpc/platforms/powernv/pci.c | 11 > > > > b/arch/powerpc/platforms/powernv/pci.h | 17 > > > > b/arch/powerpc/platforms/pseries/pci.c | 23 > > > > b/drivers/vfio/pci/Kconfig | 6 > > > > b/drivers/vfio/pci/Makefile | 1 > > > > b/drivers/vfio/pci/vfio_pci.c | 18 > > > > b/drivers/vfio/pci/vfio_pci_private.h | 14 > > > > b/include/uapi/linux/vfio.h | 38 - > > > > > > > > > Hi Christoph, > > > > > > FYI, these uapi changes break build of QEMU. > > > > What uapi changes? > > > > All macros and structure definitions that are being removed > from include/uapi/linux/vfio.h by patch 1. Just my 2cents from drm (where we deprecate old gunk uapi quite often): Imo it's best to keep the uapi headers as-is, but exchange the documentation with a big "this is removed, never use again" warning: - it occasionally serves as a good lesson for how to not do uapi (whatever the reasons really are in the specific case) - it's good to know which uapi numbers (like parameter extensions or whatever they are in this case) are defacto reserved, because there are binaries (qemu in this) that have code acting on them out there. The only exception where we completely nuke the structs and #defines is when uapi has been only used by testcases. Which we know, since we defacto limit our stable uapi guarantee to the canonical open&upstream userspace drivers only (for at least the driver-specific stuff, the cross-driver interfaces are hopeless). Anyway feel free to ignore since this might be different than drivers/gpu. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch