From: David Gibson <david@gibson.dropbear.id.au> To: "Philippe Mathieu-Daudé" <philmd@redhat.com> Cc: qemu-devel@nongnu.org, "Laurent Vivier" <laurent@vivier.eu>, "Paolo Bonzini" <pbonzini@redhat.com>, qemu-ppc@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>, "Alex Bennée" <alex.bennee@linaro.org>, "Gerd Hoffmann" <kraxel@redhat.com>, qemu-arm@nongnu.org, "Greg Kurz" <groug@kaod.org>, "open list:Overall KVM CPUs" <kvm@vger.kernel.org> Subject: Re: [PATCH v3 15/17] target/ppc/kvm: Replace alloca() by g_malloc() Date: Mon, 10 May 2021 15:38:02 +1000 [thread overview] Message-ID: <YJjGuvsB5r5f7x/F@yekko> (raw) In-Reply-To: <20210507144315.1994337-16-philmd@redhat.com> [-- Attachment #1: Type: text/plain, Size: 1429 bytes --] On Fri, May 07, 2021 at 04:43:13PM +0200, Philippe Mathieu-Daudé wrote: > The ALLOCA(3) man-page mentions its "use is discouraged". > > Use autofree heap allocation instead, replacing it by a g_malloc call. > > Reviewed-by: Greg Kurz <groug@kaod.org> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Acked-by: David Gibson <david@gibson.dropbear.id.au> > --- > target/ppc/kvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c > index 104a308abb5..23c4ea377e8 100644 > --- a/target/ppc/kvm.c > +++ b/target/ppc/kvm.c > @@ -2698,11 +2698,11 @@ int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize, int64_t max_ns) > int kvmppc_load_htab_chunk(QEMUFile *f, int fd, uint32_t index, > uint16_t n_valid, uint16_t n_invalid, Error **errp) > { > - struct kvm_get_htab_header *buf; > + g_autofree struct kvm_get_htab_header *buf = NULL; > size_t chunksize = sizeof(*buf) + n_valid * HASH_PTE_SIZE_64; > ssize_t rc; > > - buf = alloca(chunksize); > + buf = g_malloc(chunksize); > buf->index = index; > buf->n_valid = n_valid; > buf->n_invalid = n_invalid; -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-05-10 5:53 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20210507144315.1994337-1-philmd@redhat.com> 2021-05-07 14:43 ` Philippe Mathieu-Daudé 2021-05-10 5:38 ` David Gibson [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YJjGuvsB5r5f7x/F@yekko \ --to=david@gibson.dropbear.id.au \ --cc=alex.bennee@linaro.org \ --cc=groug@kaod.org \ --cc=kraxel@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=laurent@vivier.eu \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=philmd@redhat.com \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=qemu-ppc@nongnu.org \ --subject='Re: [PATCH v3 15/17] target/ppc/kvm: Replace alloca() by g_malloc()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).