From: Sean Christopherson <email@example.com> To: Jacob Xu <firstname.lastname@example.org> Cc: Paolo Bonzini <email@example.com>, Jim Mattson <firstname.lastname@example.org>, email@example.com Subject: Re: [kvm-unit-tests PATCH 2/2] x86: remove use of compiler's memset from emulator.c Date: Tue, 11 May 2021 21:13:05 +0000 [thread overview] Message-ID: <YJrzYVJXs8gNBPmF@google.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Mon, May 10, 2021, Jacob Xu wrote: > Per Sean in discussion of the previous patch, "using the compiler's > memset() in kvm-unit-tests seems inherently dangerous since the tests > are often doing intentionally stupid things." > > The string.h memset is already imported through libcflat.h, so let's use > that instead. > > Suggested-by: Sean Christopherson <email@example.com> > Signed-off-by: Jacob Xu <firstname.lastname@example.org> > --- Reviewed-by: Sean Christopherson <email@example.com>
next prev parent reply other threads:[~2021-05-11 21:13 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-11 1:50 [kvm-unit-tests PATCH 1/2] x86: Do not assign values to unaligned pointer to 128 bits Jacob Xu 2021-05-11 1:50 ` [kvm-unit-tests PATCH 2/2] x86: remove use of compiler's memset from emulator.c Jacob Xu 2021-05-11 21:13 ` Sean Christopherson [this message] 2021-06-10 16:14 ` [kvm-unit-tests PATCH 1/2] x86: Do not assign values to unaligned pointer to 128 bits Jacob Xu 2021-06-10 16:55 ` Paolo Bonzini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YJrzYVJXs8gNBPmF@google.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [kvm-unit-tests PATCH 2/2] x86: remove use of compiler'\''s memset from emulator.c' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).