From: Sean Christopherson <seanjc@google.com>
To: Yuan Yao <yuan.yao@linux.intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, Yuan Yao <yuan.yao@intel.com>
Subject: Re: [PATCH] KVM: X86: Use kvm_get_linear_rip() in single-step and #DB/#BP interception
Date: Wed, 26 May 2021 14:52:33 +0000 [thread overview]
Message-ID: <YK5gsUVi2AJkt0uu@google.com> (raw)
In-Reply-To: <20210526063828.1173-1-yuan.yao@linux.intel.com>
On Wed, May 26, 2021, Yuan Yao wrote:
> From: Yuan Yao <yuan.yao@intel.com>
>
> The kvm_get_linear_rip() handles x86/long mode cases well and has
> better readability, __kvm_set_rflags() also use the paired
> fucntion kvm_is_linear_rip() to check the vcpu->arch.singlestep_rip
^^^^^^^^
function
Please run checkpatch before submitting in the future, it will catch some of
these misspellings.
> set in kvm_arch_vcpu_ioctl_set_guest_debug(), so change the
> "CS.BASE + RIP" code in kvm_arch_vcpu_ioctl_set_guest_debug() and
> handle_exception_nmi() to this one.
>
> Signed-off-by: Yuan Yao <yuan.yao@intel.com>
Reviewed-by: Sean Christopherson <seanjc@google.com>
next prev parent reply other threads:[~2021-05-26 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 6:38 [PATCH] KVM: X86: Use kvm_get_linear_rip() in single-step and #DB/#BP interception Yuan Yao
2021-05-26 14:52 ` Sean Christopherson [this message]
2021-05-27 0:49 ` Yuan Yao
2021-05-27 13:08 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK5gsUVi2AJkt0uu@google.com \
--to=seanjc@google.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=yuan.yao@intel.com \
--cc=yuan.yao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).