From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6937BC433B4 for ; Thu, 20 May 2021 15:46:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D01361006 for ; Thu, 20 May 2021 15:46:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234736AbhETPsG (ORCPT ); Thu, 20 May 2021 11:48:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231432AbhETPsF (ORCPT ); Thu, 20 May 2021 11:48:05 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 354BDC061574 for ; Thu, 20 May 2021 08:46:44 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id v13so9292429ple.9 for ; Thu, 20 May 2021 08:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oQs9jtWBxUSYheKfenr+oS5kRIQjvZiaP96jdn9gsMU=; b=sLtEbitldgXrD8ZBjQvwX8vXZsSeGCvELvSzENcd2YSqXu9iBk1TDDVBxvGX2WckOo ZLff2Dr5rf7BZosrT+ewzXMyOMJf7XdiMM+n3CouAjKLmyJ4lGRwEzzaStNPUE+WjS7D c4LMP0I9t0UmqsR5mCkTOYB5wd2kxuubtNhodBLwxrETygnNDHDCHy31/oGVyKeNzdvA oWnKYwvfUNzPUzQWFbzq2skT99K0pE/S0vy4Ytuvbak/Y0917zqNoYtlUW9/+DpwLaIl gnMbO4DOkYo0VcpgnuDlYdMT3S9glBXtaGx55Sc4kX843kWuILdUe5osSIXS/GEEbknw Mxjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oQs9jtWBxUSYheKfenr+oS5kRIQjvZiaP96jdn9gsMU=; b=OhwbMlnQy6NeE92ZpvYlkmQlcu5GW2vsDp11siEvwAoyiEOEtP4KmDUEx3mpy45Oft kppZeMBqZfY+YA2+QVj2gYBk1PMXHYkaK69zC+C+1ROk1wG/7+DVvzviMY/dk/oI94ll riJTJB9CsZvWf4yddpCO3IYfpX1TuV3ZwlPmUuJsK61cw3e0TcEHU9T0GhyMWoawOh06 bgpCJSamShqB5DZZFoaP0TV9GOV4moMeN/UNdo8KnTTu4zQ5UM/iWrC2cxPWWVbbZ/01 joTT4f84/XTK4F2NN5yTrdhgIndSIm0o8Mnflo8cfunF1J2/84vi+Ko4Zv/tStyjs4Gp qkPw== X-Gm-Message-State: AOAM533oYI1a35rny+erwVq15mKRNPicCU0rOopS0jCMm5uu4xepgj6C rs8sen1qB3vnSmHS3UvvhZH1Lw== X-Google-Smtp-Source: ABdhPJxiFrIPGyZeGPWU+3qcevfuOBti/QMH85WV51tQ0Qoku7ZeZreMmR0xPInOvOCdtXteJDisrw== X-Received: by 2002:a17:90a:fb51:: with SMTP id iq17mr5581236pjb.4.1621525603564; Thu, 20 May 2021 08:46:43 -0700 (PDT) Received: from google.com (240.111.247.35.bc.googleusercontent.com. [35.247.111.240]) by smtp.gmail.com with ESMTPSA id x13sm2654328pja.3.2021.05.20.08.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 08:46:42 -0700 (PDT) Date: Thu, 20 May 2021 15:46:39 +0000 From: Sean Christopherson To: Joe Richey Cc: trivial@kernel.org, Joe Richey , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Mark Rutland , Lorenzo Pieralisi , Mauro Carvalho Chehab , Zhangfei Gao , Zhou Wang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org Subject: Re: [PATCH 2/6] KVM: X86: Don't use BIT() macro in UAPI headers Message-ID: References: <20210520104343.317119-1-joerichey94@gmail.com> <20210520104343.317119-3-joerichey94@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210520104343.317119-3-joerichey94@gmail.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org This feedback applies to all patches in this series. On Thu, May 20, 2021, Joe Richey wrote: > From: Joe Richey > > A previous patch Heh, I think it goes without saying that the code was introduced by a previous patch, unless you've invented a time machine, in which case we should talk... > [1] used the BIT() macro to define the > KVM_DIRTY_GFN_F_* constants in KVM's UAPI header. > > This macro is defined in the kernel but not in the UAPI headers. > > [1] https://patchwork.kernel.org/patch/11854393 Linking to the patch isn't helpful/desirable in this case because it doesn't provide any info about when the commit actually landed in the kernel. And depending on the whims of the maintainer, what was posted may not exactly match the code that was commited. What you want is a Fixes: tag that points at the offending commit. The Fixes: tag will also get the fix picked up for stable kernels, though in KVM we often explicitly add "Cc: stable@vger.kernel.org" (though IIRC tglx prefers not to have the explicit Cc). Anyways, the changelog can simply be something like: Replace BIT() in KVM's UAPI header with an open coded equivalent. BIT() is not defined in the UAPI headers and its usage may cause userspace build errors. Fixes: fb04a1eddb1a ("KVM: X86: Implement ring-based dirty memory tracking") Signed-off-by: Joe Richey