From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8B55C433ED for ; Thu, 20 May 2021 15:50:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9955761163 for ; Thu, 20 May 2021 15:50:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232589AbhETPve (ORCPT ); Thu, 20 May 2021 11:51:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231513AbhETPvd (ORCPT ); Thu, 20 May 2021 11:51:33 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 782CAC06175F for ; Thu, 20 May 2021 08:50:12 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id e17so2061198pfl.5 for ; Thu, 20 May 2021 08:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pWfEJ33HmYjyJ1Y5NXIDf1GmNE5PqL3F2Pv45dftgSU=; b=EdlG5Qf7QEWX704/Y6+GYnd32o0nYlnE3E/NiWhrP8dFMil+TqElUzyv7omguVtwPy YhWJOheS/s5hIMi/LxAUa8cGzj4mUq90S+cNqYNcW7QdS33FRMMkowf3JvT71JcwYg5R GNFacIMxL63N9DCAoJ25Z3e8VbnLFY7/i4wg2phjrlPgwSW4uncK7u3Jm6MujnNnmY2H R2+VJj4UxbLn4T1pA6tYFLp9IeHHWzteD+jKFwQOABdmoMrkqJxR305obI6O+YERz3X1 Ldo0fMLzyns1tgycBjHWwK18AuyVvUEk9670Ddhgzb/9QmW4cv9SW7iHg+c7JUZGLJSl 4t2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pWfEJ33HmYjyJ1Y5NXIDf1GmNE5PqL3F2Pv45dftgSU=; b=Lo6hnqKOEmsqD7NrFMQ9ZDmE6egoj/cTRdBUw7oicK2ddTP5OrknMkYcugB9e0xkJ4 V4oWfuFA7aBGu+9oaFz2FqdHM3mibGeINv6y7JuiA5s8un4AVSwZbeI7V7LOEVF0/hxF 5uTz3dP7FYnPAFXcDYqEdZ7lPzmtT/Lqsuytw4cJ7XN20a/V2L9gD00VW4cj+dSnJBv6 oPbbjGkQDsHH5zFIUE0Anc10VMoUFp+VgUp5Mm+gPgmbGIHFnF4cM+x+R5hsNjtvQT2J nV0vJ7Isr4iHZbdJ4VGGUfmdyK3n0LO9+249R1ZFK68GHhgruR//cjFQFrzUw1sBLm9K W/PA== X-Gm-Message-State: AOAM530yKF0znZxeFp1TTeS1qA9GJnZkJnAwD9vohtU8DQkduAr6VExB 2AtOXXrwHyertuw+G60WpYcluw== X-Google-Smtp-Source: ABdhPJxpB51ovb+xOMBMfQ27ebYcjzzqo75xRL/4ldCDgC3y2w/k3e8jb2E74WRsVJp1Z/4CAYodIw== X-Received: by 2002:a63:f5c:: with SMTP id 28mr5378882pgp.84.1621525811763; Thu, 20 May 2021 08:50:11 -0700 (PDT) Received: from google.com (240.111.247.35.bc.googleusercontent.com. [35.247.111.240]) by smtp.gmail.com with ESMTPSA id f83sm2300640pfa.163.2021.05.20.08.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 08:50:11 -0700 (PDT) Date: Thu, 20 May 2021 15:50:07 +0000 From: Sean Christopherson To: Borislav Petkov Cc: Joe Richey , trivial@kernel.org, Joe Richey , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Mark Rutland , Lorenzo Pieralisi , Mauro Carvalho Chehab , Zhangfei Gao , Zhou Wang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org Subject: Re: [PATCH 0/6] Don't use BIT() macro in UAPI headers Message-ID: References: <20210520104343.317119-1-joerichey94@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, May 20, 2021, Borislav Petkov wrote: > On Thu, May 20, 2021 at 03:43:37AM -0700, Joe Richey wrote: > > This patch series changes all UAPI uses of BIT() to just be open-coded. > > However, there really should be a check for this in checkpatch.pl > > Wanna add that check too? > > > Currently, the script actually _encourages_ users to use the BIT macro > > even if adding things to UAPI. > > How so? > > This is with your first patch: > > $ ./scripts/checkpatch.pl /tmp/bit.01 > total: 0 errors, 0 warnings, 7 lines checked > > /tmp/bit.01 has no obvious style problems and is ready for submission. > > Also, in your commit messages you refer to patches with patchwork links > - please use the respective upstream commit IDs instead. Grep for > "Fixes:" here: Gah, beat me to the punch. Stupid weird mutt sorting.