Re: [PATCH v4 5/6] KVM: selftests: Add exception handling support for aarch64

[Ricardo Koller <ricarkol@google.com>]

On Fri, Jul 02, 2021 at 02:46:57PM +0800, Zenghui Yu wrote:
> [+Sean]
> 
> On 2021/6/11 9:10, Ricardo Koller wrote:
> > Add the infrastructure needed to enable exception handling in aarch64
> > selftests. The exception handling defaults to an unhandled-exception
> > handler which aborts the test, just like x86. These handlers can be
> > overridden by calling vm_install_exception_handler(vector) or
> > vm_install_sync_handler(vector, ec). The unhandled exception reporting
> > from the guest is done using the ucall type introduced in a previous
> > commit, UCALL_UNHANDLED.
> > 
> > The exception handling code is inspired on kvm-unit-tests.
> > 
> > Signed-off-by: Ricardo Koller <ricarkol@google.com>
> > ---
> >  tools/testing/selftests/kvm/Makefile          |   2 +-
> >  .../selftests/kvm/include/aarch64/processor.h |  63 +++++++++
> >  .../selftests/kvm/lib/aarch64/handlers.S      | 126 ++++++++++++++++++
> >  .../selftests/kvm/lib/aarch64/processor.c     |  97 ++++++++++++++
> >  4 files changed, 287 insertions(+), 1 deletion(-)
> >  create mode 100644 tools/testing/selftests/kvm/lib/aarch64/handlers.S
> 
> [...]
> 
> > +void vm_init_descriptor_tables(struct kvm_vm *vm)
> > +{
> > +	vm->handlers = vm_vaddr_alloc(vm, sizeof(struct handlers),
> > +			vm->page_size, 0, 0);
> 
> This raced with commit a75a895e6457 ("KVM: selftests: Unconditionally
> use memslot 0 for vaddr allocations") which dropped memslot parameters
> from vm_vaddr_alloc().

Will send a fix to use vm_vaddr_alloc() without the memslot parameters.

> 
> We can remove the related comments on top of vm_vaddr_alloc() as well.

Can do this as well, will send a separate patch removing this. Unless
somebody was about to.

> 
> Zenghui

Thanks,
Ricardo